From d571b169f4b18811f767a272b0ee12793753ff06 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Tue, 14 Feb 2012 18:56:03 +0200 Subject: [PATCH] Re: [PATCH] emacs: Fix display of highlighted line in notmuch-show --- fa/67fefa7282fc8006148a64a2316c1be7c6c01a | 121 ++++++++++++++++++++++ 1 file changed, 121 insertions(+) create mode 100644 fa/67fefa7282fc8006148a64a2316c1be7c6c01a diff --git a/fa/67fefa7282fc8006148a64a2316c1be7c6c01a b/fa/67fefa7282fc8006148a64a2316c1be7c6c01a new file mode 100644 index 000000000..d3388a67f --- /dev/null +++ b/fa/67fefa7282fc8006148a64a2316c1be7c6c01a @@ -0,0 +1,121 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 26E43431FBC + for ; Tue, 14 Feb 2012 08:56:15 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id jTw2o3Ggiwno for ; + Tue, 14 Feb 2012 08:56:11 -0800 (PST) +Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 1E0E1431FAF + for ; Tue, 14 Feb 2012 08:56:10 -0800 (PST) +Received: by lahd3 with SMTP id d3so162656lah.26 + for ; Tue, 14 Feb 2012 08:56:08 -0800 (PST) +Received: by 10.112.103.228 with SMTP id fz4mr4257616lbb.99.1329238567995; + Tue, 14 Feb 2012 08:56:07 -0800 (PST) +Received: from localhost (dsl-hkibrasgw4-fe50f800-253.dhcp.inet.fi. + [84.248.80.253]) + by mx.google.com with ESMTPS id mc3sm16688007lab.12.2012.02.14.08.56.05 + (version=SSLv3 cipher=OTHER); Tue, 14 Feb 2012 08:56:06 -0800 (PST) +From: Jani Nikula +To: Michal Sojka , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: Fix display of highlighted line in notmuch-show +In-Reply-To: <1329215056-25753-1-git-send-email-sojka@os.inf.tu-dresden.de> +References: <1329215056-25753-1-git-send-email-sojka@os.inf.tu-dresden.de> +User-Agent: Notmuch/0.11.1+182~g79d6dde (http://notmuchmail.org) Emacs/23.3.1 + (i686-pc-linux-gnu) +Date: Tue, 14 Feb 2012 18:56:03 +0200 +Message-ID: <87mx8lpd5o.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Gm-Message-State: + ALoCoQlUcOECeeQzDYQu4vUhSEUQvF/uju548FODJyaFxFn3iK7bzWiOfnFTcilgR8Cp4ZlDNvIV +Cc: Michal Sojka +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 14 Feb 2012 16:56:15 -0000 + +On Tue, 14 Feb 2012 11:24:16 +0100, Michal Sojka wrote: +> When notmuch-search-line-faces is used to set background color in search +> results, the highlight of the current line is not always displayed +> correctly. This patch fixes that by increasing the priority property of +> the highlight overlay. + +One nitpick: The subject line refers to notmuch-show. + +BR, +Jani. + +> --- +> emacs/notmuch.el | 15 +++++++++++---- +> 1 files changed, 11 insertions(+), 4 deletions(-) +> +> diff --git a/emacs/notmuch.el b/emacs/notmuch.el +> index 5b4f1c5..f851c6f 100644 +> --- a/emacs/notmuch.el +> +++ b/emacs/notmuch.el +> @@ -249,10 +249,17 @@ For a mouse binding, return nil." +> (set-buffer-modified-p nil) +> (view-buffer (current-buffer) 'kill-buffer-if-not-modified)))) +> +> -(defcustom notmuch-search-hook '(hl-line-mode) +> +(require 'hl-line) +> + +> +(defun notmuch-hl-line-mode () +> + (prog1 (hl-line-mode) +> + (when hl-line-overlay +> + (overlay-put hl-line-overlay 'priority 1)))) +> + +> +(defcustom notmuch-search-hook '(notmuch-hl-line-mode) +> "List of functions to call when notmuch displays the search results." +> :type 'hook +> - :options '(hl-line-mode) +> + :options '(notmuch-hl-line-mode) +> :group 'notmuch-search +> :group 'notmuch-hooks) +> +> @@ -567,7 +574,7 @@ a list of strings of the form \"+TAG\" or \"-TAG\". +> the messages that are about to be tagged" +> +> :type 'hook +> - :options '(hl-line-mode) +> + :options '(notmuch-hl-line-mode) +> :group 'notmuch-hooks) +> +> (defcustom notmuch-after-tag-hook nil +> @@ -578,7 +585,7 @@ a list of strings of the form \"+TAG\" or \"-TAG\". +> 'query' will be a string containing the search query that determines +> the messages that were tagged" +> :type 'hook +> - :options '(hl-line-mode) +> + :options '(notmuch-hl-line-mode) +> :group 'notmuch-hooks) +> +> (defun notmuch-search-set-tags (tags) +> -- +> 1.7.7.3 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2