From d44092e2d411195d0d80b27014f5d1ced8d6b5d7 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sun, 1 Apr 2012 14:29:01 +2100 Subject: [PATCH] Re: [PATCH 1/7] Split notmuch_database_close into two functions --- e0/82c9279fba0c1110d87b9fe5b2fcf4cb9422d5 | 72 +++++++++++++++++++++++ 1 file changed, 72 insertions(+) create mode 100644 e0/82c9279fba0c1110d87b9fe5b2fcf4cb9422d5 diff --git a/e0/82c9279fba0c1110d87b9fe5b2fcf4cb9422d5 b/e0/82c9279fba0c1110d87b9fe5b2fcf4cb9422d5 new file mode 100644 index 000000000..954dc0960 --- /dev/null +++ b/e0/82c9279fba0c1110d87b9fe5b2fcf4cb9422d5 @@ -0,0 +1,72 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 682DA431FAF + for ; Sat, 31 Mar 2012 10:29:11 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id u-Iw8Pkm4bpu for ; + Sat, 31 Mar 2012 10:29:09 -0700 (PDT) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 48DA6431FAE + for ; Sat, 31 Mar 2012 10:29:09 -0700 (PDT) +Received: from fctnnbsc30w-142166230117.dhcp-dynamic.fibreop.nb.bellaliant.net + ([142.166.230.117] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) + (Exim 4.72) (envelope-from ) + id 1SE26s-0004J5-Gy; Sat, 31 Mar 2012 14:29:06 -0300 +Received: from bremner by zancas.localnet with local (Exim 4.77) + (envelope-from ) + id 1SE26n-0002RS-6i; Sat, 31 Mar 2012 14:29:01 -0300 +From: David Bremner +To: Mark Walters , + Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org +Subject: Re: [PATCH 1/7] Split notmuch_database_close into two functions +In-Reply-To: <87fwcopu5g.fsf@qmul.ac.uk> +References: + <1332291311-28954-1-git-send-email-4winter@informatik.uni-hamburg.de> + <1332291311-28954-2-git-send-email-4winter@informatik.uni-hamburg.de> + <87fwcopu5g.fsf@qmul.ac.uk>User-Agent: Notmuch/0.12+70~g46e73fe + (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) +Date: Sat, 31 Mar 2012 14:29:01 -0300 +Message-ID: <87sjgo1xya.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Spam_bar: - +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 31 Mar 2012 17:29:11 -0000 + +Mark Walters writes: + +> The first is a concern that if we change the library functions we should +> update the library version otherwise out of tree users won't know which +> to call. + +This is not such a big deal. We can update the SONAME of the library so +that old code will continute to dynamically link to the old version of +the library. Nothing [1] will magically make the old code work with the +new library if we change the API; that is just the way things go, +occasionally APIs and/or ABIs change. + +[1] Well maybe symbol versioning. I don't fully understand that, but I +suspect it is more trouble than it is worth. -- 2.26.2