From d15635a51243ecd4674c939175c27131404cafee Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Sat, 8 Dec 2012 09:29:02 +0000 Subject: [PATCH] Re: [PATCH 00/10] CLI output versioning --- c2/dfeb577f1712394d917ebbb68a11e1e8276f54 | 128 ++++++++++++++++++++++ 1 file changed, 128 insertions(+) create mode 100644 c2/dfeb577f1712394d917ebbb68a11e1e8276f54 diff --git a/c2/dfeb577f1712394d917ebbb68a11e1e8276f54 b/c2/dfeb577f1712394d917ebbb68a11e1e8276f54 new file mode 100644 index 000000000..d2a6f3b5e --- /dev/null +++ b/c2/dfeb577f1712394d917ebbb68a11e1e8276f54 @@ -0,0 +1,128 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 176E1431FAF + for ; Sat, 8 Dec 2012 01:29:03 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 9G8RA9odOKv3 for ; + Sat, 8 Dec 2012 01:29:02 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 6FBD5431FAE + for ; Sat, 8 Dec 2012 01:29:02 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1ThGiQ-0001OI-1i; Sat, 08 Dec 2012 09:28:58 +0000 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1ThGiP-0004oA-OS; Sat, 08 Dec 2012 09:28:57 +0000 +From: Mark Walters +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 00/10] CLI output versioning +In-Reply-To: <87pq2sx86o.fsf@awakening.csail.mit.edu> +References: <1354416002-3557-1-git-send-email-amdragon@mit.edu> + <87pq2sx86o.fsf@awakening.csail.mit.edu> +User-Agent: Notmuch/0.14+81~g9730584 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sat, 08 Dec 2012 09:29:02 +0000 +Message-ID: <878v98hoyp.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: eb4857d49b031bd1c3ca44b88d174820 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 08 Dec 2012 09:29:03 -0000 + + +Hi + +Overall this series looks good. As we discussed on irc I think i would +prefer global NOTMUCH_SCHEMA_MIN as I am a little worried about these +proliferating (eg if someone decides text output also needs versioning +etc) In addition, if we do find the distinction useful it would be easy +to add at a later date. + +One tiny comment on the manpage updates: now that you mention two return +values explicitly should the other possibilities be mentioned too or are +they so obvious it is not needed? + +Would it be worth having some emacs test for the error handling? (eg set +notmuch-command to something giving some stderr and an error) Inherently +these code paths won't be tested much so I think tests could be +particularly useful. + +Best wishes + +Mark + + + + + + +On Mon, 03 Dec 2012, Austin Clements wrote: +> (Sorry; I forgot to include a cover letter.) +> +> This series is intended to help with our long-standing output format +> versioning issue. While the JSON format is amenable to extension, +> there's still a high barrier to extensions because of the need to +> support them going forward, and an even higher barrier to modifications +> that break backwards compatibility. Versioning will make the format +> more dynamic, enabling us to easily improve and iterate on it. It will +> also address the slew of confusing bugs that people encounter when they +> use a mismatched CLI and front-end. +> +> On IRC we've talking about adding version information to the output +> format itself. This series takes a different and, I think, better +> approach: callers request a specific output format version on the +> command line. This allows notmuch to remain backwards compatible with +> older format versions when it's easy or necessary. This also doesn't +> require shoehorning a version number into the output, which would be +> awkward for both the CLI and the consumer. +> +> I called the argument --use-schema, but I'm open to other suggestions. +> --use-schema is technically accurate, but perhaps not as self-describing +> as something like --schema-version or --format-version (to parallel +> --format). +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2