From d051e4645cb8cc17fe9144bd5f4426d5085c16d3 Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Sun, 15 Apr 2012 12:33:03 +1700 Subject: [PATCH] Re: [PATCH v4 0/6] Config-related patches --- 85/28af7ac1a24ea5359b902396bb1e420de40155 | 99 +++++++++++++++++++++++ 1 file changed, 99 insertions(+) create mode 100644 85/28af7ac1a24ea5359b902396bb1e420de40155 diff --git a/85/28af7ac1a24ea5359b902396bb1e420de40155 b/85/28af7ac1a24ea5359b902396bb1e420de40155 new file mode 100644 index 000000000..16f94f02f --- /dev/null +++ b/85/28af7ac1a24ea5359b902396bb1e420de40155 @@ -0,0 +1,99 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 162A7431FAF + for ; Sat, 14 Apr 2012 12:33:09 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id mYY0ul5Yp-az for ; + Sat, 14 Apr 2012 12:33:08 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id A363F431FAE + for ; Sat, 14 Apr 2012 12:33:08 -0700 (PDT) +Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by earth-doxen-postvirus (Postfix) with ESMTP id 4F1EF66E0142; + Sat, 14 Apr 2012 12:33:08 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new +Received: from finestructure.net (unknown [76.89.193.65]) + (Authenticated sender: jrollins) + by earth-doxen-submit (Postfix) with ESMTP id 8D01766E012F; + Sat, 14 Apr 2012 12:33:04 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id 45A5845D; Sat, 14 Apr 2012 12:33:04 -0700 (PDT) +From: Jameson Graef Rollins +To: Mark Walters , Peter Wang , + notmuch@notmuchmail.org +Subject: Re: [PATCH v4 0/6] Config-related patches +In-Reply-To: <87zkaelnxr.fsf@qmul.ac.uk> +References: <1332282698-7951-1-git-send-email-novalazy@gmail.com> + <1334367666-10954-1-git-send-email-novalazy@gmail.com> + <87zkaelnxr.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.12+112~gffb05d6 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sat, 14 Apr 2012 12:33:03 -0700 +Message-ID: <87sjg6yuq8.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 14 Apr 2012 19:33:09 -0000 + +--=-=-= + +On Sat, Apr 14 2012, Mark Walters wrote: +> Two minor comments which you might like to consider (but definitely are +> not required): +> 1) You could check that there are no further arguments when the user +> calls `notmuch config list' + +This doesn't seem so necessary to me. I'm fine if it just silently +ignores extra arguments. + +> 2) In the man page you could explicitly say what the output is for a +> configuration item which has not been set. + +I'm also fine with it as it is. I think it's implied that if the value +is null then the field is left blank. That's ok. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBCAAGBQJPidDwAAoJEO00zqvie6q8Kf8QAKMPXert7BUs163SEDKnfUu/ +tw9wRYDtEodRHRuS2g7P9MxcV25JjbOiQ9JiUjv2dRMW9R9O0O7iQUNZMEO03O9z +n1wv9qeSfUarhIh6d99dtPtb/l8jZVt7QO9RYeIujOh/YFd7CIhTDiZdjm5b13R6 +6frw1mHtyTizzq4QIJOr4sD5jXU78ojQjFNTmv35lvzJ4zBsgORAcCk1T+YfHPYc +2DcPeR2PhuYPBixiw2c6yAadY6c5a+hAvOEX0Gh+FcV0K/0cY63vIDjR9Zaf7Uz+ +xVZbF2pJyDrhNR+HuaFMOJQx0kcGUB2HeNgQU0it6zbBc6EIArhnflTE+hWLkd1g +xgMBFenUWpu8BShAJ7DH6LKxealQram2xMnyIOrJ0hnq7acqUdPsSzHTJhxmE2YG +c/sVJhr/clNNP0vpoV+nwkLbRI2Xj3wWCBPCNv4x//AwFxIYMbMdSqLOU1WdKhFW +LEWFGESIGjHvPIVcM+sFCOJyyEZT9cpStMeaDGWXLOtFGBNt5uWXDhrikr0mPdPF +nHCVByVUzV47pTv78SrKGqTiKodkaU14e0hNRJh+ZfdSs2M/E1TYGVElRVWrhGvP +xPH++Nt59WK+cQpTnKq4AU9PWCMa+fpLacQu3JVRwLhHttOImhtzNRT6ApIQDPc+ +RjHetQG9ZumSgE4NlRYU +=11cv +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2