From d02950a8d4ddb63d4eb28a34a2a3eea39639ea14 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Thu, 12 Apr 2012 22:20:52 +0300 Subject: [PATCH] Re: [PATCH] emacs-show: open excluded matches if no other matches --- d0/561015e98ae877e79396baad671295e9ea0a49 | 80 +++++++++++++++++++++++ 1 file changed, 80 insertions(+) create mode 100644 d0/561015e98ae877e79396baad671295e9ea0a49 diff --git a/d0/561015e98ae877e79396baad671295e9ea0a49 b/d0/561015e98ae877e79396baad671295e9ea0a49 new file mode 100644 index 000000000..6321fe19a --- /dev/null +++ b/d0/561015e98ae877e79396baad671295e9ea0a49 @@ -0,0 +1,80 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 717C0431FAF + for ; Thu, 12 Apr 2012 12:20:57 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id EZlQa-lbc8o2 for ; + Thu, 12 Apr 2012 12:20:55 -0700 (PDT) +Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66]) + by olra.theworths.org (Postfix) with ESMTP id 542E2431FAE + for ; Thu, 12 Apr 2012 12:20:55 -0700 (PDT) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id 911E568055; Thu, 12 Apr 2012 22:20:52 +0300 (EEST) +From: Tomi Ollila +To: Jameson Graef Rollins , + Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs-show: open excluded matches if no other matches +In-Reply-To: <8762d44vkv.fsf@servo.finestructure.net> +References: <1331836090-30560-1-git-send-email-markwalters1009@gmail.com> + <8762d44vkv.fsf@servo.finestructure.net> +User-Agent: Notmuch/0.12+104~gf9ad237 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 12 Apr 2012 19:20:57 -0000 + +On Thu, Apr 12 2012, Jameson Graef Rollins wrote: + +> On Thu, Mar 15 2012, Mark Walters wrote: +>> Currently emacs show does not open matching but excluded +>> messages. This is normally the desired behaviour but is probably not +>> ideal if only excluded messages match. This patch opens all the +>> matching (necessarily excluded) messages in this case and goes to the +>> first one. +> +> Hi, Mark. I have tested this patch and it LGTM. I think this is the +> behavior we want, since it's no fun to open up a show buffer and have +> all messages in the thread closed. That doesn't make much sense. + +I disagree: If I open up a show buffer I'd like to have all messages +in the thread closed if search terms do not match. But that is my +opinion and inconsistent with current behaviour. + +(Therefore I already +1:d this patch) + +An example: I have thread of 100 messages and 1 of those is unread. +Search terms is tag:unread. I enter the thread: 99 messages closed +and this one open. Now unread is automatically removed. If I go back +to search view (by pressing q) and re-choose the same thread, +current behaviour is to open all 100 messages. I'd like to see all +100 messages closed. + +> jamie. + +Tomi -- 2.26.2