From cf069b2b116075971162bc3f49ff2375f693703b Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sun, 23 Dec 2012 09:21:40 +2000 Subject: [PATCH] Re: [PATCH 1/1] lib/message-file.c: use g_malloc () & g_free () in hash table values --- 46/2000b8a42284b5dcc7983cf1980b7f5a572bde | 75 +++++++++++++++++++++++ 1 file changed, 75 insertions(+) create mode 100644 46/2000b8a42284b5dcc7983cf1980b7f5a572bde diff --git a/46/2000b8a42284b5dcc7983cf1980b7f5a572bde b/46/2000b8a42284b5dcc7983cf1980b7f5a572bde new file mode 100644 index 000000000..df74df703 --- /dev/null +++ b/46/2000b8a42284b5dcc7983cf1980b7f5a572bde @@ -0,0 +1,75 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E67AE431FAF + for ; Sat, 22 Dec 2012 05:21:51 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id XW8CxdqoXoVS for ; + Sat, 22 Dec 2012 05:21:51 -0800 (PST) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id EC5AF431FAE + for ; Sat, 22 Dec 2012 05:21:50 -0800 (PST) +Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.82.78] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) + (envelope-from ) + id 1TmP1O-0006uP-IP; Sat, 22 Dec 2012 09:21:47 -0400 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1TmP1J-0005Ru-0X; Sat, 22 Dec 2012 09:21:41 -0400 +From: David Bremner +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/1] lib/message-file.c: use g_malloc () & g_free () in + hash table values +In-Reply-To: <1356112321-6332-1-git-send-email-tomi.ollila@iki.fi> +References: <1356112321-6332-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Notmuch/0.14+213~g4af1ac6 (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-pc-linux-gnu) +Date: Sat, 22 Dec 2012 09:21:40 -0400 +Message-ID: <87sj6yte6z.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 22 Dec 2012 13:21:52 -0000 + +Tomi Ollila writes: + +> @@ -111,7 +111,7 @@ _notmuch_message_file_open_ctx (void *ctx, const char *filename) +> message->headers = g_hash_table_new_full (strcase_hash, +> strcase_equal, +> free, +> - free); +> + g_free); + +It slightly icky that the keys in this hash table are allocated/freed +with (x)malloc/(x)free, and the values with g_malloc/g_free, but that's +not your fault, and it's an improvement on what we had before, so +1 +from me. + +d + + -- 2.26.2