From cf05fcadf37ce6475cafb59730196c78e33449f2 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Wed, 25 Apr 2012 08:54:57 +0100 Subject: [PATCH] Re: [PATCH] emacs: add a filter option to show --- 89/805526156837c31d248e3b91fe053131b623d4 | 102 ++++++++++++++++++++++ 1 file changed, 102 insertions(+) create mode 100644 89/805526156837c31d248e3b91fe053131b623d4 diff --git a/89/805526156837c31d248e3b91fe053131b623d4 b/89/805526156837c31d248e3b91fe053131b623d4 new file mode 100644 index 000000000..0904b04c4 --- /dev/null +++ b/89/805526156837c31d248e3b91fe053131b623d4 @@ -0,0 +1,102 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 89A4E431FAF + for ; Wed, 25 Apr 2012 00:54:44 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id c0+nIsSRsoLm for ; + Wed, 25 Apr 2012 00:54:44 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id EE7F6431FAE + for ; Wed, 25 Apr 2012 00:54:43 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1SMx3e-00064b-Mc; Wed, 25 Apr 2012 08:54:38 +0100 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1SMx3e-0003tW-Be; Wed, 25 Apr 2012 08:54:38 +0100 +From: Mark Walters +To: Austin Clements +Subject: Re: [PATCH] emacs: add a filter option to show +In-Reply-To: <20120425025506.GM17810@mit.edu> +References: <1335309421-18893-1-git-send-email-markwalters1009@gmail.com> + <20120425025506.GM17810@mit.edu> +User-Agent: Notmuch/0.12+128~g0f26d91 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Wed, 25 Apr 2012 08:54:57 +0100 +Message-ID: <87ty081c1a.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: d431bbb5df550fdd8b03c89b8ed34ef1 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 25 Apr 2012 07:54:44 -0000 + +On Wed, 25 Apr 2012, Austin Clements wrote: +> LGTM. I've been wanting this functionality for a while, but have been +> too lazy to implement it myself. +> +> I do have one request, though. Could we bind this to 'l' for "limit"? +> Generally we've been quite good at making the shift key a modifier to +> the functionality of the lower-case binding, which argues against 'F'. +> It would also make sense to switch away from 'f' for filtering +> (limiting) in search-view; 'f' is one of the few bindings that's used +> in both search and show mode with completely different meanings and +> 'l' would be a good candidate for the related functionality in both +> views. + +Yes I think that is a good idea. I will wait a little for other replies +and then send a new version. + +I think 'f' in search view should do a "forward-thread" functionality +which could also be linked from 'F' in show mode. I know we don't have +this functionality yet but unless people think it is not worth +supporting I think reserving the natural key is worth while. + +Best wishes + +Mark + -- 2.26.2