From ced7e0dd0ef00e8d9321785fb338db91dd66a5c9 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Thu, 1 Mar 2012 10:48:16 +0200 Subject: [PATCH] Re: [PATCH 0/5] Disable search.exclude_tags for 0.12 --- 09/6f48ded47bf9253a0bfb8d5409e6b441408e25 | 123 ++++++++++++++++++++++ 1 file changed, 123 insertions(+) create mode 100644 09/6f48ded47bf9253a0bfb8d5409e6b441408e25 diff --git a/09/6f48ded47bf9253a0bfb8d5409e6b441408e25 b/09/6f48ded47bf9253a0bfb8d5409e6b441408e25 new file mode 100644 index 000000000..83d64a74f --- /dev/null +++ b/09/6f48ded47bf9253a0bfb8d5409e6b441408e25 @@ -0,0 +1,123 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 228B3431E64 + for ; Thu, 1 Mar 2012 00:48:19 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id yBhCNYRrLTOx for ; + Thu, 1 Mar 2012 00:48:18 -0800 (PST) +Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66]) + by olra.theworths.org (Postfix) with ESMTP id 3C310431FAE + for ; Thu, 1 Mar 2012 00:48:18 -0800 (PST) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id 007F968055; Thu, 1 Mar 2012 10:48:16 +0200 (EET) +From: Tomi Ollila +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH 0/5] Disable search.exclude_tags for 0.12 +In-Reply-To: <1330539189-16593-1-git-send-email-markwalters1009@gmail.com> +References: <1330539189-16593-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.11.1+246~gbf28c60 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 01 Mar 2012 08:48:19 -0000 + +On Wed, 29 Feb 2012 18:13:04 +0000, Mark Walters wrote: +> As requested by David (Bremner) on irc here is a patch series +> disabling the search.exclude_tags feature as a temporary measure for +> the 0.12 release. +> +> There are two options: +> +> The first is to disable the addition of the new search.exclude_tags +> item to the config file and stop setup from asking for it. +> +> The second is to do the above and also disable the functionality in +> notmuch-search.c and notmuch-count.c. + +I first thought that "full" revert would be best in order to reduce +confusion, but now I'd vote for just disabling the addition but leaving +the feature there. +This way the bleeding edge users who already use this feature could +test the release branch version in daily use. As the feature is there +some brave future 0.12 users can start experimenting with it earlyer +and potentially provide feedback. Finally, as the delta is smaller +there is less management activities to be done. +Marking the feature as 'experimental' in namual page & other documentation +would be good idea. + +Tomi + +> The idea is that this these are minimal (and thus relatively safe) +> changes to make. With the first option users who have configured the +> functionality for themselves (while using git) will still get the +> feature: it just won't be pushed on users. With the second option the +> festure will be completely disabled. +> +> Essentially patch 1 implements the first option and patch 4 the second +> option. The other patches in the series update the NEWS file, the man +> page and the tests. If going for the first option then I would suggest +> applying (in addition to patch 1) patch 2 (NEWS) and probably patch 3 +> (man) although as the functionality remains the latter is not strictly +> necessary. The test patch (patch 5) is not necessary as the tests set +> search.exclude_tags directly. +> +> If going for the second option then all the patches are needed. +> +> Finally, please could someone familiar with the config/setup code +> check patch 1 carefully. I have never looked at that code before and +> could easily have done something stupid. +> +> Best wishes +> +> Mark +> +> Mark Walters (5): +> config: disable addition of exclude tags for 0.12 +> NEWS: revert NEWS item for exclude tags for 0.12 +> man: remove search.exclude_tags from notmuch-config.1 for 0.12 +> cli: temporarily remove exclude tag support for 0.12 +> test: mark exclude tests broken for 0.12 +> +> NEWS | 18 ------------------ +> man/man1/notmuch-config.1 | 8 -------- +> notmuch-config.c | 3 +-- +> notmuch-count.c | 8 +------- +> notmuch-search.c | 8 +------- +> notmuch-setup.c | 19 +------------------ +> test/search | 2 ++ +> 7 files changed, 6 insertions(+), 60 deletions(-) +> +> -- +> 1.7.2.3 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch +> -- 2.26.2