From cde8f2b5b067c0036453c6b3f3e38e8659c280f8 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Thu, 9 Feb 2012 09:54:30 +0200 Subject: [PATCH] Re: [PATCH] emacs: cleanup and simplify `notmuch-show-archive-thread' and related functions --- 25/e3672d1aa122c0aead21abf0d7c6f896a4933d | 65 +++++++++++++++++++++++ 1 file changed, 65 insertions(+) create mode 100644 25/e3672d1aa122c0aead21abf0d7c6f896a4933d diff --git a/25/e3672d1aa122c0aead21abf0d7c6f896a4933d b/25/e3672d1aa122c0aead21abf0d7c6f896a4933d new file mode 100644 index 000000000..f454d6fec --- /dev/null +++ b/25/e3672d1aa122c0aead21abf0d7c6f896a4933d @@ -0,0 +1,65 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 00E1B431FAF + for ; Wed, 8 Feb 2012 23:54:32 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id I3WCIyph6GVw for ; + Wed, 8 Feb 2012 23:54:31 -0800 (PST) +Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66]) + by olra.theworths.org (Postfix) with ESMTP id 474C1431FAE + for ; Wed, 8 Feb 2012 23:54:31 -0800 (PST) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id 7C17468055; Thu, 9 Feb 2012 09:54:30 +0200 (EET) +From: Tomi Ollila +To: Dmitry Kurochkin , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: cleanup and simplify `notmuch-show-archive-thread' + and related functions +In-Reply-To: <1328719731-13402-1-git-send-email-dmitry.kurochkin@gmail.com> +References: <1328719731-13402-1-git-send-email-dmitry.kurochkin@gmail.com> +User-Agent: Notmuch/0.11.1+164~g6619341 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 09 Feb 2012 07:54:32 -0000 + +On Wed, 8 Feb 2012 20:48:51 +0400, Dmitry Kurochkin wrote: +> Recent changes in notmuch-show tagging introduced some code +> duplication. The patch cleanups and simplifies +> `notmuch-show-archive-thread' function by using +> `notmuch-show-tag-all', no longer used function are removed. After +> the change, `notmuch-show-archive-thread' function becomes symmetric +> with `notmuch-show-archive-message'. +> +> A side effect of these changes is that `notmuch-show-archive-thread' +> no longer calls "notmuch tag" for each message in the thread. +> --- + ++1, works fine, is fast + +Tomi -- 2.26.2