From cda6fbf42259cfef7bcbd4d5a7f7559364b0f3db Mon Sep 17 00:00:00 2001 From: david Date: Mon, 7 Jan 2013 10:04:56 +2000 Subject: [PATCH] [Patch v2] notmuch-restore: handle empty input file, leading blank lines and comments. --- 3c/a9696af13b95b0c97164060127abc99896fec4 | 134 ++++++++++++++++++++++ 1 file changed, 134 insertions(+) create mode 100644 3c/a9696af13b95b0c97164060127abc99896fec4 diff --git a/3c/a9696af13b95b0c97164060127abc99896fec4 b/3c/a9696af13b95b0c97164060127abc99896fec4 new file mode 100644 index 000000000..8f47a010a --- /dev/null +++ b/3c/a9696af13b95b0c97164060127abc99896fec4 @@ -0,0 +1,134 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 95160431FAF + for ; Sun, 6 Jan 2013 06:05:23 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id xUF+PCnxewCZ for ; + Sun, 6 Jan 2013 06:05:23 -0800 (PST) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id EDC70431FAE + for ; Sun, 6 Jan 2013 06:05:22 -0800 (PST) +Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.82.78] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) + (envelope-from ) + id 1Trqql-0005X8-4a; Sun, 06 Jan 2013 10:05:19 -0400 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1Trqqf-00088k-Gt; Sun, 06 Jan 2013 10:05:13 -0400 +From: david@tethera.net +To: notmuch@notmuchmail.org +Subject: [Patch v2] notmuch-restore: handle empty input file, + leading blank lines and comments. +Date: Sun, 6 Jan 2013 10:04:56 -0400 +Message-Id: <1357481096-31254-1-git-send-email-david@tethera.net> +X-Mailer: git-send-email 1.7.10.4 +In-Reply-To: +References: +X-Spam_bar: - +Cc: David Bremner +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 06 Jan 2013 14:05:23 -0000 + +From: David Bremner + +This patch corrects several undesirable behaviours: + +1) Empty files were not detected, leading to buffer read overrun. + +2) An initial blank line cause restore to silently abort + +3) Initial comment line caused format detection to fail +--- + notmuch-restore.c | 18 +++++++++++++----- + test/dump-restore | 3 --- + 2 files changed, 13 insertions(+), 8 deletions(-) + +diff --git a/notmuch-restore.c b/notmuch-restore.c +index d43546d..f436989 100644 +--- a/notmuch-restore.c ++++ b/notmuch-restore.c +@@ -181,11 +181,6 @@ notmuch_restore_command (unused (void *ctx), int argc, char *argv[]) + argv[opt_index]); + return 1; + } +- char *p; +- +- line_len = getline (&line, &line_size, input); +- if (line_len == 0) +- return 0; + + tag_ops = tag_op_list_create (ctx); + if (tag_ops == NULL) { +@@ -193,6 +188,19 @@ notmuch_restore_command (unused (void *ctx), int argc, char *argv[]) + return 1; + } + ++ do { ++ line_len = getline (&line, &line_size, input); ++ ++ /* empty input file not considered an error */ ++ if (line_len < 0) ++ return 0; ++ ++ } while ((line_len == 0) || ++ (line[0] == '#') || ++ /* the cast is safe because we checked about for line_len < 0 */ ++ (strspn (line, " \t\n") == (unsigned)line_len)); ++ ++ char *p; + for (p = line; (input_format == DUMP_FORMAT_AUTO) && *p; p++) { + if (*p == '(') + input_format = DUMP_FORMAT_SUP; +diff --git a/test/dump-restore b/test/dump-restore +index c2ddb92..ae30cd1 100755 +--- a/test/dump-restore ++++ b/test/dump-restore +@@ -146,13 +146,11 @@ cat < comments-and-blanks + EOF + + test_begin_subtest 'restoring empty file is not an error' +-test_subtest_known_broken + notmuch restore < /dev/null 2>OUTPUT.$test_count + cp /dev/null EXPECTED + test_expect_equal_file EXPECTED OUTPUT.$test_count + + test_begin_subtest 'file of comments and blank lines is not an error' +-test_subtest_known_broken + notmuch restore --input=comments-and-blanks + ret_val=$? + test_expect_equal "$ret_val" "0" +@@ -172,7 +170,6 @@ echo "yun1vjwegii.fsf@aiko.keithp.com (another_tag)" \ + >> leading-comments-blanks-sup + + test_begin_subtest 'detect format=sup with leading comments and blanks' +-test_subtest_known_broken + notmuch restore --input=leading-comments-blanks-sup + notmuch search --output=tags id:yun1vjwegii.fsf@aiko.keithp.com > OUTPUT.$test_count + echo "another_tag" > EXPECTED +-- +1.7.10.4 + -- 2.26.2