From cb70f932536b31c28160e8ce88ddd69c7abbd14c Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sun, 3 Feb 2013 16:52:37 +2000 Subject: [PATCH] RE: Reply all - issue --- e4/3a51fcea9cd7760f804b12f96603471d049360 | 111 ++++++++++++++++++++++ 1 file changed, 111 insertions(+) create mode 100644 e4/3a51fcea9cd7760f804b12f96603471d049360 diff --git a/e4/3a51fcea9cd7760f804b12f96603471d049360 b/e4/3a51fcea9cd7760f804b12f96603471d049360 new file mode 100644 index 000000000..b3e898e75 --- /dev/null +++ b/e4/3a51fcea9cd7760f804b12f96603471d049360 @@ -0,0 +1,111 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 95561431FB6 + for ; Sat, 2 Feb 2013 12:52:51 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 6lADadiOXmDE for ; + Sat, 2 Feb 2013 12:52:49 -0800 (PST) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id B773D431FAE + for ; Sat, 2 Feb 2013 12:52:49 -0800 (PST) +Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.82.78] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) + (envelope-from ) + id 1U1k4p-0006yI-B7; Sat, 02 Feb 2013 16:52:46 -0400 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1U1k4j-00029G-Js; Sat, 02 Feb 2013 16:52:37 -0400 +From: David Bremner +To: Robert Mast +Subject: RE: Reply all - issue +In-Reply-To: <000001ce0161$5da40990$18ec1cb0$@nl> +References: <000001cdfcd9$82500f00$86f02d00$@nl> + + <000001ce0161$5da40990$18ec1cb0$@nl> +User-Agent: Notmuch/0.15.1 (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-pc-linux-gnu) +Date: Sat, 02 Feb 2013 16:52:37 -0400 +Message-ID: <87a9rml9pm.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 02 Feb 2013 20:52:51 -0000 + +Robert Mast writes: + +> +> Anyone interested in me patching Notmuch, or shall I keep the changes +> to myself? +> + +Hi Robert; + +If you have patches, and you want feedback on them, then you are of +course welcome to send them to the list. Previous experience suggests +us that it is often faster in the long run (in terms of actually getting +code into notmuch) to take time to work out the design issues before +starting coding. Some suggestions/comments: + +1) See http://notmuchmail.org/contributing/ for some general hints on + contributing code to notmuch. + +2) Make sure whatever threading heuristic you use is deterministic, and + robust in the face of messages arriving in different orders, and + munging of headers by mailing lists (subjects in particular get + munged fairly often). + +3) In particular, it seems important that "notmuch dump" followed by + "notmuch restore" (possibly followed by notmuch new?) yields unchanged + or equivalent thread structure + +4) Since threading heuristics are a matter of taste (i.e. not everyone + is convinced that the way Gmail does it is the way notmuch should), + you'll need to make this configurable. One constraint is that the + library itself (under ./lib) is should not read configuration files + (or environment variables, although it violates this for debugging). + This just means you will have to change the API to pass configuration + information in to certain routines. + +5) I'd say it's more important that you can shut off the heuristic + completely than have special handling for git (or other version + control system) patch series. If you do decide to add some special + handling for patch series, I'd suggest making it as generic as + possible, perhaps a configurable list of (header, regex) values that + disable the thread splitting heuristics. + +6) Decide how, if at all your design will support manually joining + threads together. I think an acceptable answer would probably be + "disable all thread splitting heuristics and rebuild the + database". I'm not sure if it's feasible to do anything nicer than + that. + +d + + + -- 2.26.2