From cb6359b4656072886572a34d9713b7570be14e25 Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Fri, 30 Mar 2012 10:37:01 +1700 Subject: [PATCH] Re: [BUG/PATCH v2] emacs: Fix the References header in reply --- a6/609cfa34551ea9ea811124f950cba8c4d47f79 | 117 ++++++++++++++++++++++ 1 file changed, 117 insertions(+) create mode 100644 a6/609cfa34551ea9ea811124f950cba8c4d47f79 diff --git a/a6/609cfa34551ea9ea811124f950cba8c4d47f79 b/a6/609cfa34551ea9ea811124f950cba8c4d47f79 new file mode 100644 index 000000000..aa1e917ef --- /dev/null +++ b/a6/609cfa34551ea9ea811124f950cba8c4d47f79 @@ -0,0 +1,117 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 48D2B431FAF + for ; Thu, 29 Mar 2012 10:37:13 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 5zsWe-9coJsv for ; + Thu, 29 Mar 2012 10:37:11 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 7C1F0431FAE + for ; Thu, 29 Mar 2012 10:37:11 -0700 (PDT) +Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by earth-doxen-postvirus (Postfix) with ESMTP id 106B866E019B; + Thu, 29 Mar 2012 10:37:09 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new +Received: from finestructure.net (DHCP-123-229.caltech.edu [131.215.123.229]) + (Authenticated sender: jrollins) + by earth-doxen-submit (Postfix) with ESMTP id 900D366E012C; + Thu, 29 Mar 2012 10:37:05 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id 5287D139; Thu, 29 Mar 2012 10:37:04 -0700 (PDT) +From: Jameson Graef Rollins +To: Adam Wolfe Gordon +Subject: Re: [BUG/PATCH v2] emacs: Fix the References header in reply +In-Reply-To: + +References: <1332991226-510-1-git-send-email-awg+notmuch@xvx.ca> + <1332996818-15700-1-git-send-email-awg+notmuch@xvx.ca> + <87aa2zjpmg.fsf@servo.finestructure.net> + +User-Agent: Notmuch/0.12+78~g127fa56 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Thu, 29 Mar 2012 10:37:01 -0700 +Message-ID: <87obrf48ci.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 29 Mar 2012 17:37:13 -0000 + +--=-=-= + +On Thu, Mar 29 2012, Adam Wolfe Gordon wrote: +> That's actually fixed by the new version [1]. As Austin mentioned in +> his review, the order of message-header-format-alist determines the +> order of the headers. +> +> [1] id:"1333038410-17927-3-git-send-email-awg+notmuch@xvx.ca" + +Awesome! Thanks so much Adam! I just tested it and it works great: +solves the issue and the headers are in a nice order. Thanks again for +the quick fix. + +I see one tiny whitespace error, but overall the rest of the patches +looks great, so I say it's not worth resubmitting. LGTM. + +>> Given the various things that are being affected by this, it would +>> probably be good to add a test for this as well. +> +> Yeah, I think a test would be good. This isn't caught by the existing +> emacs reply tests because the References and User-Agent headers are +> hidden by default. Is there a function in emacs to tell message-mode +> to show all the headers, so we can verify that they're correct? + +There must be, since I am seeing the In-Reply-To and References headers, +but I can't find what customization variable it is at the moment. It +looks like I am using message-required-headers: + +(message-required-headers ((optional . References) From) + +But looking through the plethora of message-mode options, I think there +is probably multiple ways to set this. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBCAAGBQJPdJ29AAoJEO00zqvie6q8zZsP/jF5SLMwSgEKUaz2V0y/jcD2 +6O/H71Fb2YSj5ArZppV5Y8CU2V/k5PSJwihxtlaRP8owy82t1AXhVhVQ6qzeZAXV +zP65NHF3770+HNXLxO/mgdmxN6hy9ZEASo97fLbpD1uq8CFdnLJ10aG0nAP+MOIk +z42XcK+iQOlEtkQOHpz0yw/ckyfu/v5I5EM4xYDNbpBt/Xx6M5Fmx6dWgy5Qh8Gq +tM0CN2Fu8MJXUp7Qrdf7Ph/CvaqGCFBrPEw7WVBTgqZtcAgRYvpYv8N2yhV/knh+ +UkyQAXNJWZJQ5pqwVxqHKdJ+TYN8xOUFeIqlIVgYSf3uPVQHotwnBo8iCpub/iBp +tCuqbd6epS5W2IpDys0OXgtPHgY+SBcGHAfA0fPhHgF4fwVXXBfbQbGW5Cq9Uj6y +Og37H/rY400urnxY1XZlvyjaO3CMGGS9XNn6TyPGmNw89C/p+23iGcL9rY+5Nc0V +K7Oa9ItBxXg7dbEb/aZFhycj4KJT0uDX8GoCWJkAJk8EzUceHYrVZw9AJbWhNbZt +ukQ09D0S1CPGONia2jmnbnJiHc9BiY9fBkqnav94QUa1wEQx5rTRNDnCt12h142e +F80N9YaDoDbuIyosuHpyBlmwHX5DKCMYtHiXEsKTfsmbj+7jGfreXoEn24YjgENZ +x4qYps8u5/4zvdNqVpTu +=ta7Y +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2