From cac4926519a523b2dec7ae061d705a92a3994ff6 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Fri, 29 Mar 2013 17:54:33 +0200 Subject: [PATCH] Re: [PATCH] emacs: introduce notmuch-command-to-string, replace use of shell-command-to-string --- 3e/939cca68b45050ac74fb623796ca612abdff33 | 76 +++++++++++++++++++++++ 1 file changed, 76 insertions(+) create mode 100644 3e/939cca68b45050ac74fb623796ca612abdff33 diff --git a/3e/939cca68b45050ac74fb623796ca612abdff33 b/3e/939cca68b45050ac74fb623796ca612abdff33 new file mode 100644 index 000000000..9667d6f4d --- /dev/null +++ b/3e/939cca68b45050ac74fb623796ca612abdff33 @@ -0,0 +1,76 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 8003A431FBC + for ; Fri, 29 Mar 2013 08:54:36 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id gXbm3fTOwRqV for ; + Fri, 29 Mar 2013 08:54:35 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id C4FC4431FAF + for ; Fri, 29 Mar 2013 08:54:35 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 78F85100033; + Fri, 29 Mar 2013 17:54:33 +0200 (EET) +From: Tomi Ollila +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: introduce notmuch-command-to-string, + replace use of shell-command-to-string +In-Reply-To: <87vc8ai6gt.fsf@maritornes.cs.unb.ca> +References: <874nguxbvq.fsf@tu-dortmund.de> + <1362747878-3571-1-git-send-email-david@tethera.net> + <87vc8ai6gt.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.15.2+50~g43fdda5 (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 29 Mar 2013 15:54:36 -0000 + +On Fri, Mar 29 2013, David Bremner wrote: + +> david@tethera.net writes: +> +>> From: David Bremner +>> +>> This has two benefits: unified error handling, and avoiding tramp's +>> hooking into shell-command-string. +>> +>> This seems to be a fix for id:874nguxbvq.fsf@tu-dortmund.de +>> --- +>> +>> Simon: can you check if this fixes your bug? +> +> Anyone willing to sanity check my e-lisp? + +LGTM. The implementation is quite much the same as in +notmuch-call-notmuch-process, just that this function returns +the output as a string. + +> d + +Tomi -- 2.26.2