From ca2bcc6970ea48fd963c2f5fede29889188cc3d3 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Tue, 10 Jul 2012 17:51:48 +0100 Subject: [PATCH] Tests --- 40/0ed5d1d45990390806240aa4a74b8196a52a8a | 108 ++++++++++++++++++++++ 1 file changed, 108 insertions(+) create mode 100644 40/0ed5d1d45990390806240aa4a74b8196a52a8a diff --git a/40/0ed5d1d45990390806240aa4a74b8196a52a8a b/40/0ed5d1d45990390806240aa4a74b8196a52a8a new file mode 100644 index 000000000..0bd9b35a2 --- /dev/null +++ b/40/0ed5d1d45990390806240aa4a74b8196a52a8a @@ -0,0 +1,108 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 14A8B431E64 + for ; Tue, 10 Jul 2012 09:52:00 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id eOHKvs+xtCL0 for ; + Tue, 10 Jul 2012 09:51:59 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 51F03431FBF + for ; Tue, 10 Jul 2012 09:51:59 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1SodfD-0000gT-9s; Tue, 10 Jul 2012 17:51:53 +0100 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1SodfC-0004Ge-VE; Tue, 10 Jul 2012 17:51:51 +0100 +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: Tests +User-Agent: Notmuch/0.13.2+61~gf708609 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Tue, 10 Jul 2012 17:51:48 +0100 +Message-ID: <87ipdv8spn.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: e3e0620cb7299d73782119c568913a7e (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 10 Jul 2012 16:52:00 -0000 + + +I have been thinking a little bit about the current situation with +regards to tests. There are quite a lot of tests in the review queue +that have been there for quite some time without much interest, but I do +think we are rather short of tests. (*) + +I wonder if we could have a sort of staging area for tests where they +could roughly go in without review and would only be run by something +like make stage-test or make all-tests or something. The hope is that +this would encourage more tests. + +The idea would be not that a patch author would have to make sure they +all pass, but if they previously passed and no longer do then the author +would know *something* about the output had changed. + +One example is the emacs elide test by Pieter +id:"1329684990-12504-3-git-send-email-pieter@praet.org" which does still +pass after my substantial change to the way elide is done (and is not +currently covered in the test suite) + +Of course if someone does review one of these staging tests then they +can be moved into the real tests. + +Best wishes + +Mark + +(*) for example the structured output patch accidentally changed the +output of notmuch search --output=threads --format=json but +that was not caught by the tests. + + + + + -- 2.26.2