From c993bb62f5809544bf3039d3e69528ce0b4ba3c8 Mon Sep 17 00:00:00 2001
From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Thu, 7 Mar 2013 16:38:52 +0200
Subject: [PATCH] Re: [PATCH v2 4/6] cli: config: make notmuch_config_open()
 "is new" parameter input only

---
 83/2681949454dfdde37a24bf871e4ea67de50ae4 | 74 +++++++++++++++++++++++
 1 file changed, 74 insertions(+)
 create mode 100644 83/2681949454dfdde37a24bf871e4ea67de50ae4

diff --git a/83/2681949454dfdde37a24bf871e4ea67de50ae4 b/83/2681949454dfdde37a24bf871e4ea67de50ae4
new file mode 100644
index 000000000..ea398363f
--- /dev/null
+++ b/83/2681949454dfdde37a24bf871e4ea67de50ae4
@@ -0,0 +1,74 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 1D635431FAF
+	for <notmuch@notmuchmail.org>; Thu,  7 Mar 2013 06:39:05 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id BtJJ2id0woBB for <notmuch@notmuchmail.org>;
+	Thu,  7 Mar 2013 06:39:04 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id 12F24431FAE
+	for <notmuch@notmuchmail.org>; Thu,  7 Mar 2013 06:39:04 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 1AA57100051;
+	Thu,  7 Mar 2013 16:38:53 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>,
+	notmuch@notmuchmail.org
+Subject: Re: [PATCH v2 4/6] cli: config: make notmuch_config_open() "is new"
+	parameter input only
+In-Reply-To: <87boavxr1u.fsf@zancas.localnet>
+References: <cover.1362347362.git.jani@nikula.org>
+	<5faebfc5d36d7e85a4dd1acbca0417d8a6a2602d.1362347362.git.jani@nikula.org>
+	<87boavxr1u.fsf@zancas.localnet>
+User-Agent: Notmuch/0.15.2+50~g43fdda5 (http://notmuchmail.org) Emacs/24.2.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Thu, 07 Mar 2013 16:38:52 +0200
+Message-ID: <m26213nukj.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Thu, 07 Mar 2013 14:39:05 -0000
+
+On Thu, Mar 07 2013, David Bremner <david@tethera.net> wrote:
+
+> Jani Nikula <jani@nikula.org> writes:
+>
+>> We now have a notmuch_config_is_new() function to query whether a
+>> config was created or not. Change the notmuch_config_open() is_new
+>> parameter into boolean create_new to determine whether the function
+>> should create a new config if one doesn't exist. This reduces the
+>> complexity of the API.
+>
+> I have pushed the first 4 patches in this series. I'd like a second
+> (third?) pair of eyes on 5/6.
+
+The changes in 5/6 (and 6/6 & manpage) LGTM. Using config for the context
+is good. The reply context of this mail has been produced by notmuch
+with these patches applied.
+
+> d
+
+Tomi
-- 
2.26.2