From c54a805adcf4ba0e378e00d3dcb940263572c4e0 Mon Sep 17 00:00:00 2001 From: Daniel Kahn Gillmor Date: Fri, 9 Mar 2012 15:30:21 +1900 Subject: [PATCH] Re: Parsing regression with gmime-2.6? --- a1/28ad05bb0961026b51093ca7ab8e5e57b76279 | 111 ++++++++++++++++++++++ 1 file changed, 111 insertions(+) create mode 100644 a1/28ad05bb0961026b51093ca7ab8e5e57b76279 diff --git a/a1/28ad05bb0961026b51093ca7ab8e5e57b76279 b/a1/28ad05bb0961026b51093ca7ab8e5e57b76279 new file mode 100644 index 000000000..b9bf77222 --- /dev/null +++ b/a1/28ad05bb0961026b51093ca7ab8e5e57b76279 @@ -0,0 +1,111 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A47E7431FB6 + for ; Thu, 8 Mar 2012 12:30:34 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id WI-FRjk9z51k for ; + Thu, 8 Mar 2012 12:30:33 -0800 (PST) +Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108]) + by olra.theworths.org (Postfix) with ESMTP id 60EBA431FAE + for ; Thu, 8 Mar 2012 12:30:33 -0800 (PST) +Received: from pip.fifthhorseman.net (lair.fifthhorseman.net [108.58.6.98]) + by che.mayfirst.org (Postfix) with ESMTPSA id E8C7FF970; + Thu, 8 Mar 2012 15:30:25 -0500 (EST) +Received: by pip.fifthhorseman.net (Postfix, from userid 1000) + id 97516156D9; Thu, 8 Mar 2012 15:30:26 -0500 (EST) +From: Daniel Kahn Gillmor +To: David Bremner , Austin Clements , + notmuch@notmuchmail.org +Subject: Re: Parsing regression with gmime-2.6? +In-Reply-To: <87wr6xmlml.fsf@zancas.localnet> +References: <87d38w2e7h.fsf@zancas.localnet> + <1331058417-13776-1-git-send-email-amdragon@mit.edu> + <87wr6xmlml.fsf@zancas.localnet> +User-Agent: Notmuch/0.11.1 (http://notmuchmail.org) Emacs/23.3.1 + (i486-pc-linux-gnu) +Date: Thu, 08 Mar 2012 15:30:21 -0500 +Message-ID: <87vcme3kf6.fsf@pip.fifthhorseman.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha512; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 08 Mar 2012 20:30:34 -0000 + +--=-=-= +Content-Type: text/plain +Content-Transfer-Encoding: quoted-printable + +On Tue, 06 Mar 2012 18:04:50 -0400, David Bremner wrote: +> There seems to be something weird going on with gmime-2.6; maybe we +> didn't catch some api change?=20 + +This does seem to be a regression in gmime 2.6. I've reported the bug +upstream, along with a simplified (non-notmuch) demonstration: + + https://bugzilla.gnome.org/show_bug.cgi?id=3D671680 + +We'll see what gmime's upstream has to say about it. + +As a devil's advocate, i could argue that a message in a maildir that +starts with a "From " line isn't a proper e-mail message in the first +place, and therefore gmime 2.6 is being more rigorously correct about +what it accepts. In particular, if a user were to place a multi-message +mbox file in their notmuch message store, i think that notmuch linked +against 2.4 would happily index only the first message of it, and the +rest of the message would be "hidden", whereas gmime 2.6 allows us to +detect these failures and avoid indexing them directly. + +That said, i understand that this is probably not an entirely rare +situation, and i lean toward the idea that gmime 2.4's behavior was +actually the Right Thing. Also, I haven't been able to find any +explicit documentation to indicate that the behavior change was +a deliberate one. + +I'm happy to relay any helpful or constructive suggestions to the gmime +upstream ticket, if folks don't want to deal with bugzilla directly. + + --dkg + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQJ8BAEBCgBmBQJPWRbdXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w +ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQwRUU1QkU5NzkyODJEODBCOUY3NTQwRjFD +Q0QyRUQ5NEQyMTczOUU5AAoJEMzS7ZTSFznpSmcP/RvqbMboTmrSousjGn7ZSpoK +bGx5D197pb+YXWgWZUViCBQ5aHKlXAPBeMoCwmpTo5elSBoB861wUqnHHNkaIpY9 +aGkoMWVjtz53C24Ndoh6WBoLUAKD4aSZp4gxs/jOvtq7d2oUCsc9whDIryfJFqTi +MtWyMb+8dHPTJqTHCvB2OBf/HzjFzdcmU6+nXGrWhW/1Pv1VUwrXDk650hJ9ASQu +0awqP/FE2YRqd8WGilJiZRtAQs1yDgghRx3fgjexxB0n54g+o3eMJyCwzceOG9A6 +bOXjExa/bV98LozJzsAfOXNoDMicvmGct3N5WBfln+jtZAV6tcPuQxcsaCqmri9H +I6FyiCxxJ4QCV0PzNigxaR7ohCdlEQtWpxjIlKg201kM5XHp7cId+BbiRRiNyeCU +44qmtiqs8wjX8jEip8e1/K8Y5V5Wjj0BV8rCTEjyl7+06QafyP31E9PxThsqs3YV +PXNBxSnBdYnFKy+MI+CBy1n0KuMut8ligiW6QJxWPnj2192BQuk/giaa1lUOceYk +jlA0QM0SZ+kURmof/rxlO36Ryg5hCzLthGjZATiEQAh08/S0sosUXFrWM1aXmFWX +erUPOS1bJQNvJPJzyxoxPLo4uBTQk4fBUqvc20iqZL4zgVZWaoKrh++s70EDCW1C +oo6KRdw4OZQFkiATj2Wc +=UMFt +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2