From c380f75fcd14640cb6a5454560b865b0a4470970 Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Fri, 9 Mar 2012 10:27:21 +1600 Subject: [PATCH] Re: Parsing regression with gmime-2.6? --- be/b4b6f1b348456dfdb41572b4c4418c5a9d75a2 | 116 ++++++++++++++++++++++ 1 file changed, 116 insertions(+) create mode 100644 be/b4b6f1b348456dfdb41572b4c4418c5a9d75a2 diff --git a/be/b4b6f1b348456dfdb41572b4c4418c5a9d75a2 b/be/b4b6f1b348456dfdb41572b4c4418c5a9d75a2 new file mode 100644 index 000000000..f12196bc4 --- /dev/null +++ b/be/b4b6f1b348456dfdb41572b4c4418c5a9d75a2 @@ -0,0 +1,116 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 96915431FBC + for ; Thu, 8 Mar 2012 10:27:38 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id sbowF7vPQOpC for ; + Thu, 8 Mar 2012 10:27:34 -0800 (PST) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id C8628431FB6 + for ; Thu, 8 Mar 2012 10:27:34 -0800 (PST) +Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by earth-doxen-postvirus (Postfix) with ESMTP id 2FA0566E021A; + Thu, 8 Mar 2012 10:27:34 -0800 (PST) +X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new +Received: from finestructure.net (DHCP-123-180.caltech.edu [131.215.123.180]) + (Authenticated sender: jrollins) + by earth-doxen-submit (Postfix) with ESMTP id D7B5066E01E2; + Thu, 8 Mar 2012 10:27:24 -0800 (PST) +Received: by finestructure.net (Postfix, from userid 1000) + id 41FC69DE; Thu, 8 Mar 2012 10:27:24 -0800 (PST) +From: Jameson Graef Rollins +To: David Bremner , Austin Clements , + notmuch@notmuchmail.org +Subject: Re: Parsing regression with gmime-2.6? +In-Reply-To: <87wr6xmlml.fsf@zancas.localnet> +References: <87d38w2e7h.fsf@zancas.localnet> + <1331058417-13776-1-git-send-email-amdragon@mit.edu> + <87wr6xmlml.fsf@zancas.localnet> +User-Agent: Notmuch/0.11.1+264~gb8fb66b (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Thu, 08 Mar 2012 10:27:21 -0800 +Message-ID: <87fwdj6j92.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +Cc: Daniel Kahn Gillmor +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 08 Mar 2012 18:27:38 -0000 + +--=-=-= +Content-Transfer-Encoding: quoted-printable + +On Tue, 06 Mar 2012 18:04:50 -0400, David Bremner wrote: +> There seems to be something weird going on with gmime-2.6; maybe we +> didn't catch some api change?=20 +>=20 +> I noticed a surprising number of messages failing to parse, so I wrote a +> script to take a random sample of 1000 messages and run notmuch show on +> them. A shocking 650 to 700 of them fail to parse with gmime-2.6. No +> failures are reported with gmime-2.4. + +This *is* shockingly high, and very confusing. Somehow all of the tests +pass? That's very strange, particularly since there are enough real +messages used in the tests that we should experience at least one of +these failures, right? Is there really nothing special about the +messages that are failing to parse? Your later patches seem to indicate +that this has something to do with mbox, although you don't mention that +hear. + +I thought I had been using gmime-2.6 for the last month, so I was very +skeptical of this issue. Unfortunately I just found a bug in the +configure script [0] that meant I had actually been using gmime-2.4. +However, since fixing things and actually using gmime-2.6 now, I still +don't see any problems. + +If the problem is specific to mbox, which we explicitly don't support, I +don't think this is tragic enough to warrant removing gmime-2.6 as a +dependency satisfier for 0.12 in Debian. In an event, a more explicit +description of the problem you're seeing would be helpful. + +jamie. + +[0] id:"1331225101-24385-1-git-send-email-jrollins@finestructure.net" + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.11 (GNU/Linux) + +iQIcBAEBCAAGBQJPWPoKAAoJEO00zqvie6q8pVgP/17SDeP2jDMIhsJjR5y46Zj5 +69FWm0xq2olcXaQfDzLmEOcYZ6gfIvSDeySlZxLi6Q6NKrrNqVo/uphCVWgsHTeB +7UuuZcKP3BEyhk6lNAdQxp4t6ctU7Wu1JyZEOkzFgeoFqkBo8njYyAFO944/ooh0 +oYM3vGsP4S2bH5u/XV6t03WDgkFWLX4phO2pR0GmDkbSDjYcy7t4h0ELA+4ayvbE +4RY8w/mugHl6qqbq6KlSUkdksokYVXGqSUc0T6IlWz4iaSMZNpF9TYiZ6z9bQod1 +Z5cKzkCzAa79Q/Dt1DNy//DgSh1FJNZSMGYLctnK8stznaW+3Eyt5dZaffdwLBxq +95FLc/IJvtzWW3azeLHQ+/Tt0ee5Tr1WbpLsfGd/i5QQvvTgVk1qA4JFL3pqqEDz +lYKjQdozMu/N8U+nf7kX7XNDWz9mLP5eSqIQKXi1Y/6EVIMmp6JQQYyIB9QS0gG8 +dN4nwWwWkP29DfdiTI1ZZlF59cqio2SF5RGLCF256WML144OqqrpwtlHC4mW0Hua +dBB19CCCBbFwuoAAokSTDGtRquz3ZGOWHIca811YUAyufzA7IRQvBoyc2f+T8zZl +ogIXsRYwnIFxT7/ETAwYDBTL0VxAHdGErEzSK9gr5v1yfAV3uyDhPN0UDBk0MTHc +q6+B43JtgnIrbSdRO0Xp +=WDWa +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2