From c0fbf609dac76173f7ab516867c0d998a2a0ba3e Mon Sep 17 00:00:00 2001 From: Dmitry Kurochkin Date: Fri, 25 May 2012 18:15:57 +0400 Subject: [PATCH] Re: FreeBSD Support Patches --- 29/5a10ee5025995fbb183ebe7a5446d233715b76 | 99 +++++++++++++++++++++++ 1 file changed, 99 insertions(+) create mode 100644 29/5a10ee5025995fbb183ebe7a5446d233715b76 diff --git a/29/5a10ee5025995fbb183ebe7a5446d233715b76 b/29/5a10ee5025995fbb183ebe7a5446d233715b76 new file mode 100644 index 000000000..c50f65cee --- /dev/null +++ b/29/5a10ee5025995fbb183ebe7a5446d233715b76 @@ -0,0 +1,99 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 15F66431FC0 + for ; Fri, 25 May 2012 07:18:09 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id XTKTgQNQceer for ; + Fri, 25 May 2012 07:18:08 -0700 (PDT) +Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com + [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 5A9FE431FBC + for ; Fri, 25 May 2012 07:18:08 -0700 (PDT) +Received: by lbbgk8 with SMTP id gk8so757778lbb.26 + for ; Fri, 25 May 2012 07:18:06 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=DRWLTtxwkku/9CGNCvyD8O5jsUfomRcHrsd3H8V5+m4=; + b=wUroBQ/hmZvMK4lavjgqGMBPpo6PjqxSKsC6ZD80nt4tLUAkKz0KbGwTUZ8qmI7pws + jbnLhY0yvEhdhxWGlxkxnKT5BA8by+NpAjITDzLWb48Q4VLdg6RPIUOR/fe+kozMSkuf + BIw/pJEe+ijM7pC8Yo5b+0asUwl6wrof1MNyLlJ8n6h88tFedUQcEDeOEnVmxeT5eUin + ANhViUadWopYLA8AlTcijATjNa2uPTxXW15J/PhXOYVdQCRJNhPPYK62gKZjbh2MzpB9 + HCyh2zCo2wrWIYL75mmiYoe9gHxoiH7+u9NKw7zBVm7JnPrWKgxAaONYKEPr3X55t9FA + bRDQ== +Received: by 10.112.99.98 with SMTP id ep2mr1680241lbb.45.1337955486641; + Fri, 25 May 2012 07:18:06 -0700 (PDT) +Received: from localhost (dyn-79-4.fttbee.kis.ru. [92.242.79.4]) + by mx.google.com with ESMTPS id j5sm3212985lbg.1.2012.05.25.07.18.04 + (version=TLSv1/SSLv3 cipher=OTHER); + Fri, 25 May 2012 07:18:05 -0700 (PDT) +From: Dmitry Kurochkin +To: Mike Kelly , notmuch@notmuchmail.org +Subject: Re: FreeBSD Support Patches +In-Reply-To: <1337953411-21000-1-git-send-email-pioto@pioto.org> +References: <1337953411-21000-1-git-send-email-pioto@pioto.org> +User-Agent: Notmuch/0.13+30~g6d44c5a (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Fri, 25 May 2012 18:15:57 +0400 +Message-ID: <87ipfktkgy.fsf@gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 25 May 2012 14:18:09 -0000 + +Hi Mike. + +Mike Kelly writes: + +> Hi, +> +> These patches add some changes necessary for a clean build on FreeBSD, +> and for most of the tests to pass. +> +> Also mixed in are a few patches to disable emacs tests when you don't +> have emacs, along with tests that depend upon emacs. I could split those +> off onto a separate branch if required. +> + +Why do we need to explicitly declare Emacs dependency for tests? There +should be no need for it. We have "implicit" dependencies which are +declared once (see test_declare_external_prereq calls at the end of +test-lib.sh) and are automatically handled when a test tries to use a +missing binary. Explicit dependencies are hard to maintain (e.g. your +patch adds explicit emacs dependency for crypto test but misses gpg). +With rare exceptions we should not use explicit dependencies. + +Regards, + Dmitry + +> You can find the latest version of these patches on my github repo's +> fbsd-support branch: +> +> https://github.com/pioto/notmuch/compare/master...fbsd-support +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2