From c0d3f58fb94515e1cd20bed320b5cb2330cb1e3b Mon Sep 17 00:00:00 2001 From: Adam Wolfe Gordon Date: Sun, 11 Mar 2012 11:19:40 +1700 Subject: [PATCH] Re: [PATCH v6] emacs: Use the new JSON reply format and message-cite-original --- 8f/b6fdd403afa0d9d93ebfb09665697907656895 | 94 +++++++++++++++++++++++ 1 file changed, 94 insertions(+) create mode 100644 8f/b6fdd403afa0d9d93ebfb09665697907656895 diff --git a/8f/b6fdd403afa0d9d93ebfb09665697907656895 b/8f/b6fdd403afa0d9d93ebfb09665697907656895 new file mode 100644 index 000000000..f303c8f7a --- /dev/null +++ b/8f/b6fdd403afa0d9d93ebfb09665697907656895 @@ -0,0 +1,94 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 97AAE431FAE + for ; Sat, 10 Mar 2012 10:19:46 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id PUobdDdqXwL9 for ; + Sat, 10 Mar 2012 10:19:44 -0800 (PST) +Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 2A3C6431FBC + for ; Sat, 10 Mar 2012 10:19:44 -0800 (PST) +Received: by lahc1 with SMTP id c1so2768269lah.26 + for ; Sat, 10 Mar 2012 10:19:41 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=mime-version:sender:x-originating-ip:in-reply-to:references:date + :x-google-sender-auth:message-id:subject:from:to:cc:content-type + :content-transfer-encoding:x-gm-message-state; + bh=Qg8kuqz0QUAlipLaepc2N1vOeMRdYNJzHWfRgTLF1dw=; + b=ggO+j1c2RSwnjK1QJO0ZGESlDYz49gnh76eDjPINRem5O9iZx2NYdUQl9gd7AqGrkr + 7cFlfy9kKgKG8S5kSWG7j5K/IZLgvVz5hv/MEbQrj3/LWGwpjkTP6GGRNDbVizVDbskV + F2R/k8s+EUIZfj9EOQm8toGnAmID0b/jtXvvQ3HScAG49ezAzHpuYqWwv3NuqUCgyIod + UQhXnB1TKN8PtNDCSvoN0sd2Ci5DsIcUI6AvdAXLeysD/z0A38+ZWnO5XwkM1DgzMw/6 + CKFbMdFMtzlzbkahxWKuk74qsEhnAbsfxIPwqk43kGcGNXT84tFw5uwsV6gzhnXXciKt + MHjg== +MIME-Version: 1.0 +Received: by 10.152.113.136 with SMTP id iy8mr4708422lab.50.1331403581001; + Sat, 10 Mar 2012 10:19:41 -0800 (PST) +Sender: awg@xvx.ca +Received: by 10.112.109.234 with HTTP; Sat, 10 Mar 2012 10:19:40 -0800 (PST) +X-Originating-IP: [96.52.216.56] +In-Reply-To: <87aa3p8j1x.fsf@nikula.org> +References: <1329893199-21630-1-git-send-email-awg+notmuch@xvx.ca> + <1329893199-21630-11-git-send-email-awg+notmuch@xvx.ca> + <87aa3p8j1x.fsf@nikula.org> +Date: Sat, 10 Mar 2012 11:19:40 -0700 +X-Google-Sender-Auth: BfrQ8ryVS_w1baYUzoJTAKEyGtU +Message-ID: + +Subject: Re: [PATCH v6] emacs: Use the new JSON reply format and + message-cite-original +From: Adam Wolfe Gordon +To: Jani Nikula +Content-Type: text/plain; charset=ISO-8859-1 +Content-Transfer-Encoding: quoted-printable +X-Gm-Message-State: + ALoCoQkw6yW59NERQkGTJ6V6l615xEu0aUAL836vziAiXnGY34Z7vywzx39iYUw/nmGCYaIngfz6 +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 10 Mar 2012 18:19:46 -0000 + +On Fri, Mar 9, 2012 at 16:13, Jani Nikula wrote: +>> + =A0 =A0 (set-mark (point)) +>> + =A0 =A0 (goto-char start) +>> + =A0 =A0 ;; Quote the original message according to the user's configur= +ed style. +>> + =A0 =A0 (message-cite-original) +>> + =A0 =A0 (goto-char (point-max))))) +>> + +>> + =A0(push-mark) +>> =A0 =A0(message-goto-body) +>> - =A0;; Original message may contain (malicious) MML tags. =A0We must +>> - =A0;; properly quote them in the reply. =A0Note that using `point-max' +>> - =A0;; instead of `mark' here is wrong. =A0The buffer may include user'= +s +>> - =A0;; signature which should not be MML-quoted. +>> - =A0(mml-quote-region (point) (mark))) +> +> Is it okay to drop mml quoting? Why? + +As Austin pointed out on an earlier version, message-cite-original +already does the quoting, so doing it ourselves will result in +double-quoting MML tags. -- 2.26.2