From c06b34917e8325dc5bd7776ad51826f7ee35b712 Mon Sep 17 00:00:00 2001 From: Michal Sojka Date: Tue, 4 Sep 2012 19:11:19 +0200 Subject: [PATCH] Re: [PATCH v2 0/5] emacs: notmuch-hello status message refresh hook, etc --- b4/a2a4622f84cd58176aeb8623dd2af9d2adbafe | 85 +++++++++++++++++++++++ 1 file changed, 85 insertions(+) create mode 100644 b4/a2a4622f84cd58176aeb8623dd2af9d2adbafe diff --git a/b4/a2a4622f84cd58176aeb8623dd2af9d2adbafe b/b4/a2a4622f84cd58176aeb8623dd2af9d2adbafe new file mode 100644 index 000000000..a6296fd51 --- /dev/null +++ b/b4/a2a4622f84cd58176aeb8623dd2af9d2adbafe @@ -0,0 +1,85 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 15D63431FB6 + for ; Tue, 4 Sep 2012 10:11:30 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id FCX0jcpEL21z for ; + Tue, 4 Sep 2012 10:11:29 -0700 (PDT) +Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36]) + by olra.theworths.org (Postfix) with ESMTP id 66867431FAF + for ; Tue, 4 Sep 2012 10:11:29 -0700 (PDT) +Received: from localhost (unknown [192.168.200.4]) + by max.feld.cvut.cz (Postfix) with ESMTP id 0E6AB19F3336; + Tue, 4 Sep 2012 19:11:24 +0200 (CEST) +X-Virus-Scanned: IMAP AMAVIS +Received: from max.feld.cvut.cz ([192.168.200.1]) + by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new, + port 10044) + with ESMTP id sBmtimYdd3dp; Tue, 4 Sep 2012 19:11:19 +0200 (CEST) +Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34]) + by max.feld.cvut.cz (Postfix) with ESMTP id 4C64E19F3333; + Tue, 4 Sep 2012 19:11:19 +0200 (CEST) +Received: from steelpick.2x.cz (note-sojka.felk.cvut.cz [147.32.86.30]) + (Authenticated sender: sojkam1) + by imap.feld.cvut.cz (Postfix) with ESMTPSA id 37E77660904; + Tue, 4 Sep 2012 19:11:19 +0200 (CEST) +Received: from wsh by steelpick.2x.cz with local (Exim 4.80) + (envelope-from ) + id 1T8wel-00024x-2r; Tue, 04 Sep 2012 19:11:19 +0200 +From: Michal Sojka +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 0/5] emacs: notmuch-hello status message refresh hook, + etc +In-Reply-To: +References: +User-Agent: Notmuch/0.14+3~g608c52f (http://notmuchmail.org) Emacs/24.1.1 + (x86_64-pc-linux-gnu) +Date: Tue, 04 Sep 2012 19:11:19 +0200 +Message-ID: <87vcftbtmw.fsf@steelpick.2x.cz> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 04 Sep 2012 17:11:30 -0000 + +On Sun, Sep 02 2012, Jani Nikula wrote: +> Hi all, v2 of [1] addressing review comments: added NEWS, improved +> documentation, made the query customizable. +> +> [1] +> id:"37899e28dbf67e4620a53279a869be3174c02d6f.1339775602.git.jani@nikula.org" + +Hello Jani, + +if I understand correctly, the goal of this patchset is to display the +message with the difference in the number of messages before and after +refresh of notmuch-hello. + +I think the current implementation is unnecessarily complicated. It +would be sufficient to implement this directly in `notmuch-hello' +without any hook. If `notmuch-hello-refresh-status-query' is nil +(default) no message would be shown. If it is configured to something +else, the message would be shown provided that no-display is nil. This +way you don't have to break existing user's hooks and achieve the same +behavior, don't you? + +-Michal -- 2.26.2