From bfc85f1fd15741041f2386ebcca256c5d6b464c5 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sun, 31 Mar 2013 11:50:19 +0300 Subject: [PATCH] Re: [PATCH v2 0/3] cli: clean up gmime 2.4 vs. 2.6 conditional build --- da/45691030f753072eb592168aa941ecab7a3246 | 114 ++++++++++++++++++++++ 1 file changed, 114 insertions(+) create mode 100644 da/45691030f753072eb592168aa941ecab7a3246 diff --git a/da/45691030f753072eb592168aa941ecab7a3246 b/da/45691030f753072eb592168aa941ecab7a3246 new file mode 100644 index 000000000..5af74e3dc --- /dev/null +++ b/da/45691030f753072eb592168aa941ecab7a3246 @@ -0,0 +1,114 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 0D4B9431FBF + for ; Sun, 31 Mar 2013 01:50:22 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 54SC6uTMeSx1 for ; + Sun, 31 Mar 2013 01:50:20 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 91740431FAE + for ; Sun, 31 Mar 2013 01:50:20 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 7542F100148; + Sun, 31 Mar 2013 11:50:19 +0300 (EEST) +From: Tomi Ollila +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 0/3] cli: clean up gmime 2.4 vs. 2.6 conditional build +In-Reply-To: +References: +User-Agent: Notmuch/0.15.2+50~g43fdda5 (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 31 Mar 2013 08:50:22 -0000 + +On Sat, Mar 30 2013, Jani Nikula wrote: + +> This is v2 of [1]. Added comments per David's request, and while at it, +> added a third patch to conform the existing conditional build in notmuch +> show to the same style. The whole series should have no functional +> changes, and thus v2 should have no functional changes since v1. ;) +> +> I have not tested this on gmime 2.4. + +I have gmime 2.4(.24) on this system. The code compiles and +exactly the same set of tests pass/fail as without this patch +(unfortunately this system cannot cope with just some of the +crypto patches, so I cannot give absolute guarantee: + +crypto: Testing PGP/MIME signature verification and decryption + PASS emacs delivery of signed message + PASS signature verification + PASS signature verification with full owner trust + PASS signature verification with signer key unavailable + PASS emacs delivery of encrypted message with attachment + FAIL decryption, --format=text + FAIL decryption, --format=json + FAIL decryption, --format=json, --part=4 + FAIL decrypt attachment (--part=5 --format=raw) + FAIL decryption failure with missing key + PASS emacs delivery of encrypted + signed message + FAIL decryption + signature verification + FAIL reply to encrypted message + FAIL signature verification with revoked key + +anyway, as said, exactly the same set fails without these pathes + +The reason for failure is most probably in my system and not something +w/ notmuch crypto support -- If I run `emacs foo.org.gpg` this just +hangs waiting me to give passphrase in (invisible?) curses request) + +So, bottom line: LGTM. + +> BR, +> Jani. + +Tomi + + +> [1] id:a9f12ba474fc51df71e2fd2b7a20a8d101729c6e.1362319765.git.jani@nikula.org +> +> Jani Nikula (3): +> cli: crypto: abstract gpg context creation for clarity +> cli: mime node: abstract decryption and signature verification +> cli: conform to same conditional build style as elsewhere in +> notmuch-show +> +> crypto.c | 66 ++++++++++++----- +> mime-node.c | 218 ++++++++++++++++++++++++++++++++++++-------------------- +> notmuch-show.c | 46 ++++++------ +> 3 files changed, 215 insertions(+), 115 deletions(-) +> +> -- +> 1.7.10.4 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2