From bda90dd386e4466298501405ca2de83c59c0d668 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Fri, 10 Aug 2012 10:13:46 +2000 Subject: [PATCH] Re: [PATCH] emacs: Fix "not defined at runtime" warning --- 8a/296db0828c5e31509b062c74df05fdbb839e2d | 113 ++++++++++++++++++++++ 1 file changed, 113 insertions(+) create mode 100644 8a/296db0828c5e31509b062c74df05fdbb839e2d diff --git a/8a/296db0828c5e31509b062c74df05fdbb839e2d b/8a/296db0828c5e31509b062c74df05fdbb839e2d new file mode 100644 index 000000000..342c54aac --- /dev/null +++ b/8a/296db0828c5e31509b062c74df05fdbb839e2d @@ -0,0 +1,113 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 75454431FAF + for ; Thu, 9 Aug 2012 07:13:51 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id EMXdIqB+-vpR for ; + Thu, 9 Aug 2012 07:13:51 -0700 (PDT) +Received: from dmz-mailsec-scanner-1.mit.edu (DMZ-MAILSEC-SCANNER-1.MIT.EDU + [18.9.25.12]) + by olra.theworths.org (Postfix) with ESMTP id D34FC431FAE + for ; Thu, 9 Aug 2012 07:13:50 -0700 (PDT) +X-AuditID: 1209190c-b7f806d000006b87-a4-5023c59eb429 +Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) + by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP + id 4D.07.27527.E95C3205; Thu, 9 Aug 2012 10:13:50 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q79EDnHw025112; + Thu, 9 Aug 2012 10:13:50 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q79EDl5B023933 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Thu, 9 Aug 2012 10:13:49 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1SzTUg-0001bF-SU; Thu, 09 Aug 2012 10:13:46 -0400 +Date: Thu, 9 Aug 2012 10:13:46 -0400 +From: Austin Clements +To: Jameson Graef Rollins +Subject: Re: [PATCH] emacs: Fix "not defined at runtime" warning +Message-ID: <20120809141346.GH11179@mit.edu> +References: <1344462010-5349-1-git-send-email-amdragon@mit.edu> + <87628sa4a8.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <87628sa4a8.fsf@servo.finestructure.net> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IR4hTV1p13VDnA4NU7aYs9+7wsrt+cyezA + 5HH3NJfHs1W3mAOYorhsUlJzMstSi/TtErgylj6ZwVxwmKvi3PLfLA2MKzm6GDk5JARMJLpX + PGCBsMUkLtxbz9bFyMUhJLCPUWLHnUZ2CGc9o8TcI9+YIZwTTBINZ9cxQjhLGCU2HNrABNLP + IqAi0bh1BZjNJqAhsW3/ckYQW0TATKLnyx8wm1lAWuLb72awGmEBB4mDW5ezgti8AjoSGxc0 + s4PYQgJZElfvb2eDiAtKnJz5hAWiV0vixr+XQL0cYHOW/wN7gVPAVKJp+TawVlGgE6ac3MY2 + gVFoFpLuWUi6ZyF0L2BkXsUom5JbpZubmJlTnJqsW5ycmJeXWqRrqJebWaKXmlK6iREc1JI8 + OxjfHFQ6xCjAwajEw3tprVKAEGtiWXFl7iFGSQ4mJVFetv3KAUJ8SfkplRmJxRnxRaU5qcWH + GCU4mJVEeO/0AeV4UxIrq1KL8mFS0hwsSuK8l1Nu+gsJpCeWpGanphakFsFkZTg4lCR41x0B + ahQsSk1PrUjLzClBSDNxcIIM5wEafgmkhre4IDG3ODMdIn+KUVFKnDcLJCEAksgozYPrhSWd + V4ziQK8I8+4FqeIBJiy47ldAg5mABh8WVQIZXJKIkJJqYJR5WX36DN/x3rIVr/d/fzih7lB1 + cHvRRm4muXq33o0Lar4fyPVI2qKz5O/jWFE54Swew3Zt04ViTHxMAWGqHKHGVy9PXep+fvvk + Z2ozJKQ6nv2tb54ettNAZJvRKu8onvpwm8Nv/92oi6h6l7PWKO8uT1Sgz47Qk5L33k/9PZPR + y95/CbvCXyWW4oxEQy3mouJEAGP8D/0VAwAA +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 09 Aug 2012 14:13:51 -0000 + +Quoth Jameson Graef Rollins on Aug 09 at 12:54 am: +> On Wed, Aug 08 2012, Austin Clements wrote: +> > Previously, the Emacs byte compiler produced the warning +> > +> > the function `remove-if-not' might not be defined at runtime. +> > +> > because we only required cl at compile-time (not runtime). This fixes +> > this warning by requiring cl at runtime, ensuring that the definition +> > of remove-if-not is available. +> > --- +> > emacs/notmuch-lib.el | 2 +- +> > 1 file changed, 1 insertion(+), 1 deletion(-) +> > +> > diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el +> > index 30db58f..900235b 100644 +> > --- a/emacs/notmuch-lib.el +> > +++ b/emacs/notmuch-lib.el +> > @@ -24,7 +24,7 @@ +> > (require 'mm-view) +> > (require 'mm-decode) +> > (require 'json) +> > -(eval-when-compile (require 'cl)) +> > +(require 'cl) +> > +> > (defvar notmuch-command "notmuch" +> > "Command to run the notmuch binary.") +> +> LGTM. I think it would be good to finally just give in a require cl, so +> we can finally put to rest the long standing schizophrenia we've had in +> regards to using it, and maybe finally kill the compile warnings that +> keep popping up. + +I think we already gave in [0], we just weren't very thorough about +it. + +[0] id:"m262g864dz.fsf@wal122.wireless-pennnet.upenn.edu" -- 2.26.2