From bc713215ecf8be17af36ddd927ab20a7367347b0 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sat, 8 Sep 2012 14:29:53 +0300 Subject: [PATCH] Re: [PATCH] notmuch-show: include Bcc header in json output --- 57/6f20f93ca6576f6e6b44e078ed07ee89fd2a21 | 99 +++++++++++++++++++++++ 1 file changed, 99 insertions(+) create mode 100644 57/6f20f93ca6576f6e6b44e078ed07ee89fd2a21 diff --git a/57/6f20f93ca6576f6e6b44e078ed07ee89fd2a21 b/57/6f20f93ca6576f6e6b44e078ed07ee89fd2a21 new file mode 100644 index 000000000..b81394aff --- /dev/null +++ b/57/6f20f93ca6576f6e6b44e078ed07ee89fd2a21 @@ -0,0 +1,99 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id D61D8431FAF + for ; Sat, 8 Sep 2012 04:29:49 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 59kYCxNScpga for ; + Sat, 8 Sep 2012 04:29:48 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 14316431FAE + for ; Sat, 8 Sep 2012 04:29:48 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id B871D1000E5; + Sat, 8 Sep 2012 14:29:53 +0300 (EEST) +From: Tomi Ollila +To: Michal Nazarewicz , notmuch@notmuchmail.org +Subject: Re: [PATCH] notmuch-show: include Bcc header in json output +In-Reply-To: + +References: + +User-Agent: Notmuch/0.14+11~gd9bf007 (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 08 Sep 2012 11:29:50 -0000 + +On Thu, Sep 06 2012, Michal Nazarewicz wrote: + +> From: Michal Nazarewicz +> +> --- + +By looking the code (by applying this patch and looking more context) +it looks good to me. If the commit message provided some explanation +and use case *why* this patch is needed a casual reviewer who hasn't +desired this feature (possibly by not knowing the benefits :) could +understand the need better. + +Now that we have this bcc in json output when is it shown to the user ? + +Tomi + +> notmuch-show.c | 7 +++++++ +> 1 files changed, 7 insertions(+), 0 deletions(-) +> +> Actually, I don't understand why json does not include all the +> headers... +> +> diff --git a/notmuch-show.c b/notmuch-show.c +> index 3556293..0b7abf1 100644 +> --- a/notmuch-show.c +> +++ b/notmuch-show.c +> @@ -233,6 +233,13 @@ format_headers_json (sprinter_t *sp, GMimeMessage *message, +> sp->string (sp, recipients_string); +> } +> +> + recipients = g_mime_message_get_recipients (message, GMIME_RECIPIENT_TYPE_BCC); +> + recipients_string = internet_address_list_to_string (recipients, 0); +> + if (recipients_string) { +> + sp->map_key (sp, "Bcc"); +> + sp->string (sp, recipients_string); +> + } +> + +> if (reply) { +> sp->map_key (sp, "In-reply-to"); +> sp->string (sp, g_mime_object_get_header (GMIME_OBJECT (message), "In-reply-to")); +> -- +> 1.7.7.3 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2