From bc57a7e3823d3c34cb6addc8a0843365f9b2e449 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Thu, 13 Sep 2012 15:48:24 +0300 Subject: [PATCH] Re: [PATCH v3 2/9] parse-time-string: add a date/time parser to notmuch --- 05/2721f350b6c469ae60da96a709a0f0ecd15ddf | 102 ++++++++++++++++++++++ 1 file changed, 102 insertions(+) create mode 100644 05/2721f350b6c469ae60da96a709a0f0ecd15ddf diff --git a/05/2721f350b6c469ae60da96a709a0f0ecd15ddf b/05/2721f350b6c469ae60da96a709a0f0ecd15ddf new file mode 100644 index 000000000..241f00151 --- /dev/null +++ b/05/2721f350b6c469ae60da96a709a0f0ecd15ddf @@ -0,0 +1,102 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 0D2A2431FB6 + for ; Thu, 13 Sep 2012 05:48:19 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id QHhGANjtu+wA for ; + Thu, 13 Sep 2012 05:48:17 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id BF299431FAF + for ; Thu, 13 Sep 2012 05:48:17 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id A114510036F; + Thu, 13 Sep 2012 15:48:24 +0300 (EEST) +From: Tomi Ollila +To: Michal Nazarewicz , Jani Nikula , + notmuch@notmuchmail.org +Subject: Re: [PATCH v3 2/9] parse-time-string: add a date/time parser to + notmuch +In-Reply-To: +References: + <89741ec9a9687fca8b30aa1a4877392d355dd3ce.1347484177.git.jani@nikula.org> + +User-Agent: Notmuch/0.13.2+162~ged38330 (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 13 Sep 2012 12:48:19 -0000 + +On Thu, Sep 13 2012, Michal Nazarewicz wrote: + +> On Wed, Sep 12 2012, Jani Nikula wrote: +>> Add a date/time parser to notmuch, to be used for adding date range +>> query support for notmuch lib later on. Add the parser to a directory +>> of its own to make it independent of the rest of the notmuch code +>> base. +>> +>> Signed-off-by: Jani Nikula +> +> Have you consider doing the same in bison? I consider the code totally +> unreadable and unmaintainable. + +Well, I don't find this code 'unreadable', perhaps it depends how you +define it ;) + +This functionality has been in 'work-in-progress' for a long time. I think +the interface how this (separate library) is hooked to notmuch is sane. +Also, my 'hunch' is that this is maintainable enough (and Jani will do +all expected 'zero' maintenaince issues that will appear). If, in the +future, there is enough desire for internationalization then Someone(TM) +may see the way to do it. + +But, for the time being I applause the hard work Jani has put into=20 +this library and as it is much better what we have now (i.e. nothing) +I am going to start testing this (and drop my current wrapper which +I've been using to search using relative times)... + +It might be interesting to see this implemented in Bison but just for +the sake of it I don't think it is worth of it. Maybe, someday..., +Someone Else(tm) does that. The interface should allow to make drop-in +replacement for this parser... + +Tomi + + +> +> --=20 +> Best regards, _ _ +> .o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o +> ..o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz = + (o o) +> ooo +------------------ooO--(_)--Ooo--_______= +________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2