From ba1d305c1fe7c6f9069cf94fc2ffad1be11ac9b9 Mon Sep 17 00:00:00 2001 From: Mike Kelly Date: Sat, 26 May 2012 16:02:34 +2000 Subject: [PATCH] Re: FreeBSD Support Patches --- 12/b91cbe45839af06960264bf0a582f8c64a8b12 | 93 +++++++++++++++++++++++ 1 file changed, 93 insertions(+) create mode 100644 12/b91cbe45839af06960264bf0a582f8c64a8b12 diff --git a/12/b91cbe45839af06960264bf0a582f8c64a8b12 b/12/b91cbe45839af06960264bf0a582f8c64a8b12 new file mode 100644 index 000000000..253da6309 --- /dev/null +++ b/12/b91cbe45839af06960264bf0a582f8c64a8b12 @@ -0,0 +1,93 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 26A7B431FBC + for ; Fri, 25 May 2012 13:02:56 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id rxfCVMOAVWBb for ; + Fri, 25 May 2012 13:02:55 -0700 (PDT) +Received: from mail-vb0-f53.google.com (mail-vb0-f53.google.com + [209.85.212.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 7F923431FB6 + for ; Fri, 25 May 2012 13:02:55 -0700 (PDT) +Received: by vbbfc26 with SMTP id fc26so1455495vbb.26 + for ; Fri, 25 May 2012 13:02:54 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=mime-version:x-originating-ip:in-reply-to:references:from:date + :message-id:subject:to:cc:content-type:content-transfer-encoding + :x-gm-message-state; + bh=hMCSTE2ymEJMbTua00QYTZDGoe7DlF8HcYFy8d8wchQ=; + b=TJwvs5KnCksE6zCjnImqQxeh8MffsJvf0EKcW+QXezAwZP/eMJHyNS2g0NZYzs/Obt + j6xGA5GlNYZdB4JuIZeGhfoMgMbr5+Koz9DF0hmJgrQ57l3yJI0rv8hpEY8comQxpP4k + ZzCSuTeJOf9n1iyTROMhBrO/GavJiJCm8OJBK490X05E+qxspkyXjSYFzt55BU3B+DYJ + IKmeN5DUhc3onywsyfbhfoT11Kp82H844jHa4G1qm4BEXXGZWM+NW8SHPn0O5sma7wke + fbTDFqiBSjF/T22w651jTIHt5VOnJ/4y3NFjRH91KCOxuIb82Map8CI42zKipeOnQMVy + BYpg== +Received: by 10.52.96.135 with SMTP id ds7mr178328vdb.50.1337976174843; Fri, + 25 May 2012 13:02:54 -0700 (PDT) +MIME-Version: 1.0 +Received: by 10.220.141.83 with HTTP; Fri, 25 May 2012 13:02:34 -0700 (PDT) +X-Originating-IP: [216.92.130.84] +In-Reply-To: <87ipfktkgy.fsf@gmail.com> +References: <1337953411-21000-1-git-send-email-pioto@pioto.org> + <87ipfktkgy.fsf@gmail.com> +From: Mike Kelly +Date: Fri, 25 May 2012 16:02:34 -0400 +Message-ID: + +Subject: Re: FreeBSD Support Patches +To: Dmitry Kurochkin +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: quoted-printable +X-Gm-Message-State: + ALoCoQkfLqeALtXfSp/FpQW4Fv3jIdU8TBJCaIAPv5dK8fwS36i6exGBijSRUNHE83MYymJpdNe/ +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 25 May 2012 20:02:56 -0000 + +On Fri, May 25, 2012 at 10:15 AM, Dmitry Kurochkin + wrote: +> Why do we need to explicitly declare Emacs dependency for tests? =C2=A0Th= +ere +> should be no need for it. =C2=A0We have "implicit" dependencies which are +> declared once (see test_declare_external_prereq calls at the end of +> test-lib.sh) and are automatically handled when a test tries to use a +> missing binary. =C2=A0Explicit dependencies are hard to maintain (e.g. yo= +ur +> patch adds explicit emacs dependency for crypto test but misses gpg). +> With rare exceptions we should not use explicit dependencies. + +Because not every test actually has those implicit dependencies. For +example, some of the crypto tests depend upon emacs_deliver_message +working correctly for subsequents tests. Those emacs_deliver_message +tests are skipped, but not the ones after it that try to do something +with that injected message. + +For the emacs-* test files, there are some tests that act the same +way. However, it is also a minor speed improvement to say that, +obviously, none of the emacs tests are going to work, so just don't +bother. + +--=20 +Mike Kelly -- 2.26.2