From b5eb8144267f4f1c97d8d8b4c20c870c8b2852e0 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Wed, 14 Mar 2012 11:12:32 +0000 Subject: [PATCH] Re: [PATCH 0/2] A bug in the exclude code --- 9f/745e4ebbffaa76a3293765849230ce75a9ec1f | 113 ++++++++++++++++++++++ 1 file changed, 113 insertions(+) create mode 100644 9f/745e4ebbffaa76a3293765849230ce75a9ec1f diff --git a/9f/745e4ebbffaa76a3293765849230ce75a9ec1f b/9f/745e4ebbffaa76a3293765849230ce75a9ec1f new file mode 100644 index 000000000..298c82169 --- /dev/null +++ b/9f/745e4ebbffaa76a3293765849230ce75a9ec1f @@ -0,0 +1,113 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id C7F41431FCF + for ; Wed, 14 Mar 2012 04:12:34 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id HkbjKcee0I-W for ; + Wed, 14 Mar 2012 04:12:34 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id E4343431FAE + for ; Wed, 14 Mar 2012 04:12:33 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1S7m83-0004fW-Mq; Wed, 14 Mar 2012 11:12:28 +0000 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1S7m83-000728-8j; Wed, 14 Mar 2012 11:12:27 +0000 +From: Mark Walters +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 0/2] A bug in the exclude code +In-Reply-To: <87mx7kndd3.fsf@awakening.csail.mit.edu> +References: <1331551914-28323-1-git-send-email-markwalters1009@gmail.com> + <87mx7kndd3.fsf@awakening.csail.mit.edu> +User-Agent: Notmuch/0.11.1+299~gc586c0b (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Mux_Client_Request_Session: read from master failed: Broken pipe +Date: Wed, 14 Mar 2012 11:12:32 +0000 +Message-ID: <871uovjv1b.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 3d492a7bf2f5f568a7c8bb2f82bf86a9 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 14 Mar 2012 11:12:35 -0000 + +On Tue, 13 Mar 2012 22:08:24 -0400, Austin Clements wrote: +> On Mon, 12 Mar 2012 11:31:52 +0000, Mark Walters wrote: +> > There is a bug in the exclude code (found by jrollins in the +> > --with-excluded series) but also present in master. None of the +> > current tests were finding it so the first patch adds two tests. +> > +> > The bug (and test failure) do not appear in all configuations: on my +> > main test machine (an oldish debian testing 32bit userspace with a +> > 64bit kernel and xapian 1.2.7) all tests pass. On my laptop (a recent +> > debian testing 64bit userspace and xapian 1.2.8) one of the new tests +> > fails. +> > +> > The second patch fixes the behaviour for me but I don't see why it +> > should make a difference: searches for A and not B should give the +> > same results as A and not (A and B). It could be a bug in xapian, it +> > could be that I am not allowed to reuse queries as I do (is query1 = +> > query1 and query2 allowed?) or it could be some memory use bug on my +> > part. +> > +> > Anyway the "fix" is small which should help narrow down the actual +> > cause. +> +> LGTM. Even if we don't totally understand the root cause here, this +> change is the right thing to do anyway. +> +> I think it's fine to go ahead and push this ahead of the other exclude +> updates, though obviously those will need a little rebasing on top of +> this. + +Please don't push exactly this one: I will try and send a version with +a better commit message and a test that shows what is failing better +later today. (The functional part will be unchanged.) + +Best wishes + +Mark -- 2.26.2