From b2f6eba29601b1e2625afd5cd551dc00a3f7018f Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Thu, 10 May 2012 14:07:00 +2000 Subject: [PATCH] Re: Last minute fixes to the go bindings --- 20/a1aa408f20fa2863a0b99b6a350ada38ee4512 | 102 ++++++++++++++++++++++ 1 file changed, 102 insertions(+) create mode 100644 20/a1aa408f20fa2863a0b99b6a350ada38ee4512 diff --git a/20/a1aa408f20fa2863a0b99b6a350ada38ee4512 b/20/a1aa408f20fa2863a0b99b6a350ada38ee4512 new file mode 100644 index 000000000..2e228c45d --- /dev/null +++ b/20/a1aa408f20fa2863a0b99b6a350ada38ee4512 @@ -0,0 +1,102 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E27ED431FAF + for ; Wed, 9 May 2012 11:07:05 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id UP5X8U+VaiQh for ; + Wed, 9 May 2012 11:07:05 -0700 (PDT) +Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU + [18.9.25.13]) + by olra.theworths.org (Postfix) with ESMTP id 639F9431FAE + for ; Wed, 9 May 2012 11:07:05 -0700 (PDT) +X-AuditID: 1209190d-b7fbf6d0000008ba-be-4faab2484dc6 +Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) + by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP + id EB.FE.02234.842BAAF4; Wed, 9 May 2012 14:07:04 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q49I72eW030298; + Wed, 9 May 2012 14:07:03 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q49I71OB002180 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Wed, 9 May 2012 14:07:02 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1SSBHw-0006xR-P5; Wed, 09 May 2012 14:07:00 -0400 +Date: Wed, 9 May 2012 14:07:00 -0400 +From: Austin Clements +To: Justus Winter <4winter@informatik.uni-hamburg.de> +Subject: Re: Last minute fixes to the go bindings +Message-ID: <20120509180700.GA11804@mit.edu> +References: + <1336558988-6813-1-git-send-email-4winter@informatik.uni-hamburg.de> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: + <1336558988-6813-1-git-send-email-4winter@informatik.uni-hamburg.de> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42IR4hRV1vXYtMrfYNNNNYvZrT+YLK7fnMns + wOQx8fxpNo9nq24xBzBFcdmkpOZklqUW6dslcGX8v7WcueAOW0XHlMXsDYyzWLsYOTkkBEwk + 1v+Zyghhi0lcuLeeDcQWEtjHKLFjMVCcC8hezyix88FPFojECSaJx184IBJLGCXe7XzFDpJg + EVCRuLVkGdgkNgENiW37l4PZIgKmEhsePACrYRaQlvj2u5kJxBYWMJTYuO8T2BW8AjoSF7ZN + Z4VYECDR+mQ7M0RcUOLkzCcsEL1aEjf+vQTq5QCbs/wfB0iYUyBQ4sDjW2DlokAnTDm5jW0C + o9AsJN2zkHTPQuhewMi8ilE2JbdKNzcxM6c4NVm3ODkxLy+1SNdILzezRC81pXQTIzioJXl3 + ML47qHSIUYCDUYmH92DjKn8h1sSy4srcQ4ySHExKoryi64FCfEn5KZUZicUZ8UWlOanFhxgl + OJiVRHjvrgLK8aYkVlalFuXDpKQ5WJTEeVW13vkJCaQnlqRmp6YWpBbBZGU4OJQkeBs2AjUK + FqWmp1akZeaUIKSZODhBhvMADd8FUsNbXJCYW5yZDpE/xajLMW/K1quMQix5+XmpUuK8NSBF + AiBFGaV5cHNgyegVozjQW8K8/SBVPMBEBjfpFdASJqAl0w6vBFlSkoiQkmpgPKbafEt1wQKd + Goeyp6X32RqUj9yrulPBsZXn+ofcgIwm3ulz+LMtbFnSp6bXmfysKi7mNo2TnTjtQUrS9Cfu + R0LLp02dNFHEoL/ub6dYXcSV+fPznnq6tNye379bZfrpVzZleaezKqacs2Q42xxxsSPkaQzn + 3LlZG5251Z+nO+9+FhdsYeWrxFKckWioxVxUnAgA8+x7SCEDAAA= +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 09 May 2012 18:07:06 -0000 + +LGTM. + +Quoth Justus Winter on May 09 at 12:23 pm: +> Hi everyone :) +> +> this is a small patch series that I'd like to see included in 0.13. +> +> The first patch updates notmuch-addrlookup with respect to Austins +> recent change of the notmuch_database_open function. This fixes the +> compilation of the utility. +> +> The second patch fixes the values of all the STATUS_* constants. Turns +> out all of them were set to zero by accident. This isn't a c style +> enum, golang has the iota operator to do this kind of stuff. This +> fixes the error handling for all the users of the go bindings. + +'Doh! Is it possible to get the status values out of cgo, rather than +depending on the list in libnotmuch and the list in Go being in the +same order? + +> The third patch just brings the list of status constants up to date. +> +> Cheers, +> Justus -- 2.26.2