From b1beda7438b4668ab7b70edaaba84c77e36f1f50 Mon Sep 17 00:00:00 2001 From: Dmitry Kurochkin Date: Fri, 3 Feb 2012 04:18:09 +0400 Subject: [PATCH] Re: [PATCH 1/2] test: add check for filename argument for test_expect_equal_file --- 14/55987def490d9805851d80fd46eaef3720740a | 94 +++++++++++++++++++++++ 1 file changed, 94 insertions(+) create mode 100644 14/55987def490d9805851d80fd46eaef3720740a diff --git a/14/55987def490d9805851d80fd46eaef3720740a b/14/55987def490d9805851d80fd46eaef3720740a new file mode 100644 index 000000000..9b7333cd8 --- /dev/null +++ b/14/55987def490d9805851d80fd46eaef3720740a @@ -0,0 +1,94 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 5344B431FBD + for ; Thu, 2 Feb 2012 16:19:27 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 1.7 +X-Spam-Level: * +X-Spam-Status: No, score=1.7 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id S6CQWrfGaWNC for ; + Thu, 2 Feb 2012 16:19:26 -0800 (PST) +Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com + [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 8FDAB431FAF + for ; Thu, 2 Feb 2012 16:19:26 -0800 (PST) +Received: by bke11 with SMTP id 11so2968923bke.26 + for ; Thu, 02 Feb 2012 16:19:25 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=a7rSI/9bbAsJBRi0zzXmehXh14TPgMngJRA0gKpRE5Y=; + b=TTfvAWdBewD3Es3fm5Jc7GAaacNODIxcqY1sZwTbDRpgDjCKlYs6mEcHI46yqaQBKb + JjztniKIGMn+0E4UhAPUtWTFarjj6+3o0xl6qqfwgxkSH8UrGMLM0XyM/XKUVR6auJST + 7ubyD2kJSG2oIrRa9ybl/s7UYUOt5YA9mlkOc= +Received: by 10.204.133.201 with SMTP id g9mr2406841bkt.137.1328228364959; + Thu, 02 Feb 2012 16:19:24 -0800 (PST) +Received: from localhost ([91.144.186.21]) + by mx.google.com with ESMTPS id 20sm11666300bkr.0.2012.02.02.16.19.23 + (version=TLSv1/SSLv3 cipher=OTHER); + Thu, 02 Feb 2012 16:19:23 -0800 (PST) +From: Dmitry Kurochkin +To: Jameson Graef Rollins , + notmuch@notmuchmail.org +Subject: Re: [PATCH 1/2] test: add check for filename argument for + test_expect_equal_file +In-Reply-To: <87zkd1p12c.fsf@servo.finestructure.net> +References: <1328141050-30356-1-git-send-email-dmitry.kurochkin@gmail.com> + <1328141050-30356-2-git-send-email-dmitry.kurochkin@gmail.com> + <87zkd1p12c.fsf@servo.finestructure.net> +User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Fri, 03 Feb 2012 04:18:09 +0400 +Message-ID: <87zkd0ixby.fsf@gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 03 Feb 2012 00:19:27 -0000 + +Hi Jameson. + +On Thu, 02 Feb 2012 10:00:59 -0800, Jameson Graef Rollins wrote: +> Hey, Dmitry. I'm so sorry I sent my last email on your original patch +> before I saw this new series. + +No problems. + +> I do now like your original proposal +> better, since it shows the diff based the names the caller provides, +> which I now agree is probably the clearest and most robust solution. +> The second patch in this series could still go through, though, no +> matter what version of the change to test_expect_equal_file we go with. +> + +Ok. I am going to wait for some time (e.g. 2 days) for more opinions. +Though, I doubt I would get any :) (And the problem is really minor, so +it probably does not deserve much attention.) + +Currently, it seems that the original approach [1] wins. + +Regards, + Dmitry + +[1] id:"1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com" + +> jamie. -- 2.26.2