From b1b6afd800c73d58eb250f2dc9662ed5fd4cb9db Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Fri, 25 May 2012 23:53:20 +0300 Subject: [PATCH] Re: FreeBSD Support Patches --- 66/cd0e05979e5f8ccbe84770d77945f65bd1b753 | 98 +++++++++++++++++++++++ 1 file changed, 98 insertions(+) create mode 100644 66/cd0e05979e5f8ccbe84770d77945f65bd1b753 diff --git a/66/cd0e05979e5f8ccbe84770d77945f65bd1b753 b/66/cd0e05979e5f8ccbe84770d77945f65bd1b753 new file mode 100644 index 000000000..aff9d2b86 --- /dev/null +++ b/66/cd0e05979e5f8ccbe84770d77945f65bd1b753 @@ -0,0 +1,98 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id B5228431FBC + for ; Fri, 25 May 2012 13:53:13 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id NETJrnVIqgml for ; + Fri, 25 May 2012 13:53:10 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id C5DB2431FB6 + for ; Fri, 25 May 2012 13:53:10 -0700 (PDT) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id 387BE100641; Fri, 25 May 2012 23:53:20 +0300 (EEST) +From: Tomi Ollila +To: Mike Kelly , notmuch@notmuchmail.org +Subject: Re: FreeBSD Support Patches +In-Reply-To: <1337953411-21000-1-git-send-email-pioto@pioto.org> +References: <1337953411-21000-1-git-send-email-pioto@pioto.org> +User-Agent: Notmuch/0.13+38~g944a859 (http://notmuchmail.org) Emacs/23.1.1 + (x86_64-redhat-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 25 May 2012 20:53:13 -0000 + +On Fri, May 25 2012, Mike Kelly wrote: + +> Hi, +> +> These patches add some changes necessary for a clean build on FreeBSD, +> and for most of the tests to pass. +> +> Also mixed in are a few patches to disable emacs tests when you don't +> have emacs, along with tests that depend upon emacs. I could split those +> off onto a separate branch if required. + +Yes... + +Thank you for your efforts to make notmuch better; some general +comments on this patch series: + + +Commit messages are somewhat terse +check what http://notmuchmail.org/patchformatting/ +has to say about this. + +MANPATH setting has hit me too -- but that shold be set +in the same place where PATH is adjusted to find notmuch +command instead of hardcoding '../../man'. + +s/executable/+111/ (and following sed (which could be combined +into next sed but that's another matter)) is good (that hit me +once too) -- This particular patch has the worst commit message, +though (Make test/basic more portable) ;/ + +in 6/10 there is missing space before sed in '...wc -l |sed...'. + +-p overrides -n in perl, so perl -pe... (-npe confuses, at least +me...) + +The patch series is supposed to add FreeBSD support; +prereq additions to take care missing emacs should +be in separate series. + +Some of the patches could be marked as 'trivial', putting those +to 'maybe ready' section in http://nmbug.tethera.net/status/ +-- just if those had more comprehensive commit messages. + +> You can find the latest version of these patches on my github repo's +> fbsd-support branch: +> +> https://github.com/pioto/notmuch/compare/master...fbsd-support + +Tomi -- 2.26.2