From b17ed6d51a904b33e701fda63481077022e11808 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Tue, 28 Aug 2012 20:22:15 +2000 Subject: [PATCH] Re: [PATCH] emacs: notmuch-search: fix faces --- 51/d7401cc27310ee3201f7f8b26426bc21d505d7 | 114 ++++++++++++++++++++++ 1 file changed, 114 insertions(+) create mode 100644 51/d7401cc27310ee3201f7f8b26426bc21d505d7 diff --git a/51/d7401cc27310ee3201f7f8b26426bc21d505d7 b/51/d7401cc27310ee3201f7f8b26426bc21d505d7 new file mode 100644 index 000000000..7efc36268 --- /dev/null +++ b/51/d7401cc27310ee3201f7f8b26426bc21d505d7 @@ -0,0 +1,114 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id C99FE431FB6 + for ; Mon, 27 Aug 2012 17:22:20 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id SMHoPbFlRzFJ for ; + Mon, 27 Aug 2012 17:22:20 -0700 (PDT) +Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU + [18.7.68.36]) + by olra.theworths.org (Postfix) with ESMTP id 09ABE431FAE + for ; Mon, 27 Aug 2012 17:22:19 -0700 (PDT) +X-AuditID: 12074424-b7fa06d0000008c2-63-503c0f3a8b35 +Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) + by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP + id 4C.C2.02242.A3F0C305; Mon, 27 Aug 2012 20:22:18 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q7S0MHB8013804; + Mon, 27 Aug 2012 20:22:18 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q7S0MGe2007371 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Mon, 27 Aug 2012 20:22:17 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1T69ZP-0001UV-Sw; Mon, 27 Aug 2012 20:22:15 -0400 +Date: Mon, 27 Aug 2012 20:22:15 -0400 +From: Austin Clements +To: Michal Nazarewicz +Subject: Re: [PATCH] emacs: notmuch-search: fix faces +Message-ID: <20120828002215.GB11179@mit.edu> +References: + <83882f4c8de5317e0184dc091a197b2341e5f015.1345725028.git.mina86@mina86.com> + <87ipc4jcfv.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFuphleLIzCtJLcpLzFFi42IR4hTV1rXitwkw6PqpZ7Fnn5fFq+997BbX + b85kdmD2uHuay2PBplKPZ6tuMQcwR3HZpKTmZJalFunbJXBlnP18mLHgCX/FoXsz2RoYr/B0 + MXJySAiYSPxZ388KYYtJXLi3nq2LkYtDSGAfo8SmOSeYIJwNjBI7971lh3BOMkmcWtvGCOEs + YZSYe2cKI0g/i4CqRMPtB+wgNpuAhsS2/cvB4iICahIX/zxmArGZBSIkpsz4CGYLC5hKzJu5 + mgXE5hXQkfj6egnU7kWMErtvfGeHSAhKnJz5hAWiWUvixr+XQM0cQLa0xPJ/HCBhTqDw/N83 + wHaJCqhITDm5jW0Co9AsJN2zkHTPQuhewMi8ilE2JbdKNzcxM6c4NVm3ODkxLy+1SNdcLzez + RC81pXQTIyjQ2V1UdjA2H1I6xCjAwajEw/tipXWAEGtiWXFl7iFGSQ4mJVFeQx6bACG+pPyU + yozE4oz4otKc1OJDjBIczEoivLEvgMp5UxIrq1KL8mFS0hwsSuK811Nu+gsJpCeWpGanphak + FsFkZTg4lCR4g/mAhgoWpaanVqRl5pQgpJk4OEGG8wANNwGp4S0uSMwtzkyHyJ9iVJQS57UG + SQiAJDJK8+B6YYnoFaM40CvCvN4gVTzAJAbX/QpoMBPQ4P2KIFcXlyQipKQaGON6xEzT7+rv + EJZS59z+5c90S05v/assrzNiJTujPvBXTW9WNjRv76i7U9DYu9/GdIlXvdPqOQ6pGfPXLYjs + tfR70rHH7+yUd0Xf369Sqfsj0rurwrziUOvZh/eD2+W35N22E5/pdrSd5ZDgGQM1Xx/jWtPc + +DajBAHv81wq8Zsm/n8fZDVfiaU4I9FQi7moOBEA8Kwbzh8DAAA= +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 28 Aug 2012 00:22:20 -0000 + +Quoth Michal Nazarewicz on Aug 28 at 1:11 am: +> > On Thu, Aug 23 2012, Michal Nazarewicz wrote: +> >> For some reason the faces do not get applied when 'face property is +> >> used, but they work correctly with 'font-lock-face property. This +> >> commit changes notmuch-search to use the latter. +> +> Jameson Graef Rollins writes: +> > Hi, Michal. Can you say a bit more about what's motivating this? This +> > feature seems to work fine for me, so I would like to understand what's +> > not working for you. I'm certainly no expert on emacs font handling, +> > though, so maybe this is the proper thing to do. Thanks. +> +> I'm not an expert either, but with this patch applied I see colours, +> without this patch, I don't see colours, ie. everything is rendered +> using the default face. +> +> I'm also not entirely sure if that's the correct way of doing things +> since 'face seems to be working in other modes (most notably +> notmuch-show). By posting, I'm also hoping that someone more +> experienced will maybe take a look to see what's going on here... ;) +> +> For some more info, in notmuch-show mode, I get-text-property of nil for +> both 'face and 'font-lock-face, but in message-mode or in *scratch* +> buffer I'm getting nil for 'font-lock-face but non-nil for 'face. With +> the patch, I'm getting the same non-nil for both 'face and +> 'font-lock-face; without the patch, I'm getting nil for both. + +This is odd. Could you give more details about your environment? In +particular, what Emacs version are you running and might you have any +unusual Emacs packages installed or customizations set? + +The unusual thing about font-lock-face is that it only gets applied if +font-lock is enabled; otherwise it's ignored. One theory is that the +nil font-lock-face (without your patch) is causing font-lock to +*override* the face property that we set. I don't think font-lock +usually does that, but perhaps in some situations, it will? -- 2.26.2