From b15f24f7eed2777b1d57361889a01fa0e9c24b1f Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Thu, 23 Aug 2012 10:21:33 +0300 Subject: [PATCH] Re: [PATCH 00/11] add recipients to search output --- a8/092386b03fb1a1fea9887df9f8ce2e0580f633 | 105 ++++++++++++++++++++++ 1 file changed, 105 insertions(+) create mode 100644 a8/092386b03fb1a1fea9887df9f8ce2e0580f633 diff --git a/a8/092386b03fb1a1fea9887df9f8ce2e0580f633 b/a8/092386b03fb1a1fea9887df9f8ce2e0580f633 new file mode 100644 index 000000000..ccce23dc0 --- /dev/null +++ b/a8/092386b03fb1a1fea9887df9f8ce2e0580f633 @@ -0,0 +1,105 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E0B1D431FBD + for ; Thu, 23 Aug 2012 00:21:24 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id qNMOzN+2L3Ih for ; + Thu, 23 Aug 2012 00:21:24 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 63BFA431FAE + for ; Thu, 23 Aug 2012 00:21:24 -0700 (PDT) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id 78BB0100386; Thu, 23 Aug 2012 10:21:33 +0300 (EEST) +From: Tomi Ollila +To: Jameson Graef Rollins , + Notmuch Mail +Subject: Re: [PATCH 00/11] add recipients to search output +In-Reply-To: <1345427570-26518-1-git-send-email-jrollins@finestructure.net> +References: <1345427570-26518-1-git-send-email-jrollins@finestructure.net> +User-Agent: Notmuch/0.14+8~gd6b499d (http://notmuchmail.org) Emacs/23.1.1 + (x86_64-redhat-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 23 Aug 2012 07:21:25 -0000 + +On Mon, Aug 20 2012, Jameson Graef Rollins wrote: + +> This series is an attempt to add thread recipients to the search +> output. +> +> My personal overall goal of this series is to support the handling of +> drafts in the emacs ui. For drafts we want to see recipients, instead +> of authors, in the search output. I can imagine other uses for this +> series as well, though. +> +> The first four patches generalize the author list handling in thread +> objects to handle any address list. These patches could be applied +> regardless of if the rest of the series is accepted. +> +> After that we modify the thread constructor such that it can hold +> thread recipients as well. Since there is overhead in retrieving +> thread recipients from the message files (recipients are not stored in +> the database) this is handled with a switch. +> +> Further patches add the new switch to the search CLI that adds thread +> recipients to the structured output formats. I didn't modify the text +> output format, since there is no way to extend it. I can imagine +> tweaking the text output such that the author field is instead +> replaced by the recipients (as is done for the emacs UI at the end of +> the series), but that's not done here. +> +> In the emacs UI, I add a new toggle function that will toggle display +> of thread authors or recipients in the 'authors' field of the search +> output. It's unfortunate that this ambiguity in that field name +> remains, but I didn't know how to change that cleanly. I'm working on +> some tests for the new emacs functionality that I'll include in the +> inevitable v2 of this series. + +I did not read much of this introduction before browsing to the code, I +was about to comment whether attempt yo do less trivial tests are +to be done. + +> The last patch is mostly just a tickle to suggest adding the +> recipients to the database. It would make the --include-recipient +> searches much faster of course, but it might be overhead in the +> database that folks aren't interested in. + +I got tickled... adding To (and Cc?!) to the database would also give +(future notmuch?) address completion more addresses to match for. + +We should discuss whether to add other headers too? IIRC someone (Austin?) +mentioned that everything (except Received:) headers could be there ? + +> As always, feedback, review, and comments are much appreciated. + +Overall, the code looks good (to me). + +> jamie. + +Tomi -- 2.26.2