From b111f08875ac9aa5ea8ba97717cb6eabe2be95ec Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Tue, 14 Feb 2012 12:28:48 +0000 Subject: [PATCH] Re: [RFC PATCH v3 00/11] notmuch-pick: an emacs threaded message view with split-pane --- 0f/b67781af1a6c4d62c09c7d8406b3407232b415 | 119 ++++++++++++++++++++++ 1 file changed, 119 insertions(+) create mode 100644 0f/b67781af1a6c4d62c09c7d8406b3407232b415 diff --git a/0f/b67781af1a6c4d62c09c7d8406b3407232b415 b/0f/b67781af1a6c4d62c09c7d8406b3407232b415 new file mode 100644 index 000000000..29aedc3f7 --- /dev/null +++ b/0f/b67781af1a6c4d62c09c7d8406b3407232b415 @@ -0,0 +1,119 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 7C8CB431FBD + for ; Tue, 14 Feb 2012 04:27:30 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id jrcJoBYri7ey for ; + Tue, 14 Feb 2012 04:27:30 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id DA198431FBC + for ; Tue, 14 Feb 2012 04:27:29 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1RxHTh-0003o6-UN; Tue, 14 Feb 2012 12:27:26 +0000 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1RxHTh-0004nL-N4; Tue, 14 Feb 2012 12:27:25 +0000 +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: Re: [RFC PATCH v3 00/11] notmuch-pick: an emacs threaded message view + with split-pane +In-Reply-To: <1329096015-8078-1-git-send-email-markwalters1009@gmail.com> +References: <1329072579-27340-1-git-send-email-markwalters1009@gmail.com> + <1329096015-8078-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.11.1+203~g8b11562 (http://notmuchmail.org) Emacs/23.2.1 + (i486-pc-linux-gnu) +Date: Tue, 14 Feb 2012 12:28:48 +0000 +Message-ID: <87haytbnun.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: e60b2b6677e15dcdacee110fbbe5bbb5 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 14 Feb 2012 12:27:30 -0000 + + +I have now done some benchmarking/profiling of the notmuch-pick +mode. These are all done running locally (i.e., no ssh, nfs or anything) +but on a fairly old computer with a slow hard disk. The timings given +are for the second run (so the files and database are in cache). + +The profiling is done by inserting (message "%s" (current-time)) at +various points. + +For displaying the thread structure of the whole notmuch mailing list +archive (circa 10,000 messages) it takes about 18 seconds which breaks +down as 6.5 seconds for the cli part, 9.5 seconds for the json parsing +in emacs and 1.5 seconds for constructing the thread structure and +writing the buffer in emacs. + +Using Austin's optimised json.el (id:"20110720205007.GB21316@mit.edu") +the 9.5 seconds reduces to about 2.5 seconds (so the total reduces to +about 10.5 seconds). + +I think the 6.5 seconds of command line time involves quite a lot of +parsing of the message files (to get the headers) and this could +probably be sped up by storing more of the headers in the database, or +just not outputting all of them. Removing all of the calls to +notmuch_message_get_header seems to reduce the 6.5s to about 1.5s + +In other cases, though, notmuch-pick is a noticeable speed win: namely +`picking' is faster than `showing' for longer threads (as one would +expect since pick only gets the thread structure and one message body +whereas show gets the thread structure and all messages bodies). So for +a thread of 170 messages show takes 5 seconds and pick takes less than +0.5 seconds, and for a thread of 30 messages show takes 600 milliseconds +and pick takes takes 150 milliseconds. + +Finally, if notmuch-pick were able to do work asynchronously (as +notmuch-search does now) then I think all the speed concerns would go +away. However, I am not sure how to do incremental json parsing. + +Best wishes + +Mark + + -- 2.26.2