From b0806466cdc0c886fe3e09ee72a73413b49fe2f2 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Sun, 24 Jun 2012 10:10:01 +0300 Subject: [PATCH] Re: [PATCH v2] emacs: add function to toggle display of all multipart/alternative parts --- ac/17d8d6ce4f22e46efa21715a1450f0d322b7aa | 124 ++++++++++++++++++++++ 1 file changed, 124 insertions(+) create mode 100644 ac/17d8d6ce4f22e46efa21715a1450f0d322b7aa diff --git a/ac/17d8d6ce4f22e46efa21715a1450f0d322b7aa b/ac/17d8d6ce4f22e46efa21715a1450f0d322b7aa new file mode 100644 index 000000000..a98c1c5ab --- /dev/null +++ b/ac/17d8d6ce4f22e46efa21715a1450f0d322b7aa @@ -0,0 +1,124 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 2E5CB431FBD + for ; Sun, 24 Jun 2012 00:10:04 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.699 +X-Spam-Level: +X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 + tests=[HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id YPINXvKFe3g9 for ; + Sun, 24 Jun 2012 00:10:03 -0700 (PDT) +Received: from mail-ob0-f181.google.com (mail-ob0-f181.google.com + [209.85.214.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 741CA431FAF + for ; Sun, 24 Jun 2012 00:10:03 -0700 (PDT) +Received: by obbup19 with SMTP id up19so5244500obb.26 + for ; Sun, 24 Jun 2012 00:10:01 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=mime-version:in-reply-to:references:date:message-id:subject:from:to + :cc:content-type:x-gm-message-state; + bh=1H2o4s5+udM2FMbh4djIIgQb36kx62coEsGti2qet+8=; + b=In0WhtExJCSTTSefThkjkYLHcfrb/xTyDgrB1KCogU6CBRRXMwyrrDgDr2BqFOydBq + 50dO0SgXEQtWNFlfDEtGdvX2JvS8ljx5waj+dMbMjrRmKmZW0OuNWeotwBJ0EnEcA4xS + OWw6kaEDqRVw12EeYrhLag1GETrfZm7g/L3+nAit0Crwmhw+LOxUqn9Zt6txrGMiZ6vQ + uNLeShLCRontLZJWev76zv3r858C+DGtldhA1hYAC3JUJmnWj0yilC9rB8vHizYQG1xC + Xx/ovc6oHFQZ5FscH5yR97GZBWbk+I8DTbd/ECtr3I1v7ynuKwNO2xThhcdcJMajOaGr + AHVQ== +MIME-Version: 1.0 +Received: by 10.182.77.170 with SMTP id t10mr8119382obw.70.1340521801817; Sun, + 24 Jun 2012 00:10:01 -0700 (PDT) +Received: by 10.76.10.102 with HTTP; Sun, 24 Jun 2012 00:10:01 -0700 (PDT) +Received: by 10.76.10.102 with HTTP; Sun, 24 Jun 2012 00:10:01 -0700 (PDT) +In-Reply-To: <87zk7vasdd.fsf@zancas.localnet> +References: <1339775751-18002-1-git-send-email-jani@nikula.org> + <1340136889-2992-1-git-send-email-jani@nikula.org> + <87zk7vasdd.fsf@zancas.localnet> +Date: Sun, 24 Jun 2012 10:10:01 +0300 +Message-ID: + +Subject: Re: [PATCH v2] emacs: add function to toggle display of all + multipart/alternative parts +From: Jani Nikula +To: David Bremner +Content-Type: multipart/alternative; boundary=f46d044517c1cf9f0604c3328d46 +X-Gm-Message-State: + ALoCoQkkb0I3jQiB8HDOVqpzSPq6IocuDllqfbG+uUW1ycuYYDaCK6JXt04InSo/7UC80v3VvwY9 +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 24 Jun 2012 07:10:04 -0000 + +--f46d044517c1cf9f0604c3328d46 +Content-Type: text/plain; charset=UTF-8 + +On Jun 23, 2012 1:34 AM, "David Bremner" wrote: +> +> Jani Nikula writes: +> +> > +> > A small wrinkle is that in order to make the variable survive +> > notmuch-show-refresh-view (which is required for expanding/collapsing +> > the parts, but ends up calling kill-all-local-variables through +> > notmuch-show-mode) it is necessary to give it the permanent-local +> > property. +> +> The code looks simple enough; should we apply this patch while we wait +> for something fancier? + +Applying this doesn't make the fancy stuff harder to do at all. And this +doesn't have a key binding, on purpose, so we're not committed to that +either. But then I'm biased... + +> I don't really know how to evaluate the +> permanent-local bit. + +All the other show mode toggles use that too. It's probably less surprising +like this than the permanently local only as needed approach in v1. + +> +> d + +--f46d044517c1cf9f0604c3328d46 +Content-Type: text/html; charset=UTF-8 + +


+On Jun 23, 2012 1:34 AM, "David Bremner" <david@tethera.net> wrote:
+>
+> Jani Nikula <jani@nikula.org> writes:
+>
+> >
+> > A small wrinkle is that in order to make the variable survive
+> > notmuch-show-refresh-view (which is required for expanding/collapsing
+> > the parts, but ends up calling kill-all-local-variables through
+> > notmuch-show-mode) it is necessary to give it the permanent-local
+> > property.
+>
+> The code looks simple enough; should we apply this patch while we wait
+> for something fancier?

+

Applying this doesn't make the fancy stuff harder to do at all. And this doesn't have a key binding, on purpose, so we're not committed to that either. But then I'm biased...

+

> I don't really know how to evaluate the
+> permanent-local bit.

+

All the other show mode toggles use that too. It's probably less surprising like this than the permanently local only as needed approach in v1.

+

>
+> d
+

+ +--f46d044517c1cf9f0604c3328d46-- -- 2.26.2