From b031f2a730aab5e1b268c8a1c980df5ec7e8b97e Mon Sep 17 00:00:00 2001 From: Sebastien Binet Date: Mon, 30 Apr 2012 22:14:37 +0200 Subject: [PATCH] Re: [PATCH] go: Update to the current notmuch_database_find_message API --- 39/7265a776443e0412a7b16338227c4c393ced62 | 134 ++++++++++++++++++++++ 1 file changed, 134 insertions(+) create mode 100644 39/7265a776443e0412a7b16338227c4c393ced62 diff --git a/39/7265a776443e0412a7b16338227c4c393ced62 b/39/7265a776443e0412a7b16338227c4c393ced62 new file mode 100644 index 000000000..22d8b5a86 --- /dev/null +++ b/39/7265a776443e0412a7b16338227c4c393ced62 @@ -0,0 +1,134 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1114E431FAF + for ; Mon, 30 Apr 2012 13:13:47 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "Cc" +X-Spam-Flag: NO +X-Spam-Score: -0.789 +X-Spam-Level: +X-Spam-Status: No, score=-0.789 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, T_MIME_NO_TEXT=0.01] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id yQcQz6zMA9Ng for ; + Mon, 30 Apr 2012 13:13:46 -0700 (PDT) +Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com + [209.85.212.179]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 346A2431FAE + for ; Mon, 30 Apr 2012 13:13:46 -0700 (PDT) +Received: by wibhn6 with SMTP id hn6so2573973wib.2 + for ; Mon, 30 Apr 2012 13:13:45 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:cc:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type; + bh=Wr1TmkOamTXP9aBidPA5ce/nxpZzbzDBTSVrc5cBAwg=; + b=KVjRt/y8jekOAmzmdLPhuJAmFpyXJsZJ34ugBMp+SQaXLOegHcqrRYTYwscTuAkUfO + 98GJcMmPldnPXgwXSb247RU9SqOyOMbVcLDk8/Oq7oBkV9RCbX+zuOoka0+XTF5eJqYv + /ddcJ/RMx/Bn6fbI3Z9GOKrhLPs8IyRjgCbjuF0R5SzJOMdn5TGBfIr3Bn2L4SGAT/DQ + DnnPMvxoQJvqQO7yzvBjOTeAY9QhnoBsODyGi8r51JAZoWOd+o5FX6BXKEhH83Rff4kk + VHJzI76V7ZF9iXor8jQbFlJUoMRKMfGdM5bR0F3wlAPZ5/tbe7wRPxT1A0p+orwiwnbm + knpg== +Received: by 10.180.83.72 with SMTP id o8mr3022488wiy.5.1335816824971; + Mon, 30 Apr 2012 13:13:44 -0700 (PDT) +Received: from localhost (pc-88068.lal.in2p3.fr. [134.158.88.68]) + by mx.google.com with ESMTPS id fl2sm48640161wib.2.2012.04.30.13.13.43 + (version=TLSv1/SSLv3 cipher=OTHER); + Mon, 30 Apr 2012 13:13:44 -0700 (PDT) +From: Sebastien Binet > +To: Justus Winter <4winter@informatik.uni-hamburg.de>, + David Bremner +Subject: Re: [PATCH] go: Update to the current notmuch_database_find_message + API +In-Reply-To: <20120430195420.2528.48612@thinkbox.jade-hamburg.de> +References: <1335649518-1970-1-git-send-email-amdragon@mit.edu> + <87lildph9w.fsf@zancas.localnet> + <20120430195420.2528.48612@thinkbox.jade-hamburg.de> +User-Agent: Notmuch/0.12+123~g9429141 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-unknown-linux-gnu) +Date: Mon, 30 Apr 2012 22:14:37 +0200 +Message-ID: <87sjfldljm.fsf@cern.ch> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +Cc: , notmuch mailing list +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 30 Apr 2012 20:13:47 -0000 + +--=-=-= +Content-Transfer-Encoding: quoted-printable + + +Justus, + +Justus Winter <4winter@informatik.uni-hamburg.de> writes: + +> Quoting David Bremner (2012-04-30 13:53:47) +>> Austin Clements writes: +>>=20 +>> > The signature of notmuch_database_find_message was changed in 02a30767 +>> > to report errors and the Go bindings were never updated. This brings +>> > the Go bindings in sync with that change and at least makes them +>> > compile with Go r60.3, the last release before Go 1. +>>=20 +>> I don't have any easy way to test this, since the current versions in=20 +>> Debian are all based on Go 1. On the other hand I guess it doesn't make +>> things worse. Anybody have any objections to this patch? +> +> lgtm. +> +>> In the long run we have to decide what to do about these bindings. Seb +>> (or anyone else) are you interested in porting them to Go 1 and +>> maintaining them? Otherwise it may be time to deprecate them. +> +> I care enough for the go environment to keep the go bindings +> working. I've updated the bindings, the build infrastructure and the +> notmuch-addrlookup utility to go 1. I'll send a patch series as a +> followup that is meant to be applied upon Austins patch. +> +> The last patch in the series is a cleanup of the source code done with +> the gofmt utility. Go is somewhat strict in its coding conventions, +> but there is a utility that magically formats code. This makes the go +> code in the wild remarkably consistent. We should stick to the +> conventions too, hence this patch even if it breaks git blame +> somewhat. +> +> I haven't tested the bindings in depth, but the notmuch-addrlookup +> utility seems to be working fine. + +kudos for picking this up. +I must say I don't use these go bindings in anger anymore: this was +mainly a test project for go. +(I am still a happy go user as well as a notmuch one, though, but I +prefer bbdb to notmuch-addrlookup) + +=2Ds + + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v2.0.19 (GNU/Linux) + +iEYEARECAAYFAk+e8r0ACgkQPj4AVbsZCCaujwCcDmFifxccbNK/by+L3hCE13vG +lckAnRKkXa9A+sAKCYAOxIGYf3LNa65V +=W5Vw +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2