From acadd86e06980a9becb8dd6e76c718d2a4c76360 Mon Sep 17 00:00:00 2001 From: David Edmondson Date: Tue, 31 Jan 2012 08:22:20 +0000 Subject: [PATCH] Re: [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer. --- 64/c49ef3697e5b8742c79fee085352497615e46b | 125 ++++++++++++++++++++++ 1 file changed, 125 insertions(+) create mode 100644 64/c49ef3697e5b8742c79fee085352497615e46b diff --git a/64/c49ef3697e5b8742c79fee085352497615e46b b/64/c49ef3697e5b8742c79fee085352497615e46b new file mode 100644 index 000000000..113fd6aff --- /dev/null +++ b/64/c49ef3697e5b8742c79fee085352497615e46b @@ -0,0 +1,125 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 693B5429E34 + for ; Tue, 31 Jan 2012 00:22:30 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 6UvZ4h9AyWxS for ; + Tue, 31 Jan 2012 00:22:29 -0800 (PST) +Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com + [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + A6B6E431E64 for ; Tue, 31 Jan 2012 00:22:29 -0800 + (PST) +Received: by wgbdt12 with SMTP id dt12so4891508wgb.2 + for ; Tue, 31 Jan 2012 00:22:28 -0800 (PST) +Received: by 10.180.89.67 with SMTP id bm3mr33060173wib.13.1327998148276; + Tue, 31 Jan 2012 00:22:28 -0800 (PST) +Received: from hotblack-desiato.hh.sledj.net + (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) + by mx.google.com with ESMTPS id j16sm60637362wie.4.2012.01.31.00.22.26 + (version=TLSv1/SSLv3 cipher=OTHER); + Tue, 31 Jan 2012 00:22:27 -0800 (PST) +Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) + id 11BCF9FD63; Tue, 31 Jan 2012 08:22:25 +0000 (GMT) +To: Dmitry Kurochkin , notmuch@notmuchmail.org +Subject: Re: [PATCH 2/2] emacs: Don't move to the next thread unless the + cursor is at the end of the buffer. +In-Reply-To: <87bopknvct.fsf@gmail.com> +References: <1327996914-9644-1-git-send-email-dme@dme.org> + <1327996914-9644-3-git-send-email-dme@dme.org> + <87bopknvct.fsf@gmail.com> +User-Agent: Notmuch/0.11+137~g7cd907b (http://notmuchmail.org) Emacs/24.0.92.1 + (x86_64-pc-linux-gnu) +From: David Edmondson +Date: Tue, 31 Jan 2012 08:22:20 +0000 +Message-ID: +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 31 Jan 2012 08:22:30 -0000 + +--=-=-= +Content-Type: text/plain +Content-Transfer-Encoding: quoted-printable + +On Tue, 31 Jan 2012 12:12:50 +0400, Dmitry Kurochkin wrote: +> On Tue, 31 Jan 2012 08:01:54 +0000, David Edmondson wrote: +> > When using the spacebar to scroll through a thread, hitting 'space' +> > when the bottom of the last message is visible should take the cursor +> > to the end of the buffer rather than immediately archiving the thread +> > and moving to the next thread. +> > --- +>=20 +> I did not notice this change yet, so +0 +>=20 +> A style comment below. +>=20 +> > emacs/notmuch-show.el | 5 +++++ +> > 1 files changed, 5 insertions(+), 0 deletions(-) +> >=20 +> > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +> > index ec72ff8..3f54de0 100644 +> > --- a/emacs/notmuch-show.el +> > +++ b/emacs/notmuch-show.el +> > @@ -1319,6 +1319,11 @@ current window), advance to the next open messag= +e." +> > ;; This is not the last message - move to the next visible one. +> > (notmuch-show-next-open-message)) +> >=20=20 +> > + ((not (=3D (point) (point-max))) +> > + ;; This is the last message, but the cursor is not at the end of +> > + ;; the buffer. Move it there. +> > + (goto-char (point-max))) +>=20 +> Perhaps `unless' would be better here? + +It's the CONDITION clause of `cond', so that wouldn't be appropriate. + +> Regards, +> Dmitry +>=20 +> > + +> > (t +> > ;; This is the last message - change the return value +> > (setq ret t))) +> > --=20 +> > 1.7.8.3 +> >=20 +> > _______________________________________________ +> > notmuch mailing list +> > notmuch@notmuchmail.org +> > http://notmuchmail.org/mailman/listinfo/notmuch + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.11 (GNU/Linux) + +iEYEARECAAYFAk8npLwACgkQaezQq/BJZRZg8ACcCokp2iqFplIKTC4LyQb6BhbG +p4IAn1oTs6S9Wksjpyf7nZfDftOJOQZt +=2moY +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2