From abb377073418baac0a18a6162af9c0f7771510a7 Mon Sep 17 00:00:00 2001 From: Michal Nazarewicz Date: Tue, 28 Aug 2012 01:11:05 +0200 Subject: [PATCH] Re: [PATCH] emacs: notmuch-search: fix faces --- 35/2e93c9e09f7aaef410b58af07bdcc6ad4c0d73 | 154 ++++++++++++++++++++++ 1 file changed, 154 insertions(+) create mode 100644 35/2e93c9e09f7aaef410b58af07bdcc6ad4c0d73 diff --git a/35/2e93c9e09f7aaef410b58af07bdcc6ad4c0d73 b/35/2e93c9e09f7aaef410b58af07bdcc6ad4c0d73 new file mode 100644 index 000000000..2da368bb8 --- /dev/null +++ b/35/2e93c9e09f7aaef410b58af07bdcc6ad4c0d73 @@ -0,0 +1,154 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 0882A431FB6 + for ; Mon, 27 Aug 2012 16:11:16 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.8 +X-Spam-Level: +X-Spam-Status: No, score=-0.8 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id rXkzqbjgyWLL for ; + Mon, 27 Aug 2012 16:11:15 -0700 (PDT) +Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com + [74.125.83.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + 2E53A431FAE for ; Mon, 27 Aug 2012 16:11:15 -0700 + (PDT) +Received: by eekb47 with SMTP id b47so1360458eek.26 + for ; Mon, 27 Aug 2012 16:11:13 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; + s=20120113; h=from:to:subject:in-reply-to:organization:references:user-agent + :x-face:face:x-pgp:x-pgp-fp:date:message-id:mime-version :content-type; + bh=Ik/J2ID7GdU9IRmafYP+07DA21IUugVYKa+pPyfZ5cY=; + b=gPYdEjC1rrbFBabZndKeYYk5xuduXoRDxKKDiCnLXbvEc7jswBDJuLECPNKf59y3Kp + aIceErCFh9BaFJf3w+aGTiPWP/WSfqWwOic4IxBJQAIOiWVId4Xb40PMWG94NRXHPmgQ + mdUnTMO3uklBF/Fs/hOdPfrXyI86xQotjJ+/5U9HbiiENMgbSWb4/e17G9nV4YnzTy/B + KcY2F+75KQI2CgdRQx/589OI5Eyy2vhOdtXVYmIYMsgyiIJo25thwZDS4Nog4NKjjhXw + ehhXnQ4c3ZAdn8ySgzjtswP8dXIRnfpTdRm82/tdgu5ieAC2pFlAw7u7biyG+Iu0I3C/ eqUQ== +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=from:to:subject:in-reply-to:organization:references:user-agent + :x-face:face:x-pgp:x-pgp-fp:date:message-id:mime-version + :content-type:x-gm-message-state; + bh=Ik/J2ID7GdU9IRmafYP+07DA21IUugVYKa+pPyfZ5cY=; + b=EctxjKnRsEqhzQYrzw/WuQNu6SUBa/t6eRddnkwfxd9OIpbpeOyuAKt9LJY8ZhALws + sS5+mz4ewEHG6rJ5Jgrfg1+SoiGZQFvM4sUqxxDfZi3Vte50GOXgZr1H3Lyd+cxdAiVi + B9zp03xYg2SxIpYiu1VqtkhLs928k68/CnMjrmFhtRSI9+w4SvJXl9n+y0F0Rrj4d1Wj + 45/mvvNrfCODqqWcCtKNFb2rDrLVAQtdgoUQwBmWcqDkm0+03/MCzbZ00gKgvkWlUNWa + edo5OuH0o5MFzj5tWwgTSSwNIYuDT8OuIo2k7WwD/Ccw2AXw5gGEfI1AbkkfjuWV1rMO + OAuw== +Received: by 10.14.203.69 with SMTP id e45mr3363469eeo.23.1346109073918; + Mon, 27 Aug 2012 16:11:13 -0700 (PDT) +Received: by 10.14.203.69 with SMTP id e45mr3363457eeo.23.1346109073753; + Mon, 27 Aug 2012 16:11:13 -0700 (PDT) +Received: from mpn-glaptop ([2620:0:105f:5:f2de:f1ff:fe35:1a72]) + by mx.google.com with ESMTPS id v3sm56095064eep.10.2012.08.27.16.11.10 + (version=TLSv1/SSLv3 cipher=OTHER); + Mon, 27 Aug 2012 16:11:12 -0700 (PDT) +From: Michal Nazarewicz +To: Jameson Graef Rollins , + notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: notmuch-search: fix faces +In-Reply-To: <87ipc4jcfv.fsf@servo.finestructure.net> +Organization: Google Inc +References: + <83882f4c8de5317e0184dc091a197b2341e5f015.1345725028.git.mina86@mina86.com> + <87ipc4jcfv.fsf@servo.finestructure.net> +User-Agent: Notmuch/0.14+2~g416b120 (http://notmuchmail.org) Emacs/24.2.50.1 + (x86_64-unknown-linux-gnu) +X-Face: PbkBB1w#)bOqd`iCe"Ds{e+!C7`pkC9a|f)Qo^BMQvy\q5x3?vDQJeN(DS?|-^$uMti[3D*#^_Ts"pU$jBQLq~Ud6iNwAw_r_o_4]|JO?]}P_}Nc&"p#D(ZgUb4uCNPe7~a[DbPG0T~!&c.y$Ur,=N4RT>]dNpd; KFrfMCylc}gc??'U2j,!8%xdD +Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC +X-PGP: 50751FF4 +X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 +Date: Tue, 28 Aug 2012 01:11:05 +0200 +Message-ID: +MIME-Version: 1.0 +Content-Type: multipart/mixed; boundary="=-=-=" +X-Gm-Message-State: ALoCoQmzDF4KkvfdPFFFhX5REkahG/bX9c7mC8ZD+WnG3PTvpfeKUbt37xVGHbKsEPhoPGnimwz09v/1rpEHqRukkybXYQDdw+LFPEfJjks6tPyp7//xJQvu/APB8X6w2Ac/FubtSSMDMC1jC0Jr9HWK2L0vxBdOjWVaDTvCpaQm4Aoi0PbPKlMLiUtwxMHzHUml7AtCb09ukyTPXfSZb4I8eMQ7JqKDRA== +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 27 Aug 2012 23:11:16 -0000 + +--=-=-= +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable + +> On Thu, Aug 23 2012, Michal Nazarewicz wrote: +>> For some reason the faces do not get applied when 'face property is +>> used, but they work correctly with 'font-lock-face property. This +>> commit changes notmuch-search to use the latter. + +Jameson Graef Rollins writes: +> Hi, Michal. Can you say a bit more about what's motivating this? This +> feature seems to work fine for me, so I would like to understand what's +> not working for you. I'm certainly no expert on emacs font handling, +> though, so maybe this is the proper thing to do. Thanks. + +I'm not an expert either, but with this patch applied I see colours, +without this patch, I don't see colours, ie. everything is rendered +using the default face. + +I'm also not entirely sure if that's the correct way of doing things +since 'face seems to be working in other modes (most notably +notmuch-show). By posting, I'm also hoping that someone more +experienced will maybe take a look to see what's going on here... ;) + +For some more info, in notmuch-show mode, I get-text-property of nil for +both 'face and 'font-lock-face, but in message-mode or in *scratch* +buffer I'm getting nil for 'font-lock-face but non-nil for 'face. With +the patch, I'm getting the same non-nil for both 'face and +'font-lock-face; without the patch, I'm getting nil for both. + +--=20 +Best regards, _ _ +.o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o +..o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz = + (o o) +ooo +------------------ooO--(_)--Ooo-- +--=-=-= +Content-Type: multipart/signed; boundary="==-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" + +--==-=-= +Content-Type: text/plain + + +--==-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.10 (GNU/Linux) + +iQIcBAEBAgAGBQJQO/6JAAoJECBgQBJQdR/0akcQAIHv7HM1dpg8CdL91ZgHus10 +k+QwrXnTyr3GoRsJrD3sPZEnXc1FxXFJbMNq+b+nBfsU6Ihjv8WpuqMP/K3amo5f +x3lEjsvnsUB8Is8/lvp3OuGW9l8+AhWphX6dB2n3uqUTy0w6xzurwB5JHEUG0Z+C +IHs45QfvVhkw7BEpV3o8FCDcP0letSbFg2ff2AnASFoHh8nykeVo1e/hjWp0qJao +t1nYwxjw2g000O81aNN6xxbbksfxlNWvquypnCmUIHbhBROLgaJKCKs6/MskEA30 +BNuXsDB81TwVBcoyO83ttl1zU9CdCrq6cUkEYvQy8aZxn5Isn0jeg5vGnzh7mm3J +g5jIb3eohBX2MngafLqVGrCrzGolZjXqF+GekllDNuVUcfqXychhpiBRNE+XZ+2T +i8Hj/PTRCvTKRg/vIqCQma4cSo2qtJ0hMW0or7McNZ8XWne1tFPKqJ3It4qBFrqf +SKRZPD6V41X3U44sRQ+SQ6hTfyNHkOIVwGNVQ6ZPs84/x9J2JuUJ0FxQq26s9Ne2 +7QLQaEdswBzvsdKS1+2AMvIXirq+mIFTIcrpjzaUWEgKcWTSO4o5t3l8s8VJ+wz2 +iav9EAxIlxdXma6rnd2n3/ER+3RzUL361FI31v1/a2bEU1z1xRi/ihOzYHRpojz5 +0yRaBPwWAwPQMXvyMjBz +=C4xR +-----END PGP SIGNATURE----- +--==-=-=-- + +--=-=-=-- -- 2.26.2