From aae82fdfe37de0aa7a723622a9d3c3caf169a76f Mon Sep 17 00:00:00 2001 From: Daniel Schoepe Date: Wed, 7 Mar 2012 21:04:17 +0100 Subject: [PATCH] Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello --- f0/fe899fc35335f3b63073c024ca8500d5f422d9 | 136 ++++++++++++++++++++++ 1 file changed, 136 insertions(+) create mode 100644 f0/fe899fc35335f3b63073c024ca8500d5f422d9 diff --git a/f0/fe899fc35335f3b63073c024ca8500d5f422d9 b/f0/fe899fc35335f3b63073c024ca8500d5f422d9 new file mode 100644 index 000000000..ffe5b481b --- /dev/null +++ b/f0/fe899fc35335f3b63073c024ca8500d5f422d9 @@ -0,0 +1,136 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id B660C431FAE + for ; Wed, 7 Mar 2012 12:04:28 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.502 +X-Spam-Level: +X-Spam-Status: No, score=0.502 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, + FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id WfCAAdAwyfAz for ; + Wed, 7 Mar 2012 12:04:27 -0800 (PST) +Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com + [74.125.83.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + B3472431FB6 for ; Wed, 7 Mar 2012 12:04:27 -0800 + (PST) +Received: by eekb47 with SMTP id b47so3438604eek.26 + for ; Wed, 07 Mar 2012 12:04:26 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=schoepe.org; s=google; + h=sender:from:to:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type; + bh=Z6eoupzLnLpynutyx7IZ38iJavFQqT3T4s7wjXmJKUQ=; + b=DXpKrLLy9scKxxYPaZo7t6tKx6xihnna06USZfb9XeaiKtfOpZCgKrB2cwhJfy27VV + ZZMhGNctHIqsK7gRcNpzkq06tekqbGHhq74fboGtD0TOY1qR5xtXmChGSeC4A2Mr5ymZ + l7jXUDrO/a40VTGGdWNgwukqb0CoBqWZSLjRA= +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=sender:from:to:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type:x-gm-message-state; + bh=Z6eoupzLnLpynutyx7IZ38iJavFQqT3T4s7wjXmJKUQ=; + b=MQzdINQzHdsUuEj6zsdVBhewQicWVlqkbbUMX9zI3Tf8i8sMk/vsgry74pyh/mGVad + 8T1VBQx3XaQM15IAxjeMqzLIg/Bm3KAThbj52DIfX2A/vWVIAwseAEiVNJ7t2eSAZWow + FX2nNfep5LkzgAxNDlYGBqkA1m7fvJEWX4cpxqkC5lP0twBMpkq4YBeT+b1OFFO+k0yM + 0hfwcw/Tfa+GWONmLFM4FzSL7nt21h2DChzSVJztCEzlaL1C67Z9g+qYg28ECeX8kLhq + 1ioeJ+qkV+DKENegRW6L8aSh0Qn52woFTFPZ9l15fsPfWcoiHDvVv/WZ1MINDSqOj2M9 + kSOw== +Received: by 10.213.13.72 with SMTP id b8mr847382eba.153.1331150666303; + Wed, 07 Mar 2012 12:04:26 -0800 (PST) +Received: from localhost (p4FC78F99.dip0.t-ipconnect.de. [79.199.143.153]) + by mx.google.com with ESMTPS id w9sm19720662eei.8.2012.03.07.12.04.23 + (version=TLSv1/SSLv3 cipher=OTHER); + Wed, 07 Mar 2012 12:04:24 -0800 (PST) +Sender: Daniel Schoepe +From: Daniel Schoepe +To: Pieter Praet , David Bremner , + Dmitry Kurochkin , notmuch@notmuchmail.org +Subject: Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello +In-Reply-To: <87aa3s427n.fsf@praet.org> +References: <1310079227-19120-1-git-send-email-daniel.schoepe@googlemail.com> + <1329490088-8323-1-git-send-email-dmitry.kurochkin@gmail.com> + <1329490088-8323-2-git-send-email-dmitry.kurochkin@gmail.com> + <87ipio33ce.fsf@zancas.localnet> <87aa3s427n.fsf@praet.org> +User-Agent: Notmuch/0.11.1+309~g6296425 (http://notmuchmail.org) + Emacs/24.0.93.1 (x86_64-pc-linux-gnu) +Date: Wed, 07 Mar 2012 21:04:17 +0100 +Message-ID: <87ipigtby6.fsf@schoepe.localhost> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +X-Gm-Message-State: + ALoCoQkrQDz1kmgQ4vF0Ux7xbeat1LgQczvuEx1P+qJ0oTI22UkrC1T8JX262cM21koyTfsGu/Z4 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 07 Mar 2012 20:04:28 -0000 + +--=-=-= +Content-Type: text/plain +Content-Transfer-Encoding: quoted-printable + +On Wed, 07 Mar 2012 20:53:48 +0100, Pieter Praet wrote: +> On Thu, 01 Mar 2012 08:36:33 -0400, David Bremner wro= +te: +> >=20 +> > Pushed, finally. Thanks for both of your hard work on this. +> > +>=20 +> 625 lines changed (425 added, 200 removed), in a *single* commit ? +>=20 +> It's a useful bit of functionality which definitely deserves to be +> included, and I do recognize and appreciate all the hard work that +> went into it, but... am I the only one who was a bit surprised to +> see this patch being applied [1] as-is? + +I think it is hard to split this patch up into meaningful smaller +pieces, since it mainly moves parts from notmuch-hello into separate +functions and adds some defcustoms. So, the main opportunities for +splitting would be to do this moving of code into functions one function +per commit and to put the defcustoms and their quite lengthy +documentation in a separate commit (which would leave you with an +intermediate version that's seriously lacking in documentation). + +I'm not sure if those two things are that useful, but if there's +consensus that the patch shouldn't stay in the way it is, I can give it +a shot (although it'd be a lot of tedious work). + +Cheers, +Daniel + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBAgAGBQJPV79BAAoJEIaTAtce+Z+Jm8YQAJDID9EyQL4lfLo6iwGh6qNu +6ZdimOZ9evbH5aejIV+cqQcRI8gTgidNqWiL3lZG660vPni8pL7Tk8pCboGab13I +ezllVagCYYhq2N78WOv1m7xzOrvObHcyH0T5lVVxVrRzymmaLFp09ZYSvU2vwjju +k/CpDUwxF3i5l7L664qsnRft2bXoP1HwbZPoSPfQhEYSDZKJ6/nIlwaIBF1C3oUq +0Xknemg9XlNBdJQv/OblTLuFMOxRQOuemfVzWVNCT3qJiNhhjhy/MEAE9zyDBAGE +RQrEdpehXLyoASTaPMEpqN7tIz8wtHyGRmqQv8epdspzuxBW0reSUHaVg0K4rpTX +gG+dd+Tc+Fi45bKC+2QEiWm4+lb7gNSRoIBV8+f9QiCjKrzxp7U/443x0yD9d2SS +zn1HGOTBpOQYojfy+19YUtqqcoJDE3FSGPk1jMWt93cM+sM402iVN9O6igmZXG9u +Cgg6XlM+mCjrT2qGfxQ5Cv/+itaGDltFDhVY17sLgBJUqD8VR1DkJrjuHiqR8Rh1 +E+8mrPr0LgUT6C2lk0FhZs4UGc+UUJMNhe8lTW8AASM06Mjx/Uf6PBnZEwQcygRM +k7wGAtz35R8q2fhFomV7wmLErMT8vAEV5ZsARQfHNQwQphudSIGsElhZMyxgZsXP +ADrTY9Uto9ftAggS5gcC +=ZtOc +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2