From aa0bc39873c9f8a43bec080f9dfd67f3a17bb3a0 Mon Sep 17 00:00:00 2001 From: Adam Wolfe Gordon Date: Thu, 19 Apr 2012 11:27:50 +1800 Subject: [PATCH] Re: [PATCH v2 2/3] reply: add message-id header --- 17/dcb96800bf4edf91804d560e6fb17d847db72d | 92 +++++++++++++++++++++++ 1 file changed, 92 insertions(+) create mode 100644 17/dcb96800bf4edf91804d560e6fb17d847db72d diff --git a/17/dcb96800bf4edf91804d560e6fb17d847db72d b/17/dcb96800bf4edf91804d560e6fb17d847db72d new file mode 100644 index 000000000..4ba469615 --- /dev/null +++ b/17/dcb96800bf4edf91804d560e6fb17d847db72d @@ -0,0 +1,92 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 5D3F7431FB6 + for ; Wed, 18 Apr 2012 10:27:56 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id y-JIuGqOXiO3 for ; + Wed, 18 Apr 2012 10:27:52 -0700 (PDT) +Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 222A5431FAE + for ; Wed, 18 Apr 2012 10:27:51 -0700 (PDT) +Received: by lahc1 with SMTP id c1so6030630lah.26 + for ; Wed, 18 Apr 2012 10:27:50 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=mime-version:sender:x-originating-ip:in-reply-to:references:date + :x-google-sender-auth:message-id:subject:from:to:cc:content-type + :x-gm-message-state; + bh=5UKZTVFxrA5JUexhY/ghtSxumeXXKwCqhtfZkbPyl9Q=; + b=Empld8ZbuHnGCa+O2O6CoDuRjSuEo0UjbM5MNZzNrBj/H4bIgXRaj0xIVu7CT9RMhQ + cqBXeKRiC5go3ViSmvwvhhHnZY5xnax/09X03GjspjKIG2ZYoXdwsmmLn6011Vomk1NJ + TeBJCuBAJbEBs4VZrcPjYm46sY7mMoGvFRUkvxxGMoe77ngIJscbaFOUnW5mxOUUStUf + Wm58StNpfIInSWZybLIPR9NU8uoQHvT3ylcJApNmWJcwH46lv59JhlNuedXss76RdgSK + Oo6/8aTbZtLerCm8yo6sqhpp27O3xc7kvWWfzZxv/4YIZFd08o2eClep83wxWVgSQuJe + 9t/g== +MIME-Version: 1.0 +Received: by 10.152.129.137 with SMTP id nw9mr2891547lab.48.1334770070514; + Wed, 18 Apr 2012 10:27:50 -0700 (PDT) +Sender: awg@xvx.ca +Received: by 10.112.23.39 with HTTP; Wed, 18 Apr 2012 10:27:50 -0700 (PDT) +X-Originating-IP: [128.221.197.57] +In-Reply-To: <87zka9b2zl.fsf@nikula.org> +References: <1334752753-23970-1-git-send-email-felipe.contreras@gmail.com> + <1334752753-23970-3-git-send-email-felipe.contreras@gmail.com> + <87zka9b2zl.fsf@nikula.org> +Date: Wed, 18 Apr 2012 11:27:50 -0600 +X-Google-Sender-Auth: HOAc3JhsmjFtQXXv_GnbGVBVbrM +Message-ID: + +Subject: Re: [PATCH v2 2/3] reply: add message-id header +From: Adam Wolfe Gordon +To: Jani Nikula +Content-Type: text/plain; charset=ISO-8859-1 +X-Gm-Message-State: + ALoCoQk70iM5wlrLmilJo38gh3siahojd62Q1lMZ7cmPIL2BmH4Xlu99qLTu5eQiG/kPd0he9LYV +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 18 Apr 2012 17:27:56 -0000 + +On Wed, Apr 18, 2012 at 07:09, Jani Nikula wrote: +> I do wonder whether the emacs ui / message mode will add a duplicate +> message-id rather than override this. + +I think the emacs reply code will replace Message-ID and User-Agent +headers correctly, as it does with the From header when selecting a +different identity within emacs. But, this should be tested. + +Ideally, the emacs tests should catch any problems here. As things are +right now, I think we would catch problems with the User-Agent header +in the reply tests: the tests replace the emacs and notmuch versions +with XXX but otherwise leave the header intact, so it should differ +from the one generated by notmuch compose. + +The Message-ID is trickier, since in emacs it's generated when the +message is sent, not when the message is created, and thus the reply +tests don't see it at all. The "Sending a message via (fake) SMTP" +test could potentially catch problems, but currently the tests don't +try to predict the Message-ID emacs will give the message, so they +replace it with XXX. + +-- Adam -- 2.26.2