From a981ee032f59e96b111c7345c8baf14cc21fd411 Mon Sep 17 00:00:00 2001 From: Jesse Rosenthal Date: Fri, 15 Jun 2012 12:35:46 +2000 Subject: [PATCH] Re: [PATCH] emacs: derive correct timestamp in FCC unique name --- 91/3b67f9fc28050c6f4172f142e675ad8dfb5b66 | 91 +++++++++++++++++++++++ 1 file changed, 91 insertions(+) create mode 100644 91/3b67f9fc28050c6f4172f142e675ad8dfb5b66 diff --git a/91/3b67f9fc28050c6f4172f142e675ad8dfb5b66 b/91/3b67f9fc28050c6f4172f142e675ad8dfb5b66 new file mode 100644 index 000000000..085fa869f --- /dev/null +++ b/91/3b67f9fc28050c6f4172f142e675ad8dfb5b66 @@ -0,0 +1,91 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id ED997431FB6 + for ; Thu, 14 Jun 2012 10:35:49 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id scEMnLbK3b8Q for ; + Thu, 14 Jun 2012 10:35:47 -0700 (PDT) +X-Greylist: delayed 3602 seconds by postgrey-1.32 at olra; + Thu, 14 Jun 2012 10:35:47 PDT +Received: from smtpauth.johnshopkins.edu (smtpauth.johnshopkins.edu + [162.129.8.201]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 3880A431FAE + for ; Thu, 14 Jun 2012 10:35:47 -0700 (PDT) +X-IronPort-Anti-Spam-Filtered: true +X-IronPort-Anti-Spam-Result: Ak4JACQS2k8KoSES/2dsb2JhbABFtA0DgjOCGAEBBAF+CwsNCwklDwEsGwYBEogGsRCJBIsyd4UaA5sXA4x/ +X-IronPort-AV: E=Sophos;i="4.75,770,1330923600"; d="scan'208";a="154617523" +Received: from unknown (HELO watt) ([10.161.33.18]) + by ipex2.johnshopkins.edu with ESMTP/TLS/AES256-SHA; + 14 Jun 2012 12:35:44 -0400 +Received: from jkr by watt with local (Exim 4.76) + (envelope-from ) + id 1SfD1O-0002nv-3y; Thu, 14 Jun 2012 12:35:46 -0400 +From: Jesse Rosenthal +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: derive correct timestamp in FCC unique name +In-Reply-To: +References: <87d353ezyw.fsf@jhu.edu> +User-Agent: Notmuch/0.12~rc1 (http://notmuchmail.org) Emacs/24.1.50.1 + (i686-pc-linux-gnu) +Date: Thu, 14 Jun 2012 12:35:46 -0400 +Message-ID: <871ulhhmvx.fsf@jhu.edu> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 14 Jun 2012 17:35:50 -0000 + +Hi, + +thanks for thinking this through. + +On Thu, 14 Jun 2012, Tomi Ollila wrote: +> Alternatives: +> +> 1) Use current patch, filenames will have extra '-' in 2038 on 32-bit +> systems. + +Well, that assumes there is still the same arithmetic operations -- the +calendar issue will probably push them to either auto-convert to float +or use bignum. But still, assuming that in 2038, people are still on +32bit machines, it seems we should minimize the amount of things that +need to be fixed. + +So I agree that... + +> 2) Drop 'timeid' and replace it with (float-time) in `format` call a few +> lines in original source after the patch context below -- No idea +> how (float-time) works on 32-bit systems after 2038. + +is probably the best. They'll have to deal with their time_t (again, +assuming the unlikely existence of 32bit machines then) but this doesn't +depend on their arithemetic. + +I'll send a revision to this thread. + +> I suggest option #2. +> +> Tomi + +Thanks again, +Jesse -- 2.26.2