From a7a5bae6545a7e55069364ad39f92eb7cad9b72f Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Sat, 10 Mar 2012 00:33:27 +0200 Subject: [PATCH] [PATCH 0/3] argument parsing additions --- cc/ce7612d8d4824fbe689bf04864a3524349ffb5 | 98 +++++++++++++++++++++++ 1 file changed, 98 insertions(+) create mode 100644 cc/ce7612d8d4824fbe689bf04864a3524349ffb5 diff --git a/cc/ce7612d8d4824fbe689bf04864a3524349ffb5 b/cc/ce7612d8d4824fbe689bf04864a3524349ffb5 new file mode 100644 index 000000000..822d52a3e --- /dev/null +++ b/cc/ce7612d8d4824fbe689bf04864a3524349ffb5 @@ -0,0 +1,98 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 90CC1431FBC + for ; Fri, 9 Mar 2012 14:33:38 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id AVFxqTwSh3MT for ; + Fri, 9 Mar 2012 14:33:38 -0800 (PST) +Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id DA794431FAE + for ; Fri, 9 Mar 2012 14:33:37 -0800 (PST) +Received: by lahc1 with SMTP id c1so2252374lah.26 + for ; Fri, 09 Mar 2012 14:33:34 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references + :x-gm-message-state; + bh=6O1OFY0g/SBOQFGOj1o/3/GqLK9X2j6EZ8mhFboZO44=; + b=kBKfSVm+XOvod37geb1osQTzix3U2pdmwMOfCrkWUorympEgFj3MNov25E5pRJ1KpD + QiaYYGoTpeCEHnJVTK/bfORDUDPbZzmFl+dI+IG/xtuJejk65ktPSbof11fTRAFmqmnU + 1+HU93r6/sFTVPUa381hUXArhZdbq6AcyLr4dB1fj54t88dqn2q3D+vRm/dzn+xZhUAw + UzIpNmxokyVO3Ue1xuUW3Gt7syGefWUxjK/9qCHrOoqMMKdlTEGnZZixnoxcfyG/ul7v + NQbkINNrFfaBOmBfTjn5vvLPIZU0oMWWKa2QVxS6u2oWm0ZMfxzqvx2vVKJACqnqO45D + cdaQ== +Received: by 10.112.36.71 with SMTP id o7mr882007lbj.3.1331332414729; + Fri, 09 Mar 2012 14:33:34 -0800 (PST) +Received: from localhost (dsl-hkibrasgw4-fe50f800-253.dhcp.inet.fi. + [84.248.80.253]) + by mx.google.com with ESMTPS id k10sm8024202lbu.1.2012.03.09.14.33.32 + (version=SSLv3 cipher=OTHER); Fri, 09 Mar 2012 14:33:33 -0800 (PST) +From: Jani Nikula +To: notmuch@notmuchmail.org, + markwalters1009@gmail.com +Subject: [PATCH 0/3] argument parsing additions +Date: Sat, 10 Mar 2012 00:33:27 +0200 +Message-Id: +X-Mailer: git-send-email 1.7.5.4 +In-Reply-To: <87399iicit.fsf@qmul.ac.uk> +References: <87399iicit.fsf@qmul.ac.uk> +X-Gm-Message-State: + ALoCoQk2QDxxdRAWpx/NnkCSodP7a3iecOz1B7kQuMiip7tO8LjoSMbz4tqlAi/FVbawhvwPWv1D +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 09 Mar 2012 22:33:38 -0000 + +Hi Mark - + +I'm not sure which is worse, criticizing or rewriting other people's +patches. I already did the former, and now I'm doing the +latter. Apologies for both. I didn't really mean to write these patches, +but it turned out to be more fun writing a proper reply in C than in +English. + +Patch 1 adds --arg=true and --arg=false support for booleans. It's not +strictly required for the --entire-thread support in patch 3, which uses +the extension of keyword arguments from patch 2, but it's for +consistency across boolean arguments. + +Please let me know what you think. + +BR, +Jani. + + +Jani Nikula (3): + command-line-arguments: allow true and false keywords for booleans + command-line-arguments: support keyword arguments with default value + cli: allow switching off entire thread mode in notmuch show json + format + + command-line-arguments.c | 45 +++++++++++++++++++++++++++++++++++++++------ + command-line-arguments.h | 1 + + notmuch-show.c | 12 ++++++++++-- + 3 files changed, 50 insertions(+), 8 deletions(-) + +-- +1.7.5.4 + -- 2.26.2