From a4e63b9a33da97ff382b82f8015ff8f53522c8d9 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Thu, 8 Nov 2012 08:44:14 +2000 Subject: [PATCH] Re: [PATCH] don't show x-foo tags in search view --- 74/decde736f638cc003ebe8232438b4ca31ed0e7 | 78 +++++++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 74/decde736f638cc003ebe8232438b4ca31ed0e7 diff --git a/74/decde736f638cc003ebe8232438b4ca31ed0e7 b/74/decde736f638cc003ebe8232438b4ca31ed0e7 new file mode 100644 index 000000000..6f5d0974a --- /dev/null +++ b/74/decde736f638cc003ebe8232438b4ca31ed0e7 @@ -0,0 +1,78 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 63829431FB6 + for ; Wed, 7 Nov 2012 04:44:33 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id pshtSqM26mf5 for ; + Wed, 7 Nov 2012 04:44:33 -0800 (PST) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id EE348431FAE + for ; Wed, 7 Nov 2012 04:44:32 -0800 (PST) +Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.89.108] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) + (envelope-from ) + id 1TW4zb-0006vt-Or; Wed, 07 Nov 2012 08:44:32 -0400 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1TW4zO-0005s2-B9; Wed, 07 Nov 2012 08:44:14 -0400 +From: David Bremner +To: James Vasile +Subject: Re: [PATCH] don't show x-foo tags in search view +In-Reply-To: <87390w57oo.fsf@hackervisions.org> +References: <87fw4x3y3e.fsf@hackervisions.org> + <87liepw0b4.fsf@convex-new.cs.unb.ca> + <87625tc6xd.fsf@hackervisions.org> <20121030005700.GE15377@mit.edu> + <87390w57oo.fsf@hackervisions.org> +User-Agent: Notmuch/0.14+75~g984212d (http://notmuchmail.org) Emacs/24.1.1 + (x86_64-pc-linux-gnu) +Date: Wed, 07 Nov 2012 08:44:14 -0400 +Message-ID: <871ug5k2g1.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +Cc: notmuch mailing list +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 07 Nov 2012 12:44:33 -0000 + +James Vasile writes: + +> Austin, +> +> Thanks for the helpful comments. I redid the patch to take a list of +> regexps. That way users can banish different kinds of tags or simply +> list the tags themselves. I've responded to your comments in text below +> the patch. +> + +I think the patch is probably OK now contentwise, but the commit message +is what I quoted above, which is not ideal. + +As far as being obsoleted by Damien's labeller patches, let's cross that +bridge when we come to it. Unless somebody objects, I'd be willing to +push some version of this now. + +d -- 2.26.2