From a442309ea317e10bcc2f79e31cabfa1e21be5f90 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Tue, 10 Jul 2012 21:49:46 +2000 Subject: [PATCH] Re: [PATCH 1/3] emacs: add no-display arg to notmuch-hello-refresh-hook --- e8/5d683eec8c849b486dd56c2218014937556cb1 | 97 +++++++++++++++++++++++ 1 file changed, 97 insertions(+) create mode 100644 e8/5d683eec8c849b486dd56c2218014937556cb1 diff --git a/e8/5d683eec8c849b486dd56c2218014937556cb1 b/e8/5d683eec8c849b486dd56c2218014937556cb1 new file mode 100644 index 000000000..1bf7036ac --- /dev/null +++ b/e8/5d683eec8c849b486dd56c2218014937556cb1 @@ -0,0 +1,97 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 3B0BB431E64 + for ; Mon, 9 Jul 2012 18:49:50 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id HM9Lf74JFeUu for ; + Mon, 9 Jul 2012 18:49:49 -0700 (PDT) +Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU + [18.9.25.15]) + by olra.theworths.org (Postfix) with ESMTP id 8169C431FBF + for ; Mon, 9 Jul 2012 18:49:49 -0700 (PDT) +X-AuditID: 1209190f-b7f306d0000008b4-85-4ffb8a3c72d2 +Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) + by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP + id AF.B7.02228.C3A8BFF4; Mon, 9 Jul 2012 21:49:48 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q6A1nmGC006944; + Mon, 9 Jul 2012 21:49:48 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q6A1nkYQ016560 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Mon, 9 Jul 2012 21:49:47 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1SoPaE-0002oy-B7; Mon, 09 Jul 2012 21:49:46 -0400 +Date: Mon, 9 Jul 2012 21:49:46 -0400 +From: Austin Clements +To: Jani Nikula +Subject: Re: [PATCH 1/3] emacs: add no-display arg to + notmuch-hello-refresh-hook +Message-ID: <20120710014946.GB7332@mit.edu> +References: + <37899e28dbf67e4620a53279a869be3174c02d6f.1339775602.git.jani@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: + <37899e28dbf67e4620a53279a869be3174c02d6f.1339775602.git.jani@nikula.org> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IRYrdT17Xp+u1vMH+SjUXTdGeL6zdnMjsw + edy6/5rd49mqW8wBTFFcNimpOZllqUX6dglcGV37+hkL3rJVTG7tYGpgPM3axcjJISFgInFu + 3wsWCFtM4sK99WwgtpDAPkaJnbeDuxi5gOz1jBLP189ghHBOMEms/v+AGcJZwijx7uUDJpAW + FgEViY/tvWBj2QQ0JLbtX84IYosIKEpsPrkfzGYWkJb49rsZrF5YIEii99ZBMJtXQFuifdle + qNWhEmd737FAxAUlTs58wgLRqyVx499LoHoOsDnL/3GAhDkFwiRebr7FDmKLAp0w5eQ2tgmM + QrOQdM9C0j0LoXsBI/MqRtmU3Crd3MTMnOLUZN3i5MS8vNQiXRO93MwSvdSU0k2MoKDmlOTf + wfjtoNIhRgEORiUe3k0sv/2FWBPLiitzDzFKcjApifIWdACF+JLyUyozEosz4otKc1KLDzFK + cDArifDecgXK8aYkVlalFuXDpKQ5WJTEea+m3PQXEkhPLEnNTk0tSC2CycpwcChJ8CZ1AjUK + FqWmp1akZeaUIKSZODhBhvMADe8BqeEtLkjMLc5Mh8ifYlSUEuctAUkIgCQySvPgemFJ5xWj + ONArwrylIFU8wIQF1/0KaDAT0OD2nl8gg0sSEVJSDYxJhgZxTyfnLvzhVsrgqsTBlm4z1b0/ + PVqx6+lsMd/dqfHlB1gnte00bIh3K/Ttv5Bkft1vr85BvgP7Fq+Y/Fj9sn3dt5BTwjV3HzM9 + eX3e5FeJ9so475UyRbl/ex4V2N0o4j4qWHI7dc5/uV38ep1rT/imh2RrOymfyEs9++J1XbSn + KNNGcyWW4oxEQy3mouJEAPMmG4wVAwAA +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 10 Jul 2012 01:49:50 -0000 + +Quoth Jani Nikula on Jun 15 at 6:53 pm: +> Add no-display arg to notmuch-hello-refresh-hook to allow each hook to +> decide what is appropriate when no-display is t, which is typically +> the case when called non-interactively. This is used by the following +> patch. +> +> This breaks existing hooks people might have, which will now need to +> accept the argument. +> +> Signed-off-by: Jani Nikula + +This seems like an overloaded use of no-display. If I'm reading the +code right, no-display indicates whether or not the notmuch-hello +buffer should be switched to and seems like a workaround for some +particular corner-case (I'm not even sure what). This seems like a +strange condition to predicate a hook on (but maybe I just don't +understand). What condition, abstractly speaking, is +notmuch-hello-refresh-status-message trying to run under? -- 2.26.2