From a43f28b1e301d758dd41730d15db335e0e53a8ff Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Sun, 15 Apr 2012 18:14:59 +0100 Subject: [PATCH] Re: [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer. --- 1f/4d1f856116c01251984bae50c7a8c1a820b307 | 120 ++++++++++++++++++++++ 1 file changed, 120 insertions(+) create mode 100644 1f/4d1f856116c01251984bae50c7a8c1a820b307 diff --git a/1f/4d1f856116c01251984bae50c7a8c1a820b307 b/1f/4d1f856116c01251984bae50c7a8c1a820b307 new file mode 100644 index 000000000..649c757af --- /dev/null +++ b/1f/4d1f856116c01251984bae50c7a8c1a820b307 @@ -0,0 +1,120 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id D43B8431FAF + for ; Sun, 15 Apr 2012 10:14:47 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id kCAEVIr07EGu for ; + Sun, 15 Apr 2012 10:14:47 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 19F23431FAE + for ; Sun, 15 Apr 2012 10:14:47 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1SJT28-0004lS-Du; Sun, 15 Apr 2012 18:14:42 +0100 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1SJT28-0002nB-2r; Sun, 15 Apr 2012 18:14:40 +0100 +From: Mark Walters +To: David Edmondson , notmuch@notmuchmail.org +Subject: Re: [PATCH 2/2] emacs: Don't move to the next thread unless the + cursor is at the end of the buffer. +In-Reply-To: <1327996914-9644-3-git-send-email-dme@dme.org> +References: <1327996914-9644-1-git-send-email-dme@dme.org> + <1327996914-9644-3-git-send-email-dme@dme.org> +User-Agent: Notmuch/0.12+110~gbc97b4a (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 15 Apr 2012 18:14:59 +0100 +Message-ID: <87lilw6hnw.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 80510b1f8ce6ac3fabaf4e9ab3aa1233 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 15 Apr 2012 17:14:48 -0000 + + +On Tue, 31 Jan 2012, David Edmondson wrote: +> When using the spacebar to scroll through a thread, hitting 'space' +> when the bottom of the last message is visible should take the cursor +> to the end of the buffer rather than immediately archiving the thread +> and moving to the next thread. + +Hi + +This patch looks good to me; (but if people prefer the current behaviour then +can we mark this notmuch::wontfix so it leaves the review queue) + +Best wishes + +Mark + +> --- +> emacs/notmuch-show.el | 5 +++++ +> 1 files changed, 5 insertions(+), 0 deletions(-) +> +> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +> index ec72ff8..3f54de0 100644 +> --- a/emacs/notmuch-show.el +> +++ b/emacs/notmuch-show.el +> @@ -1319,6 +1319,11 @@ current window), advance to the next open message." +> ;; This is not the last message - move to the next visible one. +> (notmuch-show-next-open-message)) +> +> + ((not (= (point) (point-max))) +> + ;; This is the last message, but the cursor is not at the end of +> + ;; the buffer. Move it there. +> + (goto-char (point-max))) +> + +> (t +> ;; This is the last message - change the return value +> (setq ret t))) +> -- +> 1.7.8.3 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2