From a413dda1e8bfdf450fd5fa55bf674495e22667bd Mon Sep 17 00:00:00 2001 From: James Vasile Date: Thu, 8 Nov 2012 20:45:29 +1900 Subject: [PATCH] Re: [PATCH] fix notmuch_database_open call in addrlookup --- 9c/366675c7c23c999412b623773db4128260bec2 | 105 ++++++++++++++++++++++ 1 file changed, 105 insertions(+) create mode 100644 9c/366675c7c23c999412b623773db4128260bec2 diff --git a/9c/366675c7c23c999412b623773db4128260bec2 b/9c/366675c7c23c999412b623773db4128260bec2 new file mode 100644 index 000000000..09ac83e73 --- /dev/null +++ b/9c/366675c7c23c999412b623773db4128260bec2 @@ -0,0 +1,105 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id ADF23431FB6 + for ; Wed, 7 Nov 2012 17:45:45 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.01 +X-Spam-Level: +X-Spam-Status: No, score=0.01 tagged_above=-999 required=5 + tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id aayckuG9ZXo9 for ; + Wed, 7 Nov 2012 17:45:44 -0800 (PST) +Received: from mail.sflc.info (mail.sflc.info [207.86.247.70]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id F07CC431FAE + for ; Wed, 7 Nov 2012 17:45:43 -0800 (PST) +Received: from localhost (ool-457af02d.dyn.optonline.net [69.122.240.45]) + by mail.sflc.info (Postfix) with ESMTPSA id 8A2B7B4C018; + Thu, 8 Nov 2012 01:45:38 +0000 (UTC) +From: James Vasile +To: Ethan Glasser-Camp , + notmuch mailing list +Subject: Re: [PATCH] fix notmuch_database_open call in addrlookup +In-Reply-To: <87y5idijfx.fsf@jamesvasile.com> +References: <87ip9q4moj.fsf@hackervisions.org> + <87625jidlr.fsf@betacantrips.com> <87y5idijfx.fsf@jamesvasile.com> +User-Agent: Notmuch/0.14+96~gb732e1b (http://notmuchmail.org) Emacs/23.4.1 + (i486-pc-linux-gnu) +Date: Wed, 07 Nov 2012 20:45:29 -0500 +Message-ID: <87mwyseukm.fsf@jamesvasile.com> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 08 Nov 2012 01:45:45 -0000 + +--=-=-= + +James Vasile writes: +> Ethan Glasser-Camp writes: +> +>> James Vasile writes: +>> +>>> What's the best way to submit changes to addrlookup? Right now, it is +>>> out of date vs the latest libnotmuch. The addrlookup repo is vala code +>>> but the wiki [1] points to a generated c file [2]. +>>> +>>> [1] http://github.com/spaetz/vala-notmuch/raw/static-sources/src/addrlookup.c +>>> [2] http://notmuchmail.org/emacstips/ +>>> +>>> At any rate, a patch to that c file is below. If you upgraded notmuch +>>> and now addrlookup gives errors about not finding libnotmuch.so.2, this +>>> patch might be what you need. +>> +>> I'd try to contact the author of the code, perhaps by submitting an +>> issue or pull request on the github page for the project. I'm sure he'd +>> prefer a patch to the Vala source. +>> +>> Ethan +> +> Thanks, will do. My vala is weak, so a patch to the vala source is +> unlikely to make it to the front of my queue this year. I'll ping +> Sebastian Spaeth directly and via github. +> +> -J + +Just to close the loop: I contacted Sebastian and he applied my patch. +I tested the instructions on the wiki and confirmed they are currently +correct against his tree. He notes that he doesn't currently have time +to monitor the list closely. + +Thanks, +-J + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQEcBAEBAgAGBQJQmw65AAoJECaDklOuuidY5ycH/0wRP9OnA/v67CC5NHMHT+YF +dhvnXcpSrF7Kyu2opbf73VsRLsmjvNCQupg7SAwH0X1QS2BQfykE2UKk5BJDNPOj +29ID7ENUU1TuiBPBryO6VOa6u7w6qkYtub0/1+svl/Y4/VNUjNlUAGFrKj7105xe +8/qzIpuuXi+RU6Z799TazsemZWrAWJ1TOP6iWPM0OFTPZDQhs0CfHhnwXmc80jvD +dV5GGB3cULMIaPVrj3UZNMzCunRljIEC4Xiz8ZQbyjDayWtXz8G+TXn46SR99qkA +BEaht7eQeomrmFOV9LbMPTUke3teMAOoTXgMxBnJyt4cPEZIL90JGSY7TYByWgs= +=UYCx +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2