From a3bbd88d46dc5a68460719380d698ae4009452e4 Mon Sep 17 00:00:00 2001 From: Dmitry Kurochkin Date: Sun, 19 Feb 2012 21:29:56 +0400 Subject: [PATCH] Re: [PATCH 0/3] Make notmuch-show-refresh-view retain state by default --- 15/1373b3d157a1fdc4d2228f43f60bca01910635 | 111 ++++++++++++++++++++++ 1 file changed, 111 insertions(+) create mode 100644 15/1373b3d157a1fdc4d2228f43f60bca01910635 diff --git a/15/1373b3d157a1fdc4d2228f43f60bca01910635 b/15/1373b3d157a1fdc4d2228f43f60bca01910635 new file mode 100644 index 000000000..bc6e9a7d1 --- /dev/null +++ b/15/1373b3d157a1fdc4d2228f43f60bca01910635 @@ -0,0 +1,111 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 69C90431FB6 + for ; Sun, 19 Feb 2012 09:31:22 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ZJPVIpKB4qrJ for ; + Sun, 19 Feb 2012 09:31:21 -0800 (PST) +Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com + [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id A55C9431FAE + for ; Sun, 19 Feb 2012 09:31:21 -0800 (PST) +Received: by bkcit16 with SMTP id it16so4630255bkc.26 + for ; Sun, 19 Feb 2012 09:31:20 -0800 (PST) +Received-SPF: pass (google.com: domain of dmitry.kurochkin@gmail.com + designates 10.204.152.7 as permitted sender) + client-ip=10.204.152.7; +Authentication-Results: mr.google.com; spf=pass (google.com: domain of + dmitry.kurochkin@gmail.com designates 10.204.152.7 as permitted + sender) smtp.mail=dmitry.kurochkin@gmail.com; + dkim=pass header.i=dmitry.kurochkin@gmail.com +Received: from mr.google.com ([10.204.152.7]) + by 10.204.152.7 with SMTP id e7mr9617915bkw.70.1329672680456 (num_hops + = 1); Sun, 19 Feb 2012 09:31:20 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; + h=from:to:cc:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type; + bh=G3J8PuPfV9b+r5WaJfD8SrPFbJ7PIprwTMMgWbm0s/Y=; + b=baJOD5O0mN5sOpLSvc9e4m4Zi5BAfvnykIbP071V84MwYql7mDQXNvg5x1ZpZk/upT + dHC9Fdm2EU25YiSChisosQ5NhQV9AV7KWfulxQoKi+q7Lx47VVFN/6+MfgGLNL5c900O + ZpgUR0ZnOyHByRYAGeGdsTq1lZVGiORAQmyDk= +Received: by 10.204.152.7 with SMTP id e7mr7800322bkw.70.1329672678892; + Sun, 19 Feb 2012 09:31:18 -0800 (PST) +Received: from localhost ([91.144.186.21]) + by mx.google.com with ESMTPS id bw9sm34213369bkb.8.2012.02.19.09.31.17 + (version=TLSv1/SSLv3 cipher=OTHER); + Sun, 19 Feb 2012 09:31:18 -0800 (PST) +From: Dmitry Kurochkin +To: Austin Clements , Tomi Ollila +Subject: Re: [PATCH 0/3] Make notmuch-show-refresh-view retain state by + default +In-Reply-To: <20120219172541.GQ5991@mit.edu> +References: <1329632533-16152-1-git-send-email-amdragon@mit.edu> + <20120219172541.GQ5991@mit.edu> +User-Agent: Notmuch/0.11.1+188~ga5674c2 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 19 Feb 2012 21:29:56 +0400 +Message-ID: <87zkceloiz.fsf@gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 19 Feb 2012 17:31:22 -0000 + +On Sun, 19 Feb 2012 12:25:41 -0500, Austin Clements wrote: +> Quoth Tomi Ollila on Feb 19 at 11:43 am: +> > On Sun, 19 Feb 2012 01:22:10 -0500, Austin Clements wrote: +> > > Based on the thread at id:"20120213152858.GO27039@mit.edu" it seems +> > > like people want show refresh to retain message state by default (I +> > > certainly do), rather than reset it by default. As a nice bonus, this +> > > fixes a broken test. +> > +> > Hmm +> > +> > Every '=' keypress in a thread removes 'unread' tag from next unread +> > message :o +> +> Oh dear. It's slightly subtler than that, though. Refreshing will +> remove the unread tag from the first message matching the query. (I +> suspect you had tag:unread in your query?) This is particularly +> confusing for state-retaining refresh because that message might not +> even be open. +> +> > That is probably desirable feature when refreshing view without +> > retaining state. Also, probably notmuch-show-refresh-view should +> > be fixed not to mark next message unread when retaining state ? +> +> I would argue that refresh should never have side-effects, so neither +> case should mark anything read. I'll send a v2. + +I agree. But this looks like a separate issue, no? So why v2 instead +of a separate patch/series? + +Regards, + Dmitry + +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2