From a2301a72f03793d5a54d6537a75a0fec2b610691 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Thu, 3 May 2012 20:23:51 +2000 Subject: [PATCH] Re: [PATCH v2 0/6] Make notmuch_database_{open, create} return status codes --- 08/cbdc6fe27b97d66dcaa0a082fd19387efd14a1 | 104 ++++++++++++++++++++++ 1 file changed, 104 insertions(+) create mode 100644 08/cbdc6fe27b97d66dcaa0a082fd19387efd14a1 diff --git a/08/cbdc6fe27b97d66dcaa0a082fd19387efd14a1 b/08/cbdc6fe27b97d66dcaa0a082fd19387efd14a1 new file mode 100644 index 000000000..a47ae6c6f --- /dev/null +++ b/08/cbdc6fe27b97d66dcaa0a082fd19387efd14a1 @@ -0,0 +1,104 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E7ECE431FAF + for ; Wed, 2 May 2012 17:23:56 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id fTAMlJCSxLMQ for ; + Wed, 2 May 2012 17:23:55 -0700 (PDT) +Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU + [18.7.68.36]) + by olra.theworths.org (Postfix) with ESMTP id 79826431FAE + for ; Wed, 2 May 2012 17:23:55 -0700 (PDT) +X-AuditID: 12074424-b7fae6d000000906-6a-4fa1d01aa58e +Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) + by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP + id CC.B2.02310.A10D1AF4; Wed, 2 May 2012 20:23:54 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q430NriG027903; + Wed, 2 May 2012 20:23:54 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q430Npl6004860 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Wed, 2 May 2012 20:23:53 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1SPjpn-0006wx-F5; Wed, 02 May 2012 20:23:51 -0400 +Date: Wed, 2 May 2012 20:23:51 -0400 +From: Austin Clements +To: Tomi Ollila +Subject: Re: [PATCH v2 0/6] Make notmuch_database_{open, create} return + status codes +Message-ID: <20120503002351.GZ2704@mit.edu> +References: <1335651473-19652-1-git-send-email-amdragon@mit.edu> + <1335803138-24024-1-git-send-email-amdragon@mit.edu> + +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42IRYrdT15W6sNDf4PoUE4vrN2cyW7xZOY/V + gcnj8NeFLB7PVt1iDmCK4rJJSc3JLEst0rdL4Mr4dPs+e8Ek9oo9XRYNjAdYuxg5OSQETCTa + m/cwQthiEhfurWfrYuTiEBLYxygxd+YXdghnPaPE6VszmEGqhAROMEkceVUAkVjCKHF8wVqg + URwcLAIqEttfuoHUsAloSGzbvxxsqghQ+EHberBtzALSEt9+NzOBlAsLhEkc3MIBEuYV0JZY + 9nsC1K65jBLNZ34yQyQEJU7OfMIC0aslcePfS7BekDnL/4H1cgoYSCy9tJcdxBYFWjXl5Da2 + CYxCs5B0z0LSPQuhewEj8ypG2ZTcKt3cxMyc4tRk3eLkxLy81CJdc73czBK91JTSTYzgkHZR + 2cHYfEjpEKMAB6MSDy9z1EJ/IdbEsuLK3EOMkhxMSqK8804AhfiS8lMqMxKLM+KLSnNSiw8x + SnAwK4nwqrUB5XhTEiurUovyYVLSHCxK4rwaWu/8hATSE0tSs1NTC1KLYLIyHBxKErxl54Ea + BYtS01Mr0jJzShDSTBycIMN5gIangtTwFhck5hZnpkPkTzEqSonzeoEkBEASGaV5cL2wlPOK + URzoFWHedJAqHmC6gut+BTSYCWhwvvk8kMEliQgpqQZGozuxzsGN7513h/Uwmn9n+L6e+/Cu + K63Tg0t2ndskv7bs2O3WBx99rG8arEsU0QwseJ11sYyNS+f0R443s3+6hkqyPfxq5nym0zNz + zqz4tgk71U9t0nz/52mc3wMP2X82RZMlrI+Vyax4d+eM23ndAJ76n1c9519RU7x0WrShxmXH + pkkLbhSUKbEUZyQaajEXFScCAJIz8gkUAwAA +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 03 May 2012 00:23:57 -0000 + +Quoth Tomi Ollila on May 02 at 10:08 pm: +> On Mon, Apr 30 2012, Austin Clements wrote: +> +> > Relative to v1, this makes notmuch_database_open and +> > notmuch_database_create gracefully handle a NULL out-argument and adds +> > documentation of the possible error return values from these two +> > functions. Patches 3 and on have not changed. +> +> LGTM. +> +> One question though: +> +> In bindings/python/notmuch/database.py class Database functions +> create() and open() have the following last lines: +> +> + if status != STATUS.SUCCESS: +> + raise NotmuchError(status) +> + self._db = db +> + return status +> +> What is the point returning 'status' in the only case the +> value is STATUS.SUCCESS -- is some caller interested on this ? + +This was for consistency with other methods (e.g., begin_atomic also +only ever returns STATUS.SUCCESS). -- 2.26.2