From a0feeb9e607e7246c93845d960657ee9f9153c93 Mon Sep 17 00:00:00 2001 From: Adam Wolfe Gordon Date: Sun, 25 Mar 2012 18:27:10 +1800 Subject: [PATCH] [BUG/PATCH 0/2] Replying from other addresses in emacs --- a9/0050b6f167bb5335e4b5d64adcaf3ee6b4da5f | 79 +++++++++++++++++++++++ 1 file changed, 79 insertions(+) create mode 100644 a9/0050b6f167bb5335e4b5d64adcaf3ee6b4da5f diff --git a/a9/0050b6f167bb5335e4b5d64adcaf3ee6b4da5f b/a9/0050b6f167bb5335e4b5d64adcaf3ee6b4da5f new file mode 100644 index 000000000..100599cbe --- /dev/null +++ b/a9/0050b6f167bb5335e4b5d64adcaf3ee6b4da5f @@ -0,0 +1,79 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 054BE431FC7 + for ; Sat, 24 Mar 2012 17:27:22 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Y8Bzp311sNkM for ; + Sat, 24 Mar 2012 17:27:20 -0700 (PDT) +Received: from idcmail-mo1so.shaw.ca (idcmail-mo1so.shaw.ca [24.71.223.10]) + by olra.theworths.org (Postfix) with ESMTP id 597CC431FAE + for ; Sat, 24 Mar 2012 17:27:20 -0700 (PDT) +Received: from pd3ml2so-ssvc.prod.shaw.ca ([10.0.141.138]) + by pd2mo1so-svcs.prod.shaw.ca with ESMTP; 24 Mar 2012 18:27:19 -0600 +X-Cloudmark-SP-Filtered: true +X-Cloudmark-SP-Result: v=1.1 cv=w8ylZ/s5/CpB4NtJ57cq/Y3wf+h+jIFeVVN4WVEh/uc= + c=1 sm=1 + a=saxgr0PviV8A:10 a=BLceEmwcHowA:10 a=yQp6g8lIsgqumF79BAsFDg==:17 + a=mwQa1gFwvGsKjbHVRSwA:9 a=hYvXwCOoY5X3fdiITH4A:7 a=M5MoQqlICDDvGSWE:21 + a=dcSauvYQjqSYlL5g:21 a=HpAAvcLHHh0Zw7uRqdWCyQ==:117 +Received: from unknown (HELO lagos.xvx.ca) ([96.52.216.56]) + by pd3ml2so-dmz.prod.shaw.ca with ESMTP; 24 Mar 2012 18:27:19 -0600 +Received: by lagos.xvx.ca (Postfix, from userid 1000) + id E331E8004204; Sat, 24 Mar 2012 18:27:18 -0600 (MDT) +From: Adam Wolfe Gordon +To: notmuch@notmuchmail.org +Subject: [BUG/PATCH 0/2] Replying from other addresses in emacs +Date: Sat, 24 Mar 2012 18:27:10 -0600 +Message-Id: <1332635232-15269-1-git-send-email-awg+notmuch@xvx.ca> +X-Mailer: git-send-email 1.7.5.4 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 25 Mar 2012 00:27:22 -0000 + +Hi everyone, + +This patch series adds a test for and fixes a bug that Dmitry pointed +out on IRC yesterday: + +When replying to mail sent to an other_address, the CLI correctly sets +the From header to the address that received the message. This works +correctly in the default format and the JSON format. However, emacs was +ignoring the provided From header and inserting the primary address, due +to an incompatibility between how we construct the header list and how +the `mail-header` function from the message library looks up header +values in the list. + +People with other_addresses who are using the latest reply changes +should probably apply this patch right away. Without it, you might end +up replying to messages from the wrong address. + +Adam Wolfe Gordon (2): + test: Tests for reply from alternate addresses in emacs + emacs: Fix replying from alternate addresses + + emacs/notmuch-mua.el | 4 +- + test/emacs | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++ + 2 files changed, 53 insertions(+), 2 deletions(-) + +-- +1.7.5.4 + -- 2.26.2