From a09a0adc7d639ec868529f63d85dc40d6dae6608 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Wed, 15 Feb 2012 09:03:32 +0000 Subject: [PATCH] [RFC PATCH v5 04/11] lib: Rearrange the exclude code in query.cc --- 17/77b926b670f0ab0c6dec6409d84406fc1a4409 | 147 ++++++++++++++++++++++ 1 file changed, 147 insertions(+) create mode 100644 17/77b926b670f0ab0c6dec6409d84406fc1a4409 diff --git a/17/77b926b670f0ab0c6dec6409d84406fc1a4409 b/17/77b926b670f0ab0c6dec6409d84406fc1a4409 new file mode 100644 index 000000000..aaaf83225 --- /dev/null +++ b/17/77b926b670f0ab0c6dec6409d84406fc1a4409 @@ -0,0 +1,147 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id B8C5841ED83 + for ; Wed, 15 Feb 2012 01:03:16 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.201 +X-Spam-Level: +X-Spam-Status: No, score=0.201 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, + RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id r565b7f7E+OI for ; + Wed, 15 Feb 2012 01:03:12 -0800 (PST) +Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com + [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 94DE0421192 + for ; Wed, 15 Feb 2012 01:03:03 -0800 (PST) +Received: by wibhi8 with SMTP id hi8so453259wib.26 + for ; Wed, 15 Feb 2012 01:03:02 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; + h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; + bh=IqeCmc2ELfjZkxjYdYxRGHL3vbcGmotc+462IZgK1tU=; + b=s5SvO4gALtjXXTMHfdXhVLFfiKqUmc8KU59IGWlZtfqRZIryl1EzHxf8ldEbxzHSrQ + VJwBXLxg6MjH11k5nz+GQWqFal/+owwwETrN2Zq0FLpPIpXxeQBVsfJ0w7rDMfOMwXB4 + XgS+METwaNFn4C8Rmlp6zbOABlAaCnB8YrFFE= +Received: by 10.180.96.8 with SMTP id do8mr6983347wib.21.1329296582430; + Wed, 15 Feb 2012 01:03:02 -0800 (PST) +Received: from localhost (94-192-233-223.zone6.bethere.co.uk. + [94.192.233.223]) by mx.google.com with ESMTPS id + da8sm32095611wib.6.2012.02.15.01.03.00 (version=TLSv1/SSLv3 cipher=OTHER); + Wed, 15 Feb 2012 01:03:01 -0800 (PST) +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: [RFC PATCH v5 04/11] lib: Rearrange the exclude code in query.cc +Date: Wed, 15 Feb 2012 09:03:32 +0000 +Message-Id: <1329296619-7463-5-git-send-email-markwalters1009@gmail.com> +X-Mailer: git-send-email 1.7.2.3 +In-Reply-To: <1329296619-7463-1-git-send-email-markwalters1009@gmail.com> +References: <1329296619-7463-1-git-send-email-markwalters1009@gmail.com> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 15 Feb 2012 09:03:17 -0000 + +Slightly refactor the exclude code to give the callers access to the +exclude query itself. There should be no functional change. +--- + lib/query.cc | 29 +++++++++++++++++++---------- + 1 files changed, 19 insertions(+), 10 deletions(-) + +diff --git a/lib/query.cc b/lib/query.cc +index 0b36602..c25b301 100644 +--- a/lib/query.cc ++++ b/lib/query.cc +@@ -122,12 +122,15 @@ _notmuch_messages_destructor (notmuch_mset_messages_t *messages) + return 0; + } + +-/* Return a query that does not match messages with the excluded tags +- * registered with the query. Any tags that explicitly appear in +- * xquery will not be excluded. */ ++/* Return a query that matches messages with the excluded tags ++ * registered with query. Any tags that explicitly appear in xquery ++ * will not be excluded. The caller of this function has to combine ++ * the returned query appropriately.*/ + static Xapian::Query + _notmuch_exclude_tags (notmuch_query_t *query, Xapian::Query xquery) + { ++ Xapian::Query exclude_query = Xapian::Query::MatchNothing; ++ + for (notmuch_string_node_t *term = query->exclude_terms->head; term; + term = term->next) { + Xapian::TermIterator it = xquery.get_terms_begin (); +@@ -137,10 +140,10 @@ _notmuch_exclude_tags (notmuch_query_t *query, Xapian::Query xquery) + break; + } + if (it == end) +- xquery = Xapian::Query (Xapian::Query::OP_AND_NOT, +- xquery, Xapian::Query (term->string)); ++ exclude_query = Xapian::Query (Xapian::Query::OP_OR, ++ exclude_query, Xapian::Query (term->string)); + } +- return xquery; ++ return exclude_query; + } + + notmuch_messages_t * +@@ -168,7 +171,7 @@ notmuch_query_search_messages (notmuch_query_t *query) + Xapian::Query mail_query (talloc_asprintf (query, "%s%s", + _find_prefix ("type"), + "mail")); +- Xapian::Query string_query, final_query; ++ Xapian::Query string_query, final_query, exclude_query; + Xapian::MSet mset; + unsigned int flags = (Xapian::QueryParser::FLAG_BOOLEAN | + Xapian::QueryParser::FLAG_PHRASE | +@@ -188,7 +191,10 @@ notmuch_query_search_messages (notmuch_query_t *query) + mail_query, string_query); + } + +- final_query = _notmuch_exclude_tags (query, final_query); ++ exclude_query = _notmuch_exclude_tags (query, final_query); ++ ++ final_query = Xapian::Query (Xapian::Query::OP_AND_NOT, ++ final_query, exclude_query); + + enquire.set_weighting_scheme (Xapian::BoolWeight()); + +@@ -449,7 +455,7 @@ notmuch_query_count_messages (notmuch_query_t *query) + Xapian::Query mail_query (talloc_asprintf (query, "%s%s", + _find_prefix ("type"), + "mail")); +- Xapian::Query string_query, final_query; ++ Xapian::Query string_query, final_query, exclude_query; + Xapian::MSet mset; + unsigned int flags = (Xapian::QueryParser::FLAG_BOOLEAN | + Xapian::QueryParser::FLAG_PHRASE | +@@ -469,7 +475,10 @@ notmuch_query_count_messages (notmuch_query_t *query) + mail_query, string_query); + } + +- final_query = _notmuch_exclude_tags (query, final_query); ++ exclude_query = _notmuch_exclude_tags (query, final_query); ++ ++ final_query = Xapian::Query (Xapian::Query::OP_AND_NOT, ++ final_query, exclude_query); + + enquire.set_weighting_scheme(Xapian::BoolWeight()); + enquire.set_docid_order(Xapian::Enquire::ASCENDING); +-- +1.7.2.3 + -- 2.26.2