From 9d283d2aeaf1efb6d2182354e2924b02642c1735 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Thu, 16 Feb 2012 13:15:43 +1900 Subject: [PATCH] Re: [PATCH 0/8] Rewrite JSON show format --- c5/86a9d09f064625d837dd1ac1d7778f6c3b9146 | 124 ++++++++++++++++++++++ 1 file changed, 124 insertions(+) create mode 100644 c5/86a9d09f064625d837dd1ac1d7778f6c3b9146 diff --git a/c5/86a9d09f064625d837dd1ac1d7778f6c3b9146 b/c5/86a9d09f064625d837dd1ac1d7778f6c3b9146 new file mode 100644 index 000000000..d6a83b00c --- /dev/null +++ b/c5/86a9d09f064625d837dd1ac1d7778f6c3b9146 @@ -0,0 +1,124 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id D3F26431E84 + for ; Wed, 15 Feb 2012 10:17:28 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id cSAM6RVT38Tk for ; + Wed, 15 Feb 2012 10:17:25 -0800 (PST) +Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU + [18.7.68.37]) + by olra.theworths.org (Postfix) with ESMTP id F1238431E82 + for ; Wed, 15 Feb 2012 10:17:24 -0800 (PST) +X-AuditID: 12074425-b7f4a6d0000008e0-c7-4f3bf6b402cb +Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) + by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP + id 31.97.02272.4B6FB3F4; Wed, 15 Feb 2012 13:17:24 -0500 (EST) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q1FIHNRM017457; + Wed, 15 Feb 2012 13:17:23 -0500 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q1FIHLq3010035 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Wed, 15 Feb 2012 13:17:22 -0500 (EST) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1RxjOJ-00081j-Ek; Wed, 15 Feb 2012 13:15:43 -0500 +Date: Wed, 15 Feb 2012 13:15:43 -0500 +From: Austin Clements +To: Tomi Ollila +Subject: Re: [PATCH 0/8] Rewrite JSON show format +Message-ID: <20120215181543.GV27039@mit.edu> +References: <1329240823-7856-1-git-send-email-amdragon@mit.edu> + +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IR4hTV1t3yzdrf4O1zYYvrN2cyW7xZOY/V + gcnj8NeFLB7PVt1iDmCK4rJJSc3JLEst0rdL4MpoPfeaueAcb8X3+x9YGhi3c3UxcnBICJhI + /G4U6GLkBDLFJC7cW8/WxcjFISSwj1Hi/5xVjBDOBkaJZwduQzknmSQWbT7IBOEsYZRY/OIN + E0g/i4CqxLkzexhBbDYBDYlt+5eD2SICKhIP2tazgtjMAtIS3343g9ULCxhKHJ65mAXE5hXQ + kVg9+R0biC0kkCpx6MdkJoi4oMTJmU9YIHq1JG78e8kEcjbInOX/OEDCnAIGEv0TJoKtEgVa + NeXkNrYJjEKzkHTPQtI9C6F7ASPzKkbZlNwq3dzEzJzi1GTd4uTEvLzUIl0LvdzMEr3UlNJN + jKCwZndR3cE44ZDSIUYBDkYlHl6he1b+QqyJZcWVuYcYJTmYlER573yx9hfiS8pPqcxILM6I + LyrNSS0+xCjBwawkwqs9HSjHm5JYWZValA+TkuZgURLn1dR65yckkJ5YkpqdmlqQWgSTleHg + UJLgvfQVqFGwKDU9tSItM6cEIc3EwQkynAdouMc3kOHFBYm5xZnpEPlTjIpS4rw/QZoFQBIZ + pXlwvbC084pRHOgVYV4OkHYeYMqC634FNJgJaLD5CyuQwSWJCCmpBsZp1zmC19qVx0xKfy6y + L3PR1RP32f8YVzrFfDMqeMbhlHphVeuK6Qe23o+/89gian9532n/iN5UnYNGs5rnrBG+Nud9 + /8dH7F+yZ37++rlI4k3SqhlrNTTsbx4W8tLJfHNl9WHWwgm/3yUtVmC/5/Tz8xP2FpHFApMX + XJWrnVY2Qf7R7k2PMloilFiKMxINtZiLihMB1t1VehYDAAA= +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 15 Feb 2012 18:17:29 -0000 + +Quoth Tomi Ollila on Feb 15 at 5:00 pm: +> On Tue, 14 Feb 2012 12:33:35 -0500, Austin Clements wrote: +> > The saga continues. As for the text format, this first shifts lots of +> > code around without changing its semantics, then it dives in and +> > simplifies a lot of things. Don't be put off by the number of +> > patches; most of them are straightforward. +> > +> > As an added bonus, I documented (!) the JSON format for both show and +> > search. +> +> I got 2 trailing whitespace "errors" when applied (schemata) patches. + +Oops. Will fix in v2. + +> +> Emacs MUA works for me. +> +> Most json-related tests pass (for me), but I get this: +> +> FAIL notmuch-show for message with invalid From +> --- emacs.10.expected 2012-02-15 14:28:48.000000000 +0000 +> +++ emacs.10.output 2012-02-15 14:28:48.000000000 +0000 +> @@ -1,4 +1,4 @@ +> -"Invalid " (2001-01-05) (inbox) +> +Invalid From (2001-01-05) (inbox) +> +> If this works for others then the problem is in my setup +> (I have 8 other tests failing for various other reasons) +> +> The patch in id:"1329240823-7856-5-git-send-email-amdragon@mit.edu" +> changes this -- the + line is almost like it was (without that ). +> Maybe the reason is within gmime-2.4.20-1.el5.rf I'm having in this +> machine -- have to try on another... +> +> ...YES. other machine has (self-compiled) gmime 2.4.25 and there I got + +The from header is now being parsed by gmime, so if gmime's parsing of +invalid headers has changed, it's quite possible it would affect this +test. + +> All 370 tests behaved as expected (2 expected failures). +> +> Code LGTM. +> +> +1 +> +> Tomi -- 2.26.2