From 9ccae4e6e3cd43083d0f3b5c2d233f6d68022f68 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Sun, 12 Feb 2012 21:51:20 +0000 Subject: [PATCH] Re: [RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view with split-pane --- 69/fd2b6478e318c586a17d76c6b475ba9ba0e2b4 | 105 ++++++++++++++++++++++ 1 file changed, 105 insertions(+) create mode 100644 69/fd2b6478e318c586a17d76c6b475ba9ba0e2b4 diff --git a/69/fd2b6478e318c586a17d76c6b475ba9ba0e2b4 b/69/fd2b6478e318c586a17d76c6b475ba9ba0e2b4 new file mode 100644 index 000000000..464b9bd73 --- /dev/null +++ b/69/fd2b6478e318c586a17d76c6b475ba9ba0e2b4 @@ -0,0 +1,105 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id AF1D4431FAE + for ; Sun, 12 Feb 2012 13:50:02 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id mH2M9GAb+7kz for ; + Sun, 12 Feb 2012 13:50:02 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id D8CDE429E52 + for ; Sun, 12 Feb 2012 13:50:01 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1RwhJ2-0006wo-9M; Sun, 12 Feb 2012 21:50:00 +0000 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1RwhJ2-0003EA-0n; Sun, 12 Feb 2012 21:50:00 +0000 +From: Mark Walters +To: Jameson Graef Rollins , + notmuch@notmuchmail.org +Subject: Re: [RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view + with split-pane +In-Reply-To: <878vk73hxq.fsf@servo.finestructure.net> +References: <1329072579-27340-1-git-send-email-markwalters1009@gmail.com> + <878vk73hxq.fsf@servo.finestructure.net> +User-Agent: Notmuch/0.11.1+192~g23e894e (http://notmuchmail.org) Emacs/23.2.1 + (i486-pc-linux-gnu) +Date: Sun, 12 Feb 2012 21:51:20 +0000 +Message-ID: <87zkcnra93.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 40fbea20fc0f6804767c4a549cc463f6 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 12 Feb 2012 21:50:02 -0000 + +On Sun, 12 Feb 2012 12:39:13 -0800, Jameson Graef Rollins wrote: +> On Sun, 12 Feb 2012 18:49:36 +0000, Mark Walters wrote: +> > Here is a rebased version of the notmuch-pick patch set +> > id:"87d39k1gvi.fsf@qmul.ac.uk". It now applies directly +> > to master since Jani's notmuch-show command line parsing +> > has been pushed. +> +> Hey, Mark. Thanks for working on this. However, none of the patches +> have commit messages, so there's no explanation for what any of the +> patches are supposed to do. This is particularly bothersome for the +> first patch, which introduces a lot of unexplained changes to the cli. +> +> I think I would like to review this patch set, since I think I'm +> interested in the functionality it may be introducing, but without any +> commit messages or explanation what the patches are meant to do it's +> kind of a non starter for me. + +Hi + +At the moment I was mostly looking for feedback on whether people like +the final outcome (i.e., whether people liked it enough to be worth +tidying). I will add comments on the first two patches. + +Best wishes + +Mark + -- 2.26.2